[minor] Merge pushOffer() and pushParam() into push()

Author: lpinca

lib/Extensions.js

@@ -23,29 +23,18 @@ const tokenChars = [
 ];
 
 /**
- * Adds an offer to the map of extension offers.
+ * Adds an offer to the map of extension offers or a parameter to the map of
+ * parameters.
  *
- * @param {Object} offers The map of extension offers
- * @param {String} name The extension name
- * @param {Object} params The extension parameters
+ * @param {Object} dest The map of extension offers or parameters
+ * @param {String} name The extension or parameter name
+ * @param {(Object|Boolean|String)} elem The extension parameters or the
+ * parameter value
  * @private
  */
-function pushOffer (offers, name, params) {
- if (Object.hasOwnProperty.call(offers, name)) offers[name].push(params);
- else offers[name] = [params];
-}
-
-/**
- * Adds a parameter to the map of parameters.
- *
- * @param {Object} params The map of parameters
- * @param {String} name The parameter name
- * @param {Object} value The parameter value
- * @private
- */
-function pushParam (params, name, value) {
- if (Object.hasOwnProperty.call(params, name)) params[name].push(value);
- else params[name] = [value];
+function push (dest, name, elem) {
+ if (Object.prototype.hasOwnProperty.call(dest, name)) dest[name].push(elem);
+ else dest[name] = [elem];
 }
 
 /**
@@ -83,7 +72,7 @@ function parse (header) {
  if (end === -1) end = i;
  const name = header.slice(start, end);
  if (code === 0x2c) {
- pushOffer(offers, name, params);
+ push(offers, name, params);
  params = {};
  } else {
  extensionName = name;
@@ -102,9 +91,9 @@ function parse (header) {
  if (start === -1) throw new Error(`unexpected character at index ${i}`);
 
  if (end === -1) end = i;
- pushParam(params, header.slice(start, end), true);
+ push(params, header.slice(start, end), true);
  if (code === 0x2c) {
- pushOffer(offers, extensionName, params);
+ push(offers, extensionName, params);
  params = {};
  extensionName = undefined;
  }
@@ -155,9 +144,9 @@ function parse (header) {
  value = value.replace(/\\/g, '');
  mustUnescape = false;
  }
- pushParam(params, paramName, value);
+ push(params, paramName, value);
  if (code === 0x2c) {
- pushOffer(offers, extensionName, params);
+ push(offers, extensionName, params);
  params = {};
  extensionName = undefined;
  }
@@ -175,16 +164,16 @@ function parse (header) {
  if (end === -1) end = i;
  const token = header.slice(start, end);
  if (extensionName === undefined) {
- pushOffer(offers, token, {});
+ push(offers, token, {});
  } else {
  if (paramName === undefined) {
- pushParam(params, token, true);
+ push(params, token, true);
  } else if (mustUnescape) {
- pushParam(params, paramName, token.replace(/\\/g, ''));
+ push(params, paramName, token.replace(/\\/g, ''));
  } else {
- pushParam(params, paramName, token);
+ push(params, paramName, token);
  }
- pushOffer(offers, extensionName, params);
+ push(offers, extensionName, params);
  }
 
  return offers;