Merge branch 'qa/80'

Close #80

Author: michalbundyra

.travis.yml

@@ -1,5 +1,3 @@
-sudo: false
-
 language: php
 
 cache:
@@ -33,6 +31,15 @@ matrix:
  - php: 7.2
  env:
  - DEPS=latest
+ - php: 7.3
+ env:
+ - DEPS=lowest
+ - php: 7.3
+ env:
+ - DEPS=locked
+ - php: 7.3
+ env:
+ - DEPS=latest
 
 before_install:
  - if [[ $TEST_COVERAGE != 'true' ]]; then phpenv config-rm xdebug.ini || return 0 ; fi

CHANGELOG.md

@@ -6,7 +6,7 @@ All notable changes to this project will be documented in this file, in reverse
 
 ### Added
 
-- Nothing.
+- [#80](https://github.com/zendframework/zend-expressive-router/pull/80) adds support for PHP 7.3.
 
 ### Changed
 

test/RouteTest.php

@@ -121,14 +121,28 @@ public function testRouteNameWithGetAndPost()
  $this->assertSame('/test^GET' . Route::HTTP_METHOD_SEPARATOR . RequestMethod::METHOD_POST, $route->getName());
  }
 
- public function testThrowsExceptionDuringConstructionIfPathIsNotString()
+ /**
+ * @requires PHP < 7.3
+ */
+ public function testThrowsExceptionDuringConstructionIfPathIsNotStringPhpPriorTo73()
  {
  $this->expectException(TypeError::class);
  $this->expectExceptionMessage('must be of the type string, integer given');
 
  new Route(12345, $this->noopMiddleware);
  }
 
+ /**
+ * @requires PHP 7.3
+ */
+ public function testThrowsExceptionDuringConstructionIfPathIsNotString()
+ {
+ $this->expectException(TypeError::class);
+ $this->expectExceptionMessage('must be of the type string, int given');
+
+ new Route(12345, $this->noopMiddleware);
+ }
+
  public function testThrowsExceptionDuringConstructionOnInvalidMiddleware()
  {
  $this->expectException(TypeError::class);