Timeline for How to debug Uncaught TypeError: Argument must be class A, class B given
Current License: CC BY-SA 3.0
14 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Apr 13, 2017 at 12:54 | history | edited | CommunityBot | replaced http://magento.stackexchange.com/ with https://magento.stackexchange.com/ | |
| Nov 5, 2016 at 2:18 | comment | added | peedee | Thank you guys for pitching in here. I have just added some important findings to my answer below about having to manually delete the files, but I have a feeling that yours is going to be upvoted much more than mine, so you might consider adding it to your answer. | |
| Nov 4, 2016 at 11:15 | history | edited | Raphael at Digital Pianism | CC BY-SA 3.0 | added 135 characters in body |
| Nov 4, 2016 at 11:12 | comment | added | Marius | Aparently I was wrong. It's not the ECGM2 standard. It's the static test that complains about itbin/magento dev:tests:run static. This is what complains about the order of the parameters | |
| Nov 4, 2016 at 10:29 | comment | added | Raphael at Digital Pianism | @Marius I've re added my deleted case as an extra case to point that out | |
| Nov 4, 2016 at 10:29 | history | edited | Raphael at Digital Pianism | CC BY-SA 3.0 | added 729 characters in body |
| Nov 4, 2016 at 10:26 | comment | added | Vinai | Consistency is good. But that is worthless consistency. It's just adding additional unneeded coupling! Wtf! | |
| Nov 4, 2016 at 10:25 | comment | added | Marius | I guess it's more about "consistency" (you remember consistency from mm16ro :D) than about correctness. | |
| Nov 4, 2016 at 10:24 | comment | added | Vinai | What a stupid rule. | |
| Nov 4, 2016 at 10:24 | comment | added | Marius | @Vinai. The order is irrelevant but the code sniffer with the ECGM2 standards complains about it. It requires this order: Parent class mandatory arguments, class specific mandatory arguments, optional arguments. | |
| Nov 4, 2016 at 9:01 | comment | added | Raphael at Digital Pianism | @Vinai that's right, I removed that bit it was probably confusing. | |
| Nov 4, 2016 at 9:01 | history | edited | Raphael at Digital Pianism | CC BY-SA 3.0 | deleted 777 characters in body |
| Nov 4, 2016 at 8:56 | comment | added | Vinai | The order of the arguments is irrelevant afaik, as long as the optional parameters (the ones with default values like $data = [] for example, come last. However, if more then one parameter is optional, the order of those doesn't matter (e.g. $data = [], $adapter = null works just as $adapter = null, $data = []); Deleting var/generation (or at least the generated class in question) always has to be done after changing the signature of a public method, even in developer mode. | |
| Nov 4, 2016 at 8:47 | history | answered | Raphael at Digital Pianism | CC BY-SA 3.0 |