Need tests covering page moves, etc.
Closed, ResolvedPublicFeature
Actions

Assigned To

Authored By

	TTO
	Nov 17 2014, 5:22 AM

Description

A while ago a patch of mine was merged to MW core which broke page moves (see followup Gerrit change 170882). Jenkins greenlighted the original change, because there isn't even a single unit test that tests page moves.

Test coverage of the includes/page directory [1] is pretty woeful in general. Article.php and WikiPage.php in particular are pretty crucial files in the MediaWiki code base; any stuff-ups there are likely to break such basic features as page editing, moves, deletion, etc.

[1] https://integration.wikimedia.org/cover/mediawiki-core/master/php/includes_page.html

Version: unspecified
Severity: enhancement

Details

Reference: bz73507

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:48 AM

• bzimport added a project: MediaWiki-Core-Tests.

• bzimport set Reference to bz73507.

• bzimport added a subscriber: Unknown Object (MLST).

TTO created this task.Nov 17 2014, 5:22 AM

Would this be a potential tasks for new contributors ("easy") if good documentation (link?) is available to write unit tests?

Aklapper lowered the priority of this task from Medium to Low.Mar 9 2015, 2:19 PM

Aklapper subscribed.

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.Jul 7 2017, 5:17 AM

Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 11:12 AM

Aklapper removed a subscriber: • wikibugs-l-list.

Tests have been written in the intervening 9 years.

Updated coverage link for those curious: https://doc.wikimedia.org/cover/mediawiki-core/includes/page/index.html

Need tests covering page moves, etc.Closed, ResolvedPublicFeatureActions

Description

Details

Event Timeline

Need tests covering page moves, etc.
Closed, ResolvedPublicFeature
Actions