Skip to main content

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

3
  • 2
    result repeated 4 times in 2 statements hurts my eyes. Also, when I see couple of classes with interface like SomeType doSomething(SomeType), first thing that jumps to mind is that's the case for Builder. output=PreProcessingBuilder.consume(input).blackAndWhite().invert().build() Commented Jul 17, 2013 at 10:51
  • This is a good point. For now I am not very familar with this pattern, but I'll consider that! Commented Jul 17, 2013 at 10:54
  • ...But that's just feelings, mere guesses. To see the line, line that lies between good and bad, I'd write a unit test suite covering usage scenarios for my design and study how it looks like from the side of client code that will use it. As an additional benefit, this suite would also help me avoid regressions when modifying / maintaining my design Commented Jul 17, 2013 at 10:55