Skip to main content
Software Engineering

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Required fields*

12
  • It's certainly not good, but without knowing what's actually going on, we are probably not going to be able to suggest how to improve things. Commented Jan 12, 2014 at 18:16
  • @Telastyn I hope my edit makes things clearer. If not, let me know. Commented Jan 12, 2014 at 18:22
  • Not really. The method depending on some passed in state rather than some internal state is beyond smelly. Commented Jan 12, 2014 at 18:30
  • 1
    you can still replace the meaningless class names with comparable concepts and add a story that, although hypothetical, could provide insight into what you're trying to do. When you say "depending on a path the user picks" I'm thinking Strategy, State, DI, ... but we're all still pretty much guessing here. You're wasting time right now on a post that isn't getting you anywhere but more comments. Take the time to make the SSCCE ;-) Commented Jan 12, 2014 at 19:39
  • 1
    Tell, don't ask: myPojo.whatKindOfReport()==Reports.reportTypes => myPojo.isKindOf(Reports.reportTypes) or myPojo.hasKindOf(Reports.reportTypes) Commented Jan 12, 2014 at 23:26