Skip to main content
12 events
when toggle format what by license comment
May 30, 2016 at 2:45 comment added Insane @maple_shaft has already moved long conversations to chat once. does he have to do it again?
May 26, 2016 at 0:32 comment added Stephen @Voo I love having my code reviewed. It forces me to write better code and justify my decisions to someone who is viewing it without prejudice. I've never been yelled at or even aggressively attacked during a code review.
May 25, 2016 at 12:14 comment added Holger @Voo: you don’t need to “reverse engineer coding style guides”. The conventions should be apparent when looking at the existing code. Everything which doesn’t immediately jump into the eye is either, uncommon or not even fixed. In case there are really important rules about something rarely occurring, it might be worth discussing it with the new developers, when they are the ones who have to write such code. Communication can’t be overestimated.
May 25, 2016 at 5:49 comment added Voo @Jaap I thought the hyperbole was obvious.. apparently not. No not yelling at people, but telling them that they have to go back and fix all the things they violated because they couldn't know better.
May 25, 2016 at 4:24 comment added aroth 5. If they're not written down anywhere, rules pedants can't point out that your code hasn't technically been following the standards for months and should all be revised even though it's working fine.
May 24, 2016 at 20:39 comment added Jaap @Voo, why do you feel you need to yell during a code review if an issue comes up?
May 24, 2016 at 19:54 vote accept Nolan Akash
May 24, 2016 at 19:44 comment added Voo Do you really not have a standard document, but just yell at people for the first few weeks at every code review? This seems like you'd basically expect beginners to reverse engineer your coding style guides. Or is this more a hypothetical "I think that's what he meant"? Now if this is about automatic tools enforcing those rules - agreed, that's essential. But I don't want to have to laboriously figure out the rules.
May 24, 2016 at 18:35 comment added Wayne Werner And if you want to enforce things, you should have a build process step that enforces it, not a style guide that does.
S May 24, 2016 at 14:41 history mod moved comments to chat
S May 24, 2016 at 14:41 comment added maple_shaft Comments are not for extended discussion; this conversation has been moved to chat.
May 24, 2016 at 4:34 history answered Stephen CC BY-SA 3.0