Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

Okay, adding a load of explicit methods sounds more convoluted to me in the short term but I'm totally happy to do it if it's a better architectural decision, I'm trying to up my programming game here, not get this thing working quickly :) So would making all communication go via methods in the parent class count as the mediator pattern?

Roger Heathcote
– Roger Heathcote

2016-09-27 10:14:10 +00:00
Commented Sep 27, 2016 at 10:14
@technicalbloke - While many suggestions given by the people in Snowman's possible duplicate question implied otherwise. I 100% believe this to be a RULE, not just a suggestion unless you enjoy writing buggy and unmaintainable code. "Child classes should not know who contains them" Thus, calling back into the parent requires the child to know who contains them. That means the interpretation you wrote in your comment is a big NO. Your design is bad, but if you must use what you have then you are better off passing what each class needs to who needs it. e.g. AudioEngine to WaveFormDisplay.

Dunk
– Dunk

2016-09-27 19:52:22 +00:00
Commented Sep 27, 2016 at 19:52
@Dunk - Yes I thought it looked smelly, thanks for helping me clear it up. Happily I'm not stuck with this design, I'm rewriting an app I wrote quickly (and badly) a while back and trying to do a better job this time round. I'm very keen to reduce coupling in my code, but like most things worth doing it's easier said than done!

Roger Heathcote
– Roger Heathcote

2016-09-29 08:29:04 +00:00
Commented Sep 29, 2016 at 8:29

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »