Skip to main content
deleted 222 characters in body
Source Link
kevin cline
  • 33.8k
  • 3
  • 73
  • 143

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.

P.S. Your colleague sounds a bit like the kid who keeps asking complex questions to make sure everyone remembers how smart they are. Someone needs to tell him that code review is not a time to bring up out-of-scope issues.

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.

P.S. Your colleague sounds a bit like the kid who keeps asking complex questions to make sure everyone remembers how smart they are. Someone needs to tell him that code review is not a time to bring up out-of-scope issues.

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.

added 226 characters in body
Source Link
kevin cline
  • 33.8k
  • 3
  • 73
  • 143

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.

P.S. Your colleague sounds a bit like the kid who keeps asking complex questions to make sure everyone remembers how smart they are. Someone needs to tell him that code review is not a time to bring up out-of-scope issues.

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.

P.S. Your colleague sounds a bit like the kid who keeps asking complex questions to make sure everyone remembers how smart they are. Someone needs to tell him that code review is not a time to bring up out-of-scope issues.

Source Link
kevin cline
  • 33.8k
  • 3
  • 73
  • 143

Since it wasn't handled before, it's out of scope for your effort. You or your colleague can ask your manager if it's worth the effort to cover this case.