You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
Required fields*
- 1I guess I'm just trying to figure out where the line is. In a recent task, I had to perform a fairly simple operation, but it was in a codebase without much existing scaffolding or functionality. As such, everything I needed to do was very simple, but all pretty unique and didn't seem to fit in shared classes. In my case, I needed to save a document to a network drive, and log it to two separate database tables. The rules surrounding each step were fairly particular. Even the filename generation (a simple guid) had a few classes to make testing more convenient.JD Davis– JD Davis2019-07-09 14:14:48 +00:00Commented Jul 9, 2019 at 14:14
- 3Again, @JDDavis, choosing multiple classes over a single one purely for testability purposes is putting the cart before the horse, and it goes directly against the SRP, which calls for grouping cohesive functionalities together. I can't advise you on particulars, but the problem that individual functional changes require modifying many files is an issue that you should be addressing (and attempting to avoid), not one that you should be trying to justify.John Bollinger– John Bollinger2019-07-09 14:23:47 +00:00Commented Jul 9, 2019 at 14:23
- Agreeing, I add this. To quote Wikipedia, "Martin defines a responsibility as a reason to change, and concludes that a class or module should have one, and only one, reason to be changed (i.e. rewritten)." and "he more recently stated "This principle is about people."" In fact, I believe this means that the "responsibility" in SRP refers to stakeholders, not functionality. A class should be responsible for changes required by only one stakeholder (person requiring that you change your program), so that you change as FEW things as possible in response to different stakeholders demanding change.Corrodias– Corrodias2019-07-11 19:49:34 +00:00Commented Jul 11, 2019 at 19:49
Add a comment |
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you
lang-cs