Edit - Software Engineering Stack Exchange

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

(It may also be reasonable for user.changePassword(newPassword) to throw an Exception to say that it won't set a weak password at that level, so that one could maybe stay...)

Jeremy Hunt
– Jeremy Hunt

2021-08-19 07:27:10 +00:00
Commented Aug 19, 2021 at 7:27
I see. So, the "alternative" is to let the client with more code - do all the checking. And then I guess, the exceptions can remain as unchecked.

George Z.
– George Z.

2021-08-19 11:15:02 +00:00
Commented Aug 19, 2021 at 11:15
1

Your implementation violates the Tell, Don't Ask principle [1,2]. I believe you also have a misconception about what a responsibility is. There's nothing fundamentally wrong with OP's code (and your implementation may be acceptable in some contexts as well, even if it violates the principle).

Vincent Savard
– Vincent Savard

2021-08-19 12:29:49 +00:00
Commented Aug 19, 2021 at 12:29

Add a comment |

Correct minor typos or mistakes
Clarify meaning without changing it
Add related resources or links
Always respect the author’s intent
Don’t use edits to reply to the author

create code fences with backticks ` or tildes ~
```
like so
```
add language identifier to highlight code
```python
def function(foo):
print(foo)
```
put returns between paragraphs
for linebreak add 2 spaces at end
_italic_ or **bold**
indent code by 4 spaces
backtick escapes `like _so_`
quote by placing > at start of line
to make links (use https whenever possible)

<https://example.com>

[example](https://example.com)

<a href="https://example.com">example</a>

formatting help »
answering help »