Add test & fix packed packet parsing error for SASL authentication messages

Author: brianc

packages/pg-protocol/src/inbound-parser.test.ts

@@ -210,8 +210,21 @@ describe('PgPacketStream', function () {
  testForMessage(md5PasswordBuffer, expectedMD5PasswordMessage)
  testForMessage(SASLBuffer, expectedSASLMessage)
  testForMessage(SASLContinueBuffer, expectedSASLContinueMessage)
+
+ // this exercises a found bug in the parser:
+ // https://github.com/brianc/node-postgres/pull/2210#issuecomment-627626084
+ // and adds a test which is deterministic, rather than relying on network packet chunking
+ const extendedSASLContinueBuffer = Buffer.concat([SASLContinueBuffer, Buffer.from([1, 2, 3, 4])])
+ testForMessage(extendedSASLContinueBuffer, expectedSASLContinueMessage)
+
  testForMessage(SASLFinalBuffer, expectedSASLFinalMessage)
 
+ // this exercises a found bug in the parser:
+ // https://github.com/brianc/node-postgres/pull/2210#issuecomment-627626084
+ // and adds a test which is deterministic, rather than relying on network packet chunking
+ const extendedSASLFinalBuffer = Buffer.concat([SASLFinalBuffer, Buffer.from([1, 2, 4, 5])])
+ testForMessage(extendedSASLFinalBuffer, expectedSASLFinalMessage)
+
  testForMessage(paramStatusBuffer, expectedParameterStatusMessage)
  testForMessage(backendKeyDataBuffer, expectedBackendKeyDataMessage)
  testForMessage(readyForQueryBuffer, expectedReadyForQueryMessage)

packages/pg-protocol/src/parser.ts

@@ -296,11 +296,11 @@ export class Parser {
  break
  case 11: // AuthenticationSASLContinue
  message.name = MessageName.authenticationSASLContinue
- message.data = this.reader.string(length - 4)
+ message.data = this.reader.string(length - 8)
  break
  case 12: // AuthenticationSASLFinal
  message.name = MessageName.authenticationSASLFinal
- message.data = this.reader.string(length - 4)
+ message.data = this.reader.string(length - 8)
  break
  default:
  throw new Error('Unknown authenticationOk message type ' + code)