Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Conversation

@ajtowf
Copy link

@ajtowf ajtowf commented Mar 28, 2017

Fixes #812

@dnfclas
Copy link

dnfclas commented Mar 28, 2017

@ajtowf,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects.
Thanks,
.NET Foundation Pull Request Bot

@dnfclas
Copy link

dnfclas commented Mar 28, 2017

@ajtowf, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, .NET Foundation Pull Request Bot

@SteveSandersonMS
Copy link
Member

Thanks for this PR

However, the underlying issue has since been fixed upstream in browserify-sign: browserify/browserify-sign#36, so I don't think it's necessary to also implement a workaround here in this repo.

Since we no longer need a fix here, I'll close this. Hope that's OK!

@ajtowf
Copy link
Author

ajtowf commented Mar 30, 2017

@SteveSandersonMS yup, that fix came in a couple of hours later, no worries! :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants