Skip to content

Conversation

@joberstein
Copy link
Contributor

Link to original PR: #3633

Just re-applying the changes.

@joberstein
Copy link
Contributor Author

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

@escapedcat
Copy link
Member

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

Thanks! Let me know when you think it can be merged.
This is not a breaking change for others, right? Just want to double check that.

@joberstein
Copy link
Contributor Author

@escapedcat I still need to re-test this locally but I think I've re-applied the necessary changes.

Thanks! Let me know when you think it can be merged. This is not a breaking change for others, right? Just want to double check that.

It should not be breaking, now that node >= 16 is required, but I'll take another look at the changelog also.

@joberstein joberstein changed the base branch from master to renovate/tar-fs-3.x October 26, 2023 03:12
@joberstein joberstein changed the base branch from renovate/tar-fs-3.x to master October 26, 2023 03:12
@escapedcat
Copy link
Member

Changelog looks good. Will merge again :P

@escapedcat escapedcat merged commit 1ff49ea into conventional-changelog:master Oct 26, 2023
@joberstein
Copy link
Contributor Author

I didn't get a chance to test it out yesterday but I didn't see any other breaking changes yesterday (only additive like support for Esm).

I'll test it out today but it's pretty identical to the original.

@joberstein
Copy link
Contributor Author

@escapedcat seems like it's working well, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants