Skip to content

Commit 80caf2e

Browse files
authored
[Inference API] Use extractOptionalPositiveInteger instead of remove as type in HuggingFaceServiceSettings (elastic#110278)
1 parent cdc9914 commit 80caf2e

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/huggingface/HuggingFaceServiceSettings.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,9 @@
3333
import static org.elasticsearch.xpack.inference.services.ServiceFields.URL;
3434
import static org.elasticsearch.xpack.inference.services.ServiceUtils.convertToUri;
3535
import static org.elasticsearch.xpack.inference.services.ServiceUtils.createUri;
36+
import static org.elasticsearch.xpack.inference.services.ServiceUtils.extractOptionalPositiveInteger;
3637
import static org.elasticsearch.xpack.inference.services.ServiceUtils.extractRequiredString;
3738
import static org.elasticsearch.xpack.inference.services.ServiceUtils.extractSimilarity;
38-
import static org.elasticsearch.xpack.inference.services.ServiceUtils.removeAsType;
3939

4040
public class HuggingFaceServiceSettings extends FilteredXContentObject implements ServiceSettings, HuggingFaceRateLimitServiceSettings {
4141
public static final String NAME = "hugging_face_service_settings";
@@ -49,8 +49,13 @@ public static HuggingFaceServiceSettings fromMap(Map<String, Object> map, Config
4949
var uri = extractUri(map, URL, validationException);
5050

5151
SimilarityMeasure similarityMeasure = extractSimilarity(map, ModelConfigurations.SERVICE_SETTINGS, validationException);
52-
Integer dims = removeAsType(map, DIMENSIONS, Integer.class);
53-
Integer maxInputTokens = removeAsType(map, MAX_INPUT_TOKENS, Integer.class);
52+
Integer dims = extractOptionalPositiveInteger(map, DIMENSIONS, ModelConfigurations.SERVICE_SETTINGS, validationException);
53+
Integer maxInputTokens = extractOptionalPositiveInteger(
54+
map,
55+
MAX_INPUT_TOKENS,
56+
ModelConfigurations.SERVICE_SETTINGS,
57+
validationException
58+
);
5459
RateLimitSettings rateLimitSettings = RateLimitSettings.of(
5560
map,
5661
DEFAULT_RATE_LIMIT_SETTINGS,

0 commit comments

Comments
 (0)