Adapt worker and nanny to ipv6#9133
Conversation
csfldf force-pushed the fix/adapt_ipv6 branch 2 times, most recently from b3448d3 to aecb91d Compare 
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 9h 57m 6s ⏱️ + 8m 58s For more details on these failures, see this check. Results for commit 36d971a. ± Comparison against base commit 4c61f86. ♻️ This comment has been updated with latest results. |
jacobtomlinson left a comment
jacobtomlinson left a comment There was a problem hiding this comment.
Thanks! We always aim to support IPv6, but as we don't have access to an IPv6 only CI environment it's hard to test.
csfldf force-pushed the fix/adapt_ipv6 branch 2 times, most recently from b38051b to 42fe1cf Compare csfldf force-pushed the fix/adapt_ipv6 branch from 42fe1cf to 70dc0bd Compare 
csfldf force-pushed the fix/adapt_ipv6 branch from 70dc0bd to 36d971a Compare 
| CI failures are related to #9135 |
Got it. I will re-trigger CI workflow after your pr merged. Thanks for your help! |
| All clear to re-trigger |
done |
jacobtomlinson left a comment
jacobtomlinson left a comment There was a problem hiding this comment.
CI failure is unrelated. Thanks for iterating on this!
2 participants
We found we failed to create SSH Cluster in ipv6 only machines and it's because some codes in worker, nanny modules work only for ipv4 environment.
This pr tries to adapt worker and annny to ipv6 and we have verified it works in our ipv6 only environment.
pre-commit run --all-files