Update tests and documentation for new properties

Author: jameslawler

README.md

@@ -80,7 +80,9 @@ return fetch('http://www.nasa.gov/rss/dyn/breaking_news.rss')
  summary: undefined, // summary of the channel
  },
  items: [{ // list of items in the feed
+ id: undefined, // item id
  title: undefined, // item title
+ imageUrl: undefined, // item image url
  links: [{
  url: undefined, // item link url
  rel: undefined // type of item link
@@ -138,7 +140,9 @@ return fetch('http://www.nasa.gov/rss/dyn/breaking_news.rss')
 
 | Parsed Value | RSS v2.0 | Atom v1.0 |
 | ------------- | ------------- | ------------- |
+| id | guid | id |
 | title | title | title |
+| imageUrl | | icon |
 | links | link | link |
 | description | description | summary |
 | content | | content |

model/rss.js

@@ -54,7 +54,7 @@ model.rss = {
  rel: undefined
  }],
  id: undefined,
- image: undefined,
+ imageUrl: undefined,
  description: undefined,
  content: undefined,
  categories: [{

package.json

@@ -1,6 +1,6 @@
 {
  "name": "react-native-rss-parser",
- "version": "1.1.0",
+ "version": "1.2.0",
  "description": "React Native compatible package to parse RSS feeds",
  "main": "index.js",
  "scripts": {

parsers/atomv1.js

@@ -88,10 +88,12 @@ function getChannelCategories(node) {
 
 function getChannelImage(node) {
  var img = utils.getElementTextContent(node, 'image');
- if(img == '' || img == undefined || img == null){
+
+ if(img === '' || img === undefined){
  img = utils.getElementTextContent(node, 'logo');
  }
- if(img == '' || img == undefined || img == null){
+
+ if(img === '' || img === undefined){
  img = utils.getElementTextContent(node, 'icon');
  }
 
@@ -129,7 +131,7 @@ function getItemContent(node) {
  return utils.getElementTextContent(node, 'content');
 }
 
-function getItemIcon(node) {
+function getItemImage(node) {
  return utils.getElementTextContent(node, 'icon');
 }
 
@@ -155,9 +157,11 @@ function getItemCategories(node) {
 
 function getItemPublished(node) {
  var pub = utils.getElementTextContent(node, 'updated');
- if(pub == '' || pub == undefined || pub == null){
+
+ if(pub === '' || pub === undefined){
  utils.getElementTextContent(node, 'published');
  }
+
  return pub;
 }
 
@@ -188,7 +192,7 @@ function mapItems(document) {
  links: getItemLinks(item),
  description: getItemDescription(item),
  id: getItemId(item),
- image: getItemIcon(item),
+ imageUrl: getItemImage(item),
  content: getItemContent(item),
  authors: getItemAuthors(item),
  categories: getItemCategories(item),

test/samples/atomv1.js

@@ -2,7 +2,8 @@ exports.feed = `
 <?xml version="1.0" encoding="utf-8"?>
 <feed xmlns="http://www.w3.org/2005/Atom">
 <title>ATOM title</title>
-<subtitle>A sample ATOM feed</subtitle>
+ <subtitle>A sample ATOM feed</subtitle>
+ <logo>https://b.thumbs.redditmedia.com/ntr1FkBiO3nk4t4Vgy5GXoPQ_j2hirENH9iT8rXNf8M.png</logo>
  <generator uri="http://jekyllrb.com" version="3.1.2">Jekyll</generator>
  <link href="http://bakery-store.example.com/" rel="alternate" type="text/html" />
  <updated>2016-05-13T16:22:08+12:00</updated>
@@ -14,6 +15,7 @@ exports.feed = `
  <published>2016-01-02T00:00:00+13:00</published>
  <updated>2016-01-02T00:00:00+13:00</updated>
  <id>http://bakery-store.example.com/information/2016/01/02/where-did-the-cookie-come-from</id>
+ <icon>https://b.thumbs.redditmedia.com/ntr1FkBiO3nk4t4Vgy5GXoPQ_j2hirENH9iT8rXNf8.png</icon>
  <content type="html" xml:base="http://bakery-store.example.com/information/2016/01/02/where-did-the-cookie-come-from.html">&lt;p&gt;The chocolate chip cookie was invented by Ruth Graves Wakefield. She owned the Toll House Inn, in Whitman, Massachusetts, a very popular restaurant that featured home cooking in the 1930s. Her cookbook, Toll House Tried and True Recipes, was first published in 1936 by M. Barrows &amp;amp; Company, New York. The 1938 edition of the cookbook was the first to include the recipe “Toll House Chocolate Crunch Cookie” which rapidly became a favorite cookie in American homes.&lt;/p&gt;
 
 &lt;p&gt;Source / Read more &lt;a href=&quot;https://en.wikipedia.org/wiki/Chocolate_chip_cookie&quot;&gt;Wikipedia&lt;/a&gt;&lt;/p&gt;

test/test-parser-atomv1.js

@@ -13,7 +13,10 @@ describe('when parse ATOM', function() {
  assert.equal(result.links[0].url, 'http://bakery-store.example.com/');
  assert.equal(result.description, 'A sample ATOM feed');
  assert.equal(result.items.length, 2);
+ assert.equal(result.image.url, 'https://b.thumbs.redditmedia.com/ntr1FkBiO3nk4t4Vgy5GXoPQ_j2hirENH9iT8rXNf8M.png');
  assert.equal(result.items[0].title, 'Where Did The Cookie Come From');
+ assert.equal(result.items[0].id, 'http://bakery-store.example.com/information/2016/01/02/where-did-the-cookie-come-from');
+ assert.equal(result.items[0].imageUrl, 'https://b.thumbs.redditmedia.com/ntr1FkBiO3nk4t4Vgy5GXoPQ_j2hirENH9iT8rXNf8.png');
  assert.equal(result.items[0].links.length, 1);
  assert.equal(result.items[0].links[0].url, 'http://bakery-store.example.com/information/2016/01/02/where-did-the-cookie-come-from.html');
  assert.equal(result.items[0].links[0].rel, 'alternate');

test/test-parser-rssv2.js

@@ -27,6 +27,7 @@ describe('when rss parse', function() {
  assert.equal(result.authors.length, 1);
  assert.equal(result.authors[0].name, 'dave@userland.com');
  assert.equal(result.items.length, 9);
+ assert.equal(result.items[0].id, 'http://scriptingnews.userland.com/backissues/2002/09/29#When:6:56:02PM');
  assert.equal(result.items[0].published, 'Mon, 30 Sep 2002 01:56:02 GMT');
  assert.equal(result.items[0].enclosures.length, 1);
  assert.equal(result.items[0].enclosures[0].url, 'http://www.scripting.com/mp3s/weatherReportSuite.mp3');