Skip to content

✨ Add e2e tests & clusterctl changes for cross-ns CC ref #11395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 4, 2025
Merged

✨ Add e2e tests & clusterctl changes for cross-ns CC ref #11395

merged 1 commit into from
Feb 4, 2025

Conversation

@Danil-Grigorev
Copy link
Member

@Danil-Grigorev Danil-Grigorev commented Nov 11, 2024 •
edited
Loading

What this PR does / why we need it:
This PR allows clusterctl to create a template with a reference to CC located in a different namespace.
This change allows to perform e2e tests in a multi-ns environment.

Added e2e tests to verify cluster-class quick-start scenario and runtime extension scenario in a cross-namespaced context.

The PR is built on top of:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5673
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Nov 11, 2024
@k8s-ci-robot k8s-ci-robot requested a review from elmiko November 11, 2024 10:19
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 11, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch 5 times, most recently from d92a5c2 to 7560e66 Compare November 12, 2024 11:33
@Danil-Grigorev Danil-Grigorev mentioned this pull request Nov 12, 2024
Merged
@Danil-Grigorev Danil-Grigorev changed the title [WIP] ✨ E2E test for the classNamespace usage [WIP] ✨ Add clusterctl changes for cross-ns CC ref Nov 12, 2024
@Danil-Grigorev Danil-Grigorev changed the title [WIP] ✨ Add clusterctl changes for cross-ns CC ref ✨ Add clusterctl changes for cross-ns CC ref Nov 12, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 12, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch from 7560e66 to 09ce978 Compare November 18, 2024 19:46
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 18, 2024
@fabriziopandini fabriziopandini mentioned this pull request Nov 21, 2024
Closed
@fabriziopandini fabriziopandini changed the title ✨ Add clusterctl changes for cross-ns CC ref [WIP] ✨ Add clusterctl changes for cross-ns CC ref Nov 25, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2024
@fabriziopandini
Copy link
Member

fabriziopandini commented Nov 25, 2024

Renamed wip since it builds on a PR not yet merged
fabriziopandini
fabriziopandini reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made first pass, I will get back to this when the PR it builds on top are merged
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch from 09ce978 to 2d4a64e Compare December 4, 2024 14:34
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 4, 2024
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch from 2d4a64e to c181e3e Compare December 4, 2024 15:22
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 4, 2024
@chrischdi
Copy link
Member

chrischdi commented Jan 30, 2025

cc @Danil-Grigorev the above comments should help to get this one green :-)
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch 2 times, most recently from 5d11aa7 to 0c1c5b9 Compare January 30, 2025 12:54
@sbueringer
Copy link
Member

sbueringer commented Jan 30, 2025

/test pull-cluster-api-e2e-main
@sbueringer
Copy link
Member

sbueringer commented Jan 30, 2025

Nice, only another test failed. I call this a win! :)

/test pull-cluster-api-e2e-main
@sbueringer
Copy link
Member

sbueringer commented Jan 31, 2025

/test pull-cluster-api-e2e-main
2 similar comments
@sbueringer
Copy link
Member

sbueringer commented Jan 31, 2025

/test pull-cluster-api-e2e-main
@sbueringer
Copy link
Member

sbueringer commented Feb 4, 2025

/test pull-cluster-api-e2e-main
@sbueringer sbueringer added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. labels Feb 4, 2025
sbueringer
sbueringer reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very last round of findings I hope.

Didn't realize the overlap with #11780 when merging #11780
chrischdi
chrischdi reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit from my side :-)
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch 2 times, most recently from 5902f12 to 460dc51 Compare February 4, 2025 12:39
sbueringer
sbueringer reviewed Feb 4, 2025
View reviewed changes
@Danil-Grigorev @chrischdi @sbueringer
Add e2e test to cover crossNamespace provisionging
b801b94 
- Prevent duplicate CC creation in template processing - Test runtimextension integration - Add changes to CC rebase e2e test - Add a note CLUSTER_CLASS_NAMESPACE to the clusterctl contract Co-authored-by: Christian Schlotter <chrischdi@users.noreply.github.com> Co-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com> Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev force-pushed the standardize-references-full branch from 460dc51 to b801b94 Compare February 4, 2025 12:51
@sbueringer
Copy link
Member

sbueringer commented Feb 4, 2025 •
edited
Loading

Thank you very much!!

/approve

Leving lgtm to @chrischdi

🙏 🤞 🍀
/test pull-cluster-api-e2e-main
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2025
@chrischdi
Copy link
Member

chrischdi commented Feb 4, 2025

/lgtm
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2025
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 4, 2025

LGTM label has been added.

Git tree hash: 43af4e7d1255168333ec1d7530ca7314071b3ef1
@k8s-ci-robot k8s-ci-robot merged commit d1e314e into kubernetes-sigs:main Feb 4, 2025
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Feb 4, 2025
@sbueringer
Copy link
Member

sbueringer commented Feb 4, 2025

Alrighty. I'll keep track of the cherry-pick for this PR. Now onwards to the final PR #11649 so we can cherry-pick all of this :)
@sbueringer
Copy link
Member

sbueringer commented Feb 13, 2025

/cherry-pick release-1.9
@k8s-infra-cherrypick-robot
Copy link

k8s-infra-cherrypick-robot commented Feb 13, 2025

@sbueringer: new pull request created: #11845

In response to this:

/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 13, 2025
Merged
@sbueringer sbueringer mentioned this pull request Feb 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

6 participants

@Danil-Grigorev @fabriziopandini @sbueringer @chrischdi @k8s-ci-robot @k8s-infra-cherrypick-robot