⚠️ Deprecate the ClusterResourceSet feature flag #11741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
k8s-ci-robot added area/clusterresourceset 
sbueringer reviewed Jan 23, 2025
| // alpha: v0.3 | ||
| // beta: v0.4 | ||
| // GA: v1.10 | ||
| // Deprecated: ClusterResourceSet feature is now GA and the corresponding feature flag will be removed in 1.12 release. |
Member
There was a problem hiding this comment.
Suggested change
| // Deprecated: ClusterResourceSet feature is now GA and the corresponding feature flag will be removed in 1.12 release. | |
| // | |
| // Deprecated: ClusterResourceSet feature is now GA and the corresponding feature flag will be removed in 1.12 release. |
I think staticcheck only picks that up with a leading empty comment line (which is also why the linter didn't complain)
fabriziopandini force-pushed the depecate-ClusterResourceSet-feature-flag branch from 5457f28 to 5f243c3 Compare 
sbueringer changed the title 
Member
| Thx! /lgtm |
k8s-ci-robot added the lgtm 
Contributor
| LGTM label has been added. Git tree hash: d1a9e0b5f34b4568b95cc88b5ddc7b4e92e54f6f |
Contributor
| [APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot added the approved 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Given that the ClusterResourceSet is now GA, the corresponding feature flag shold be deprecated, and it will be removed in 1.12.
Please note that, based on the behaviour implemented by http://k8s.io/component-base for GA flags:
Ref #11114
/area clusterresourceset