feat: add support for edge functions (#233)

* feat: add support for edge functions * chore: update lock file * chore: remove unused types * chore: remove unused file * feat: more things * chore: remove `.only` * refactor: rename prop * refactor: handle merge * fix: use `serverAddress` prop * chore: update Deno version in CI * fix: add dep * refactor: update bootstrap URL * feat: add dynamic bootstrap URL * refactor: fix lint issues * feat: add quiet flag * chore: update Node version * chore: fix packages * feat: use workers * fix: add missing site metadata * chore: fix test * Apply suggestions from code review Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com> * chore: fix formatting * fix: fix tests * chore: remove unused file * chore: add comment * refactor: conditionally start HTTP server * refactor: rename variables * Update packages/edge-functions/dev/node/main.test.ts Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com> * fix(deps): update lockfile * build: improve eslint config - move non-temporary config out of `eslint_temporary_suppressions` - configure `node-builtins` rule properly * refactor: fix lint errors * build: add new suppressions The new eslint setup was merged after most of the work on this PR was done. * chore(deps): bump @netlify/types in packages/edge-functions * ci: add missing build step to lint job * chore: update lockfile --------- Co-authored-by: Philippe Serhal <philippe.serhal@netlify.com>

Author: eduardoboucas

.github/workflows/lint.yaml

@@ -25,5 +25,8 @@ jobs:
  - name: Install dependencies
  run: npm ci --no-audit
 
+ - name: Build
+ run: npm run build --workspaces=true
+
  - name: Lint
  run: npm run lint

.github/workflows/release-please.yaml

@@ -58,6 +58,10 @@ jobs:
  if: ${{ steps.release.outputs['packages/cache--release_created'] }}
  env:
  NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
+ - run: npm publish packages/edge-functions/ --provenance --access=public
+ if: ${{ steps.release.outputs['packages/edge-functions--release_created'] }}
+ env:
+ NODE_AUTH_TOKEN: ${{secrets.NPM_TOKEN}}
  - run: npm publish packages/functions/ --provenance --access=public
  if: ${{ steps.release.outputs['packages/functions--release_created'] }}
  env:

.github/workflows/test.yaml

@@ -17,11 +17,9 @@ jobs:
  matrix:
  os: [ubuntu-latest, macOS-latest, windows-latest]
  node-version: ['*']
- deno-version: ['v1.37.0', 'v1.44.4']
  include:
  - os: ubuntu-latest
  node-version: '18.14.0'
- deno-version: 'v1.44.4'
  fail-fast: false
  steps:
  # Increasing the maximum number of open files. See:
@@ -41,7 +39,7 @@ jobs:
  - name: Setup Deno
  uses: denoland/setup-deno@v1
  with:
- deno-version: ${{ matrix.deno-version }}
+ deno-version: 2.2.4
  - name: Setup Deno dependencies
  run: deno cache https://deno.land/x/eszip@v0.55.2/eszip.ts
  - name: Install dependencies

eslint.config.js

@@ -1,4 +1,5 @@
 // @ts-check
+import { promises as fs } from 'node:fs'
 import * as path from 'node:path'
 import { fileURLToPath } from 'node:url'
 import { includeIgnoreFile } from '@eslint/compat'
@@ -13,15 +14,25 @@ import temporarySuppressions from './eslint_temporary_suppressions.js'
 const __filename = fileURLToPath(import.meta.url)
 const __dirname = path.dirname(__filename)
 
+const packagesPath = path.join(__dirname, 'packages')
+const packages = await fs.readdir(packagesPath)
+const packageIgnores = packages.map((name) => includeIgnoreFile(path.resolve(packagesPath, name, '.gitignore')))
+
 export default tseslint.config(
  // Global rules and configuration
  includeIgnoreFile(path.resolve(__dirname, '.gitignore')),
+ ...packageIgnores,
  {
  linterOptions: {
  reportUnusedDisableDirectives: true,
  },
  },
 
+ // TODO: Move this to `edge-functions` package.
+ {
+ ignores: ['packages/**/deno'],
+ },
+
  // JavaScript-specific rules
  eslint.configs.recommended,
 
@@ -73,12 +84,18 @@ export default tseslint.config(
  varsIgnorePattern: '^_',
  },
  ],
+
+ // Empty functions and blocks are useful (e.g `noop() {}`, `catch {}`) but can mask unintentionally omitted
+ // implementation. We should add explanatory comments like `// intentionally empty` and `// ignore error` in these
+ // scenarios to communicate intent.
+ 'no-empty': 'off',
+ '@typescript-eslint/no-empty-function': 'off',
  },
  },
 
  // Tests
  {
- files: ['**/*.test.?(c|m)[jt]s?(x)'],
+ files: ['**/*.test.?(c|m)[jt]s?(x)', '**/test/*'],
  plugins: { vitest },
  rules: {
  ...vitest.configs.recommended.rules,
@@ -101,6 +118,15 @@ export default tseslint.config(
  ],
  },
  ],
+ 'n/no-unsupported-features/node-builtins': 'off',
+ },
+ },
+
+ // Config files
+ {
+ files: ['**/tsup.config.ts'],
+ rules: {
+ 'n/no-unsupported-features/node-builtins': 'off',
  },
  },