Remove <BLANKLINE> from docstrings #346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #346 +/- ## ========================================== - Coverage 80.12% 79.98% -0.14% ========================================== Files 21 21 Lines 1650 1634 -16 ========================================== - Hits 1322 1307 -15 + Misses 328 327 -1 ☔ View full report in Codecov by Sentry. |
NathanielF approved these changes Jun 5, 2024
Contributor
NathanielF left a comment
NathanielF left a comment There was a problem hiding this comment.
Looks good to me. Be nice to get rid of those blanklines
drbenvincent added the no releasenotes 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
<BLANKLINE>instances in the docstrings. They were put there in Fix failing doctests #330 in order to fix failing tests. And that was happening because the progress bar was misbehaving.<BLANKLINE>instances.5.15.1which is the version to include Implement CustomProgress that does not output empty divs when disabled pymc-devs/pymc#7290<BLANKLINE>from doctests when we are able #331