Skip to content

fix attrs==25.2.0 compatibility #13291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2025
Merged

fix attrs==25.2.0 compatibility #13291

merged 1 commit into from
Mar 13, 2025

Conversation

@jakkdl
Copy link
Member

@jakkdl jakkdl commented Mar 12, 2025

fixes #13290
@jakkdl
Copy link
Member Author

jakkdl commented Mar 12, 2025

does this need a newsfragment?
@jakkdl jakkdl requested a review from The-Compiler March 12, 2025 14:13
@webknjaz
Copy link
Member

webknjaz commented Mar 12, 2025

Well, this seems user-facing. So I'd say yes.
@The-Compiler
Copy link
Member

The-Compiler commented Mar 12, 2025

Not user-facing in the sense of "people using pytest". However, we have a contrib type for news entries, and it would probably fit there (from changelog/README.rst):

  • contrib: stuff that affects the contributor experience. e.g. Running tests, building the docs, setting up the development environment.
@nicoddemus
Copy link
Member

nicoddemus commented Mar 12, 2025

I agree with @webknjaz that this is user facing, because without this fix, pytest support for attrs==25.2.0 does not work properly.

I suggest 13291.bugfix.rst:

Fixed support for ``attrs 25.2``.
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Mar 12, 2025

I also think it's user facing. Maybe 'fixed repr of attr object in assertion for attr 25.2' ?
@The-Compiler
Copy link
Member

The-Compiler commented Mar 12, 2025

Oh, right. Somehow I assumed this was only in the self-test file. My bad!
@bluetech
Copy link
Member

bluetech commented Mar 13, 2025

In order to unbreak CI I'll add a changelog based on @nicoddemus and @Pierre-Sassoulas suggestions and merge.
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided (automation) changelog entry is part of PR label Mar 13, 2025
@bluetech bluetech mentioned this pull request Mar 13, 2025
Closed
@bluetech bluetech merged commit 4933d92 into pytest-dev:main Mar 13, 2025
28 checks passed
@patchback
Copy link

patchback bot commented Mar 13, 2025 •
edited
Loading

Backport to 8.3.x: 💚 backport PR created

✅ Backport PR branch: patchback/backports/8.3.x/4933d9223ffb3e9c1f11a4a2623be5d32672e071/pr-13291

Backported as #13294

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.
patchback bot pushed a commit that referenced this pull request Mar 13, 2025
@bluetech @patchback
Merge pull request #13291 from jakkdl/fix_attrs
71c653a 
fix attrs==25.2.0 compatibility (cherry picked from commit 4933d92)
@patchback patchback bot mentioned this pull request Mar 13, 2025
Merged
@jakkdl jakkdl deleted the fix_attrs branch March 13, 2025 12:32
bluetech added a commit that referenced this pull request Mar 13, 2025
@bluetech
Merge pull request #13294 from pytest-dev/patchback/backports/8.3.x/4…
850b99c 
…933d9223ffb3e9c1f11a4a2623be5d32672e071/pr-13291 [PR #13291/4933d922 backport][8.3.x] fix attrs==25.2.0 compatibility
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:chronographer:provided (automation) changelog entry is part of PR

6 participants

@jakkdl @webknjaz @The-Compiler @nicoddemus @Pierre-Sassoulas @bluetech