Skip to content

Change grabclipboard() to use PNG compression on macOS#7219

Merged
hugovk merged 3 commits intopython-pillow:mainfrom
abey79:grabclipboard-mac-png
Jun 18, 2023
Merged

Change grabclipboard() to use PNG compression on macOS#7219
hugovk merged 3 commits intopython-pillow:mainfrom
abey79:grabclipboard-mac-png

Conversation

@abey79
Copy link
Contributor

@abey79 abey79 commented Jun 17, 2023

This PR changes grabclipboard() to use a PNG compression instead of a lossy JPG compression when reading images from he clipboard on macOS.

Fixes #7214

abey79 added 2 commits June 17, 2023 12:55
Before, a lossy JPG compression was used.
@radarhere
Copy link
Member

A note for the future - our tradition is to not include the CHANGES.rst updates in PRs. If something else were to be merged in first, it would create a conflict.

I've created abey79#1 with a suggestion.

@abey79
Copy link
Contributor Author

abey79 commented Jun 17, 2023

Thanks for the fix, quite the overlook on my part.

As for CHANGES.rst, it's noted. Maybe .github/CONTRIBUTING.md might be reworded? I tried to comply to the following based on recent commits I found:

  • Include release notes as needed or appropriate with your bug fixes, feature additions and tests.
@hugovk
Copy link
Member

hugovk commented Jun 18, 2023

Thanks!

@hugovk hugovk merged commit 934a6c6 into python-pillow:main Jun 18, 2023
@radarhere
Copy link
Member

As for CHANGES.rst, it's noted. Maybe .github/CONTRIBUTING.md might be reworded? I tried to comply to the following based on recent commits I found:

  • Include release notes as needed or appropriate with your bug fixes, feature additions and tests.

Ok, I've created PR #7220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants