Handle disposing GIF background from outside palette#7515
Merged
hugovk merged 1 commit intopython-pillow:mainfrom Dec 21, 2023
Merged
Handle disposing GIF background from outside palette#7515hugovk merged 1 commit intopython-pillow:mainfrom
hugovk merged 1 commit intopython-pillow:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #7514
When disposing a GIF frame, Pillow doesn't currently consider that a background index might be higher than the current size of the palette. If that happens, the following code
Pillow/src/PIL/GifImagePlugin.py
Line 338 in c9f7a82
creates an empty tuple, leading to a TypeError when
Pillow/src/PIL/GifImagePlugin.py
Line 369 in c9f7a82
tries to create an image filled with an empty tuple.
Instead, this PR uses the first palette entry in such a scenario. This is in line with our default if there is no background.