Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace#7553
Merged
radarhere merged 6 commits intopython-pillow:mainfrom Jan 1, 2024
Merged
Add keep_rgb option when saving JPEG to prevent conversion of RGB colorspace#7553radarhere merged 6 commits intopython-pillow:mainfrom
keep_rgb option when saving JPEG to prevent conversion of RGB colorspace#7553radarhere merged 6 commits intopython-pillow:mainfrom
Conversation
radarhere changed the title keep_colorspace option when saving JPEG to prevent conversion of RGB colorspace 
homm reviewed Nov 14, 2023
bgilbert changed the title keep_colorspace option when saving JPEG to prevent conversion of RGB colorspacekeep_rgb option when saving JPEG to prevent conversion of RGB colorspace bgilbert changed the title keep_rgb option when saving JPEG to prevent conversion of RGB colorspacekeep_rgb option when saving JPEG to prevent conversion of RGB colorspace 
Contributor Author
| Rebased (first push) and switched to |
radarhere reviewed Nov 26, 2023
radarhere reviewed Nov 26, 2023
radarhere previously approved these changes Nov 27, 2023
radarhere reviewed Nov 27, 2023
Contributor Author
| Added @radarhere's test improvements from bgilbert#3. |
homm reviewed Dec 4, 2023
homm reviewed Dec 4, 2023
homm approved these changes Dec 5, 2023
libjpeg automatically converts RGB to YCbCr by default. Add a keep_rgb option to disable libjpeg's automatic conversion of RGB images during write.
-1 is the default; 3 is invalid and should behave the same as the default.
Contributor Author
| Rebased onto current |
Contributor Author
| Is anything else needed here? |
radarhere reviewed Dec 24, 2023
radarhere reviewed Dec 24, 2023
Contributor Author
| Applied suggestions. |
radarhere reviewed Dec 26, 2023
The user presumably doesn't intend to subsample the green and blue channels.
Co-authored-by: Andrew Murray <radarhere@users.noreply.github.com>
nulano approved these changes Dec 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libjpeg automatically converts RGB to YCbCr by default. Add a
keep_rgboption to disable libjpeg's automatic conversion of RGB images during write.