Moved error from truetype() to FreeTypeFont#7587
Merged
radarhere merged 1 commit intopython-pillow:mainfrom Dec 4, 2023
Merged
Moved error from truetype() to FreeTypeFont#7587radarhere merged 1 commit intopython-pillow:mainfrom
radarhere merged 1 commit intopython-pillow:mainfrom
Conversation
homm approved these changes Dec 4, 2023
radarhere added a commit to radarhere/Pillow that referenced this pull request Dec 8, 2023
radarhere added a commit to radarhere/Pillow that referenced this pull request Dec 8, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7584
Since
ImageFont.truetype()really just constructs anImageFont.FreeTypeFontinstance, I think it makes sense to move the new ValueError fromImageFont.truetype()toImageFont.FreeTypeFont, allowingImageFont.FreeTypeFontto also have this validation.