fix(security): do not allow to read files above #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
megagreg72 reviewed Mar 25, 2024
Comment on lines +131 to +134
| // ".." is malicious | ||
| if (UP_PATH_REGEXP.test(path.normalize(`./${pathname}`))) { | ||
| // eslint-disable-next-line no-param-reassign | ||
| extra.errorCode = 403; |
| @alexander-akait is there any plan to backport this fix to v4? We have a project still on Nuxt 2 / Webpack 4. |
Member Author
| @jkeys089 Webpack 4 is deprecated, so if you want to do it, feel free to send a PR and I will make a release |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
security fix
Breaking Changes
No
Additional Info
No