You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
Required fields*
- 4Appears or is? A quick measurement of the source files will confirm or deny your suspicions. After measuring just bring up the measurement numbers at the code review and suggest a refactoring to bring down the complexity numbers.Jon Raynor– Jon Raynor2016-12-15 16:51:08 +00:00Commented Dec 15, 2016 at 16:51
- 4related: How can I tactfully suggest improvements to others' badly designed code during review?gnat– gnat2016-12-15 17:06:48 +00:00Commented Dec 15, 2016 at 17:06
- 6Possible duplicate of What do you do when code review is just too hard?bill– bill2016-12-15 18:49:09 +00:00Commented Dec 15, 2016 at 18:49
- 5Please define "too complicated". Is the code too complicated because it uses well known design patterns that are simply unfamiliar to your team, or because it fails to use patterns well known to your team? The precise reasons for judging the code "too complicated" are essential to creating a correct assessment of how to go forward. A statement as simple as "too complicated" on a knowledge area as deep and complicated as code review suggests a witch hunt of the developer to me.Pieter Geerkens– Pieter Geerkens2016-12-16 20:18:51 +00:00Commented Dec 16, 2016 at 20:18
- 7@PieterGeerkens Or, perhaps, is it too complicated because it's solving a complicated problem?Casey– Casey2016-12-16 22:07:38 +00:00Commented Dec 16, 2016 at 22:07
| Show 3 more comments
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you