Skip to main content
Software Engineering

You are not logged in. Your edit will be placed in a queue until it is peer reviewed.

We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.

20
  • 2
    "otherwise" isnt a single case though, its perfectly possible that the code being tested would not allow admins to open public files due to a bug Commented Jan 13, 2020 at 21:10
  • 2
    I'm gonna backup Ewan. You absolutely need 4 test cases here. Doesn't matter if the problem can be solved with 3 return lines. The reason why is that your behavior is entangled in two boolean variables. They can't be tested separately. Commented Jan 13, 2020 at 21:19
  • 1
    @preferred_anon: "To write tests for "only admins can open files larger than 4.5MB", it is undesirable to have to test "the 4.5MB file is public" and "the 4.5MB file is not public" separately." - if you mean conceptually, then there are two ways to think about it: (1) the behavior as you specified it is oversimplified, so your tests compensate for that, or (2) the behavior can be composed (essentially, boolean AND), so you could write two separate functions (or classes), test them separately, then compose them (and maybe also test the composition logic in a generalized way). Commented Jan 13, 2020 at 22:26
  • 1
    @preferred_anon: P.S. Just to be clear, I'm talking in general terms; for a case where you have a finite, fairly small number of possibilities, it's preferable to do it in a fashion described in this answer - where you essentially define a table of possible inputs and outputs. Commented Jan 13, 2020 at 22:29
  • 1
    @ITAlex no, they would not Commented Jan 14, 2020 at 16:50