You are not logged in. Your edit will be placed in a queue until it is peer reviewed.
We welcome edits that make the post easier to understand and more valuable for readers. Because community members review edits, please try to make the post substantially better than how you found it, for example, by fixing grammar or adding additional resources and hyperlinks.
Required fields*
- 2Did you ask the team members themselves? They may have better suggestions than anyone who does not know your team.Doc Brown– Doc Brown2022-11-25 14:13:24 +00:00Commented Nov 25, 2022 at 14:13
- 4really need some more info here. what do you cover in your CRs? what is the purpose of your CRs? Why cant you just mandate them in your CI pipeline for all merges? are they being skipped completely or just ticked off without achieving your purpose?Ewan– Ewan2022-11-25 14:32:32 +00:00Commented Nov 25, 2022 at 14:32
- 1"assign a different guy to fix the bug caused by someone else's code" bit of a red flag here tbh. how about you just put bugs in the backlog and not worry about who's fault they are?Ewan– Ewan2022-11-25 14:35:02 +00:00Commented Nov 25, 2022 at 14:35
- 2@Qiulang邱朗: I did not downvote or close vote (yet), but you could start to answer Ewan's questions to improve the question. And, you are asking us something which you really should discuss with your team, as I wrote. The fact you expect strangers from the internet to give you a better reply than your team gives me the impression this could be more more a workplace issue than the software engineering issue.Doc Brown– Doc Brown2022-11-25 19:55:27 +00:00Commented Nov 25, 2022 at 19:55
- 2@Qiulang邱朗 You mention "We all know code review is important", but the rest of the question implies the team believes exactly the opposite. If they knew code review was important they'd be doing it. The fact it's seen as a formality almost certainly means they think it's a waste of time. What's missing is why they don't think it's important, yet the only way to understand this is talking, honestly and openly; at this point it's primarily an interpersonal/communication issue, requiring trust from everyone involved.Ben Cottrell– Ben Cottrell2022-11-26 11:07:29 +00:00Commented Nov 26, 2022 at 11:07
| Show 10 more comments
How to Edit
- Correct minor typos or mistakes
- Clarify meaning without changing it
- Add related resources or links
- Always respect the author’s intent
- Don’t use edits to reply to the author
How to Format
- create code fences with backticks ` or tildes ~ ```
like so
``` - add language identifier to highlight code ```python
def function(foo):
print(foo)
``` - put returns between paragraphs
- for linebreak add 2 spaces at end
- _italic_ or **bold**
- indent code by 4 spaces
- backtick escapes
`like _so_` - quote by placing > at start of line
- to make links (use https whenever possible) <https://example.com>[example](https://example.com)<a href="https://example.com">example</a>
How to Tag
A tag is a keyword or label that categorizes your question with other, similar questions. Choose one or more (up to 5) tags that will help answerers to find and interpret your question.
- complete the sentence: my question is about...
- use tags that describe things or concepts that are essential, not incidental to your question
- favor using existing popular tags
- read the descriptions that appear below the tag
If your question is primarily about a topic for which you can't find a tag:
- combine multiple words into single-words with hyphens (e.g. design-patterns), up to a maximum of 35 characters
- creating new tags is a privilege; if you can't yet create a tag you need, then post this question without it, then ask the community to create it for you