Timeline for When code review becomes a formality what procedure can I take to amend it?
Current License: CC BY-SA 4.0
28 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Dec 2, 2022 at 4:14 | review | Close votes | |||
| Dec 7, 2022 at 3:04 | |||||
| Nov 30, 2022 at 2:54 | comment | added | Qiulang 邱朗 | @DocBrown well the simple answer is they are sometime sloppy, they are inexperience; they feel they have more important things to do(that is the case some times). And that is why I said in my question I don't want to get into the root cause here because that will sidetrack my question. Here I just want to know what method(s) people ever tried to deal with that. | |
| Nov 29, 2022 at 15:23 | comment | added | Doc Brown | @Qiulang邱朗: oh, I did not say you cannot get any answers here. I am saying you should first talk with your team, you will probably get much better answers from them (and you question here should include what your team mates told you). | |
| Nov 29, 2022 at 9:03 | history | edited | Qiulang 邱朗 | edited tags | |
| Nov 28, 2022 at 16:42 | answer | added | Jon Raynor | timeline score: 2 | |
| Nov 28, 2022 at 14:09 | answer | added | Cap Barracudas | timeline score: 1 | |
| Nov 28, 2022 at 13:29 | answer | added | Computable | timeline score: 1 | |
| Nov 28, 2022 at 12:24 | comment | added | Qiulang 邱朗 | @DocBrown please see my updated question and softwareengineering.stackexchange.com/questions/39855/…, apparently there are some good answers there (from some total strangers) | |
| Nov 28, 2022 at 12:19 | history | edited | Qiulang 邱朗 | CC BY-SA 4.0 | added 345 characters in body |
| Nov 28, 2022 at 10:49 | comment | added | Qiulang 邱朗 | @BenCottrell I didn't assume anything, I just gave you a counter argument. I have searched the site for the similar question, apparently it is not just me who has this problem. I will update my question later. | |
| Nov 28, 2022 at 8:08 | comment | added | Ben Cottrell | @Qiulang邱朗 That sounds like you're assuming that the developers themselves are to blame rather than it being a problem elsewhere. The point of my comment is to not make such an assumption, but instead talk and assert the real reason, as it's likely the root cause may be the review technique itself. Peer review should be a chance to share knowledge and keep the team on the same page, so if that's not happening, and it isn't helping them collaborate then you need to talk to them and learn why -- it may be that their approach/technique around peer review itself is misguided. | |
| Nov 27, 2022 at 3:41 | history | edited | Qiulang 邱朗 | CC BY-SA 4.0 | added 495 characters in body |
| Nov 27, 2022 at 1:40 | comment | added | Qiulang 邱朗 | @BenCottrell How many time you know something is important but you didn't do it? For starters, I know a healthy diet is important but I still indulge myself in junk food. | |
| Nov 26, 2022 at 11:07 | comment | added | Ben Cottrell | @Qiulang邱朗 You mention "We all know code review is important", but the rest of the question implies the team believes exactly the opposite. If they knew code review was important they'd be doing it. The fact it's seen as a formality almost certainly means they think it's a waste of time. What's missing is why they don't think it's important, yet the only way to understand this is talking, honestly and openly; at this point it's primarily an interpersonal/communication issue, requiring trust from everyone involved. | |
| Nov 26, 2022 at 4:21 | history | edited | Qiulang 邱朗 | CC BY-SA 4.0 | added 3 characters in body |
| Nov 26, 2022 at 4:08 | history | edited | Qiulang 邱朗 | CC BY-SA 4.0 | added 429 characters in body |
| Nov 26, 2022 at 3:25 | comment | added | Qiulang 邱朗 | @DocBrown I did not expect strangers from the internet to give you a better reply but on the other hand I would be surprised if people tell me that no that never happen in my team, I don't have this problem. | |
| Nov 26, 2022 at 3:18 | comment | added | Qiulang 邱朗 | @DocBrown I didn't answer that because when I see the words "what is the purpose of your CRs" I don't know what to say. And why is my way is "bit of a red flag here" ... So I don't answer. | |
| Nov 25, 2022 at 19:55 | comment | added | Doc Brown | @Qiulang邱朗: I did not downvote or close vote (yet), but you could start to answer Ewan's questions to improve the question. And, you are asking us something which you really should discuss with your team, as I wrote. The fact you expect strangers from the internet to give you a better reply than your team gives me the impression this could be more more a workplace issue than the software engineering issue. | |
| Nov 25, 2022 at 19:49 | answer | added | candied_orange | timeline score: 5 | |
| Nov 25, 2022 at 16:57 | comment | added | Stack Exchange Broke The Law | @Qiulang邱朗 software developers don't like when you say software developers are doing something stupid :) | |
| Nov 25, 2022 at 15:57 | comment | added | Qiulang 邱朗 | Why these down-vote and closed vote? Is there anything I missed here ? | |
| Nov 25, 2022 at 14:58 | review | Close votes | |||
| Nov 30, 2022 at 3:04 | |||||
| Nov 25, 2022 at 14:35 | comment | added | Ewan | "assign a different guy to fix the bug caused by someone else's code" bit of a red flag here tbh. how about you just put bugs in the backlog and not worry about who's fault they are? | |
| Nov 25, 2022 at 14:32 | comment | added | Ewan | really need some more info here. what do you cover in your CRs? what is the purpose of your CRs? Why cant you just mandate them in your CI pipeline for all merges? are they being skipped completely or just ticked off without achieving your purpose? | |
| Nov 25, 2022 at 14:14 | answer | added | Bart van Ingen Schenau | timeline score: 9 | |
| Nov 25, 2022 at 14:13 | comment | added | Doc Brown | Did you ask the team members themselves? They may have better suggestions than anyone who does not know your team. | |
| Nov 25, 2022 at 13:58 | history | asked | Qiulang 邱朗 | CC BY-SA 4.0 |