Timeline for "// ..." comments at end of code block after } - good or bad?
Current License: CC BY-SA 2.5
9 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| May 2, 2011 at 10:55 | vote | accept | gablin | ||
| Mar 1, 2011 at 17:10 | comment | added | BillThor | I would consider it valid if it closes something off screen. It would be better to refactor the code that it is on screen. | |
| Mar 1, 2011 at 13:03 | comment | added | Sergio | @Tom: I laughed, but feel guilty. :P | |
| Mar 1, 2011 at 13:03 | comment | added | Htbaa | You are welcome. Using them makes PHP templates so much more readable. | |
| Mar 1, 2011 at 13:00 | comment | added | Matt Ellen | @Htbaa: I can't believe I've been using PHP all this time and didn't know about those. Thanks! Regarding indenting, I prefer to keep the conditional HTML indented the same as the rest of the page, rather than in line with the PHP that's creating it. | |
| Mar 1, 2011 at 13:00 | comment | added | Tom Hawtin - tackline | I don't really see why you shouldn't be refactoring the PHP. Probably into another language. | |
| Mar 1, 2011 at 12:57 | comment | added | Htbaa | Even with PHP as a templating language mixed with HTML you can still indent. You also shouldn't use braces when using PHP as a templating language, but rather the while(): endwhile; and foreach(): endforeach; constructs etc. | |
| Mar 1, 2011 at 12:31 | comment | added | Sergio | Completely valid point for PHP, if you're using PHP mixed with Html. 1 point for Gryffindor. | |
| Mar 1, 2011 at 11:38 | history | answered | Matt Ellen | CC BY-SA 2.5 |