Revisions to remove_if equivalent for std::map

you can't bold code with stars

edited Jan 16, 2013 at 18:41

19k
8
60
87

The original code has only one issue:

for(; iter != endIter; *++iter*++iter) { if(Some Condition) { // is it safe ? aMap.erase(*iter++*iter++); } }

Here the iteriter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

The original code has only one issue:

for(; iter != endIter; *++iter*) { if(Some Condition) { // is it safe ? aMap.erase(*iter++*); } }

Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

The original code has only one issue:

for(; iter != endIter; ++iter) { if(Some Condition) { // is it safe ? aMap.erase(iter++); } }

Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

Fixed code presentation

Source Link

edit approved Jan 16, 2013 at 18:41

Laurent Parenteau

2.6k
21
32

The original code has only one issue:

for(; iter != endIter; *++iter*) {   if(Some Condition)   {   // is it safe ?   aMap.erase(*iter++*);   } }

Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

The original code has only one issue:

for(; iter != endIter; *++iter*) {   if(Some Condition)   {   // is it safe ?   aMap.erase(*iter++*);   } }

Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

The original code has only one issue:

for(; iter != endIter; *++iter*) { if(Some Condition) { // is it safe ? aMap.erase(*iter++*); } }

Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

Code Block added

Source Link

edited Jan 16, 2013 at 18:39

Pablo Claus

5.9k
3
31
40

The original code has only one issue:

for(; iter != endIter; *++iter*) { if(Some Condition) { // is it safe ? aMap.erase(*iter++*); } }

for(; iter != endIter; ++iter) { if(Some Condition) { // is it safe ? aMap.erase(iter++); } } HereHere the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

The original code has only one issue:

for(; iter != endIter; ++iter) { if(Some Condition) { // is it safe ? aMap.erase(iter++); } } Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

The original code has only one issue:

for(; iter != endIter; *++iter*) { if(Some Condition) { // is it safe ? aMap.erase(*iter++*); } }

Here the iter is incremented once in the for loop and another time in erase, which will probably end up in some infinite loop.

Source Link

answered Jan 16, 2013 at 18:14

partha biswas

242
1
8

Loading

Collectives™ on Stack Overflow

Return to Answer