onClick event is not triggering | Android

I'm probably too late to the party, but here is a code snipped which fixes the issue with onClick() not being called:

ed1.setOnTouchListener(new OnTouchListener() { @Override public boolean onTouch(View v, MotionEvent event) { if (event.getAction() == MotionEvent.ACTION_UP && !v.hasFocus()) { // onClick() is not called when the EditText doesn't have focus, // onFocusChange() is called instead, which might have a different // meaning. This condition calls onClick() when click was performed // but wasn't reported. Condition can be extended for v.isClickable() // or v.isEnabled() if needed. Returning false means that everything // else behaves as before. v.performClick(); } return false; } }); 

make edit text clickable.. In XML android:clickable="true" or in code

ed1.setClickable(true); 

then do

ed1.setOnClickListener(new OnClickListener() { @Override public void onClick(View v) { Toast.makeText(getBaseContext(), "1",Toast.LENGTH_SHORT).show(); } }); 

This happens because the first tap gains the focus into the view. The next tap triggers the click.

If you are inflating the view dynamically, do this:

android:clickable="true" android:focusable="false" android:focusableInTouchMode="false" 

If this doesn't work, try applying it on the parent view as well.

Its the most simplest way to work with date picker.

private DatePickerDialog datePickerDialog; EditText etJoiningDate; etJoiningDate=(EditText)findViewById(R.id.etJoiningDate); etJoiningDate.setOnTouchListener(new View.OnTouchListener() { @Override public boolean onTouch(View v, MotionEvent event) { switch (event.getAction()){ case MotionEvent.ACTION_DOWN: final Calendar cldr = Calendar.getInstance(); int day = cldr.get(Calendar.DAY_OF_MONTH); int month = cldr.get(Calendar.MONTH); int year = cldr.get(Calendar.YEAR); // date picker dialog datePickerDialog = new DatePickerDialog(TestActivity.this, new DatePickerDialog.OnDateSetListener() { @Override public void onDateSet(DatePicker view, int year, int monthOfYear, int dayOfMonth) { etJoiningDate.setText(dayOfMonth + "/" + (monthOfYear + 1) + "/" + year); } }, year, month, day); datePickerDialog.show(); break; } return false; } }); 

public class TestProject extends Activity implements OnClickListener { TextView txtmsg; EditText ed1, ed2; @Override public void onCreate(Bundle savedInstanceState) { super.onCreate(savedInstanceState); setContentView(R.layout.main); txtmsg = (TextView) findViewById(R.id.txtmsg); ed1 = (EditText) findViewById(R.id.edt1); ed2 = (EditText) findViewById(R.id.edt2); ed1.setOnClickListener(this); ed2.setOnClickListener(this); } @Override public void onClick(View v) { if(v==ed1){ txtmsg.setText("1"); Toast.makeText(this, "first",Toast.LENGTH_SHORT).show(); } if(v==ed2){ txtmsg.setText("2"); Toast.makeText(this, "second",Toast.LENGTH_SHORT).show(); } } 

}

<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools" android:layout_width="match_parent" android:layout_height="match_parent" > <EditText android:id="@+id/edt1" android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentLeft="true" android:layout_alignParentTop="true" android:ems="10" /> <EditText android:id="@+id/edt2" android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignParentLeft="true" android:layout_below="@+id/edt1" android:layout_marginTop="14dp" android:ems="10" /> <TextView android:id="@+id/txtmsg" android:layout_width="wrap_content" android:layout_height="wrap_content" android:layout_alignRight="@+id/edt2" android:layout_below="@+id/edt2" android:layout_marginRight="22dp" android:layout_marginTop="160dp" android:textAppearance="?android:attr/textAppearanceLarge" /> </RelativeLayout> 

Took me a minute to figure this out one time when this happened to me. My ImageButton with a setOnClickListener and onClick didn't seem to fire and then I realized it was actually underneath another element in my xml layout, so I turned this:

 <RelativeLayout> <ImageButton> <LinearLayout></LinearLayout> </RelativeLayout> 

into this:

 <RelativeLayout> <LinearLayout></LinearLayout> <ImageButton> </RelativeLayout> 

and suddenly the ImageButton was not being overlapped by the other layout since it was now added later to the parent layout and was now on top and works every time. Good luck, always fun when basic stuff suddenly seems to stop working

Avoid using a FocusChangeListener since it will behave erratically when you don't really need it (eg. when you enter an activity). Just set an OnTouchListener along with your OnClickListener like this:

@Override public boolean onTouch(View view, MotionEvent event) { switch (event.getAction()) { case MotionEvent.ACTION_DOWN: view.requestFocus(); break; } return false; } 

This will cause your EditText to receive focus at first, and your onClick to function properly the first time.

Simple, Reuseable Kotlin Solution

I started with two custom extension functions:

val MotionEvent.up get() = action == MotionEvent.ACTION_UP fun MotionEvent.isIn(view: View): Boolean { val rect = Rect(view.left, view.top, view.right, view.bottom) return rect.contains((view.left + x).toInt(), (view.top + y).toInt()) } 

Then listen to touches on the Edittext. This will only fire if initial ACTION_DOWN event was originally on the Edittext, and still is.

myEdittext.setOnTouchListener { view, motionEvent -> if (motionEvent.up && motionEvent.isIn(view)) { // Talk your action here } false }