Collection was modified; enumeration operation may not execute foreach loop

Question

I'm aware that this question is asked on here a lot, but I'm unable to gather a correct answer based on my specific loop.

I'm using a foreach loop to cycle through a Business Entity like so:

foreach (Content item in category) { item.Stats = 55; item.Commit(); }

The foreach loop runs correctly for the first item it retrieves and places the value but breaks shy of the other few and I get the error in my page title. I'm aware that I'm getting the error because the item cannot be modified during iteration. But I'm at a lost as to how else to commit to the database while in this loop.

Thanks in advance.

It sounds like your Commit function is modifying the item in some way. Can you post the code to that function? — Icemanind
– Icemanind, Commented Apr 11, 2013 at 21:09
Is your Commit function modifying Category? Is Category an observable collection? — David C
– David C, Commented Apr 11, 2013 at 21:16
The collection cannot be modified. The items themselves can. — Esailija
– Esailija, Commented Apr 11, 2013 at 21:16
The Commit function is just simply saving the Stats figure to the db. The function is trying to modify the 'Content item' values. Not necessarily the collection. — sacbeme
– sacbeme, Commented Apr 11, 2013 at 21:20

Facio Ratio · Accepted Answer · 2013-04-11 21:10:54Z

1

You could create an identical collection with clones of your items, and instead of modifying that items in your iterated collection, modify and commit the corresponding items in the cloned collection. Then discard your iterated collection when finished, treating your cloned collection as the new "originals".

answered Apr 11, 2013 at 21:10

Facio Ratio

3,3931 gold badge18 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

sacbeme Over a year ago

Can you give me a code example? The category object is a BusinessEntityList and gets defined like so: BusinessEntityList<Content> category = SiteCategories.Filter(new ContentFilter(true));

sacbeme Over a year ago

Right. That worked out I created a clone List<> with the items and ran a loop to save with that list.

mbudnik · Accepted Answer · 2013-04-11 22:25:25Z

Simplest solution to this would be adding ToList() which results in enumerating over copy of the original enumeration.

foreach (Content item in category.ToList()) { item.Stats = 55; item.Commit(); }

Collectives™ on Stack Overflow

Collection was modified; enumeration operation may not execute foreach loop

2 Answers 2

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Related