C++ bool coding help needed

Question

I am trying to write a code (object oriented programming) based on the requirements below however my bool kept returning a true whereas it should be false. Hope you guys can advise me on what went wrong with my code.

REQUIREMENTS

Member(string = "xxx", bool = false, string = "addr") Constructor with default values setMember(string, bool, string): void Set the values of data members to the respective pass-in values setPremium(bool): void Set the value of data member, premium to the pass-in value getPremium():bool Returns the value of data member, premium setMember(string, bool, string): void Set the values of data members to the respective pass-in values displayMember():void Uses cout to display the data members

MY CODE

#include <iostream> #include <string> using namespace std; class Member { private: string name; bool premium; string address; public: Member(string = "xxx", bool = false, string = "addr"); void setMember(string, bool, string); void setPremium(bool); bool getPremium(); int index; void DisplayMember(); }; Member::Member(string name, bool premium, string address) { this-> name = name; this-> premium = premium; this-> address = address; } void Member::setMember(string name, bool premium, string address) { this-> name = name; this-> premium = premium; this-> address = address; } void Member::setPremium(bool) { int i; bool premium; i = 0; while (i != 4) { i = i + 1; } if (premium >= 4) { index = i; premium = true; } else premium = false; } bool Member::getPremium() { return premium; } void Member::DisplayMember() { cout<<"Name : "<<name<<endl; cout<<"Premium : "<<boolalpha<<premium<<endl; cout<<"Address : "<<address<<endl; } int main() { Member detail1("Martin ", "2 Tampines Avenue"); detail1.DisplayMember(); cin.ignore(); cin.ignore(); }

What's all that stuff you're doing in setPremium(), which doesn't even look at the passed parameter? That function should probably be just a one-liner! — Ulrich Eckhardt
– Ulrich Eckhardt, Commented Apr 13, 2013 at 8:17

ThiefMaster · Accepted Answer · 2013-04-13 08:18:37Z

Your local bool premium is shadowing the member variable. To write to the latter you need to use this->premium or rename the local variable. Besides that, the setPremium code makes pretty much no sense - for example you are using integer operations on a boolean.

This is how setPremium should be implemented:

void Member::setPremium(bool premium) { this->premium = premium; }

Additionally you are using undefined variables such as boolalpha. Your code shouldn't even compile...

He shouldn't shadow the member variable at all, and if he forgot he did so the hopefully enabled compiler warnings should have told him of that problem...

Ming · Accepted Answer · 2013-04-13 08:23:29Z

To fix your problem, simply change the order of constructor's arguments.

public: Member(string = "xxx", string = "addr", bool = false);

And:

Member::Member(string name, string address, bool premium) { this-> name = name; this-> premium = premium; this-> address = address; }

Collectives™ on Stack Overflow

C++ bool coding help needed

2 Answers 2

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Related