Return statement in PHP functions [duplicate]

Question

I'm having some problems with a Return statement in PHP. The thing is that, no matter what happend inside my function I always get a false value out of the function. I really think that is because of the Return statement because I try to use it in other functions and I don't get a diferent value.

public function valid_token () { if (!isset($_SESSION['token']) || $this->token != $_SESSION['token']) { $this->errors[] = "Formulario incorrecto"; } return count($this->errors)? 0 : 1; }

Out of this function I always get a false value (0). The same happends when i call:

public function valid_data () { if (empty($this->sectorName) || empty($this->sectorInfo) || empty($this->sectorCat)) { $this->errors [] = "Datos incorrectos"; } return count($this->errors)? 0 : 1; }

Of course, I call both functions when I have already sent the form and have set the token.

Yogesh Suthar · Accepted Answer · 2013-05-12 03:59:39Z

1

Because you are just counting not checking,Try this

return count($this->errors) > 0 ? 0 : 1;

answered May 12, 2013 at 3:59

Yogesh Suthar

30.5k18 gold badges75 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

mpyw Over a year ago

I even think count is lengthy.

Juan Pablo Rinaldi Over a year ago

You're wrong. count() returns a number. 0 evaluates to false, and any number different from 0 evaluates to true. And since count() doesn't return negative numbers, your check is unnecessary.

mpyw Over a year ago

See this: ideone.com/BXnYiB I'm sure there are another reasons.

mpyw · Accepted Answer · 2013-05-12 04:07:24Z

0

More simply,

return !$this->errors;

answered May 12, 2013 at 4:07

mpyw

5,7744 gold badges35 silver badges36 bronze badges

Collectives™ on Stack Overflow

Return statement in PHP functions [duplicate]

2 Answers 2

3 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Linked

Related