Spring AOP Pointcut does not trigger

Question

I am new to Spring and AOP. I am trying this simple thing where I have created a custom annotation which when placed before any method should execute some code. This is the annotation I created

 // Declares a custom annotation that validates json @Retention(RetentionPolicy.RUNTIME) @Target(ElementType.METHOD) public @interface JsonSchemaAnnotation { }

Next I created the Spring Aspect class which holds the logic

@Aspect public class UpdateUIMetadataInterceptor { @Pointcut("execution(public * com.fico.cardinal.cm.*.*(..))") public void anyPublicMethod() { System.out.println("Running"); } @Before("anyPublicMethod() && @annotation(jsonSchemaAnnotation)") public void validateJson(ProceedingJoinPoint pjp) throws Throwable { System.out.println("Running"); } }

And this is my simple test class

public class ValidationTest { public static void main(String[] args) { ApplicationContext context = new ClassPathXmlApplicationContext("spring/configuration.xml"); String jsondata = "{\"id\": \"EXPENSE_REPORT\",\"properties\": {\"transactionType\": \"EXPENSE_REPORT\"},\"sections\": []} ]}"; ValidationTest test = new ValidationTest(); test.jsonValidationTest("dummy", jsondata); ((AbstractApplicationContext) context).close(); } @JsonSchemaAnnotation public void jsonValidationTest(String dummy, String jsondata) { System.out.println("Success"); }

The problem is my spring aop never gets triggered. I have included a bean in my configuration.xml

<aop:aspectj-autoproxy> <aop:include name="UpdateUIMetadataInterceptor" /> </aop:aspectj-autoproxy> <bean id="updateUI" class="com.fico.cardinal.cm.interceptor.UpdateUIMetadataInterceptor" />

Can anyone point out what I am missing?

You create your ValidationTest object using new, so it's not managed by Spring. You have to have it as a bean in your application context and then obtain reference to it through your context variable — Dmitry Kuskov
– Dmitry Kuskov, Commented Aug 13, 2015 at 11:04
Created it via bean just now. Still no improvement. I think I am missing something more. — rrrocky
– rrrocky, Commented Aug 13, 2015 at 11:07

Community · Accepted Answer · 2017-05-23 10:28:39Z

2

You have several problems with your code:

You should create your ValidationTest object as a bean managed by Spring and not using new
<aop:include name="UpdateUIMetadataInterceptor" /> should be <aop:include name="updateUI"/>; you can actually just stick with <aop:aspectj-autoproxy/> for simplicity here
ProceedingJoinPoint is not supported for before aspects, so remove it; you can use JoinPoint instead if you need access to arguments
JsonSchemaAnnotation jsonSchemaAnnotation parameter should be present for validateJson method of your aspect, as pointed out by frant.hartm

edited May 23, 2017 at 10:28

CommunityBot

11 silver badge

answered Aug 13, 2015 at 11:30

Dmitry Kuskov

1,0216 silver badges10 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

František Hartman Over a year ago

Yep this should do it, I have missed the wrong include name :-)

rrrocky Over a year ago

I need to use the parameters of the annotated methods. That's why I have used ProceedingJoinPoint. How am I supposed to get access to the parameters without using that?

rrrocky Over a year ago

I have edited my code according to your suggestions. (Check question) But still my aspect class is not triggered.

Dmitry Kuskov Over a year ago

You can use JoinPoint instead of ProceedingJoinPoint. Can you please update all of the code in your question? I tried to run an app configured just like yours and advice is triggered. Also include contents of your pom.xml

rrrocky Over a year ago

Check out my edited code. I have also included the pom.xml

|

František Hartman · Accepted Answer · 2015-08-13 11:11:12Z

I think you need either fully qualified name or a parameter in the method:

FQN:

@Before("anyPublicMethod() && @annotation(your.package.JsonSchemaAnnotation)") public void validateJson(ProceedingJoinPoint pjp) throws Throwable { System.out.println("Running"); }

Parameter:

@Before("anyPublicMethod() && @annotation(jsonSchemaAnnotation)") public void validateJson(ProceedingJoinPoint pjp, JsonSchemaAnnotation jsonSchemaAnnotation ) throws Throwable { System.out.println("Running"); }

Source: http://docs.spring.io/spring/docs/current/spring-framework-reference/html/aop.html#aop-pointcuts

(and you also need to use the bean, as Dmitry Kuskov pointed out

I tried both fully qualified name @Before("anyPublicMethod() && @annotation(com.fico.cardinal.cm.interceptor.JsonSchemaAnnotation)") and parameter public void before(ProceedingJoinPoint pjp, JsonSchemaAnnotation jsonSchemaAnnotation) throws Throwable But it does not work in either case

Collectives™ on Stack Overflow

Spring AOP Pointcut does not trigger

2 Answers 2

10 Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

1 Comment

Linked

Related