Weird redirect bug (POST redirect to same page does not update)

Question

I currently have a POST request which will in any case set location in the response header to go to the exact same page again.

1) I click sign in. As you can see, the location is set to / which is the same page in this case. Request is handled by the server then a redirect via the location field is set in the response header.

2) Down below is the get request for the same address as the sign in page (not to be confused with /auth/local which only receives a post with login credentials). / is a different page when logged in due to routing in node.

3) As you can see below, the preview shows the html of the response to the get request which was initiated by the response of the post request. It's not the same as what the actual browser is showing which is the initial login page. It doesn't seem to update the browser?

Timeline:

I'm running Angular also:

main.js

angular.module('myApp', []) .controller('publicHomeCtrl', ['$scope', '$http', function ($scope, $http) { $scope.submit = function (event) { var data = { email: $scope.email, password: $scope.password }; $http.post('/auth/local', data).success(function () { console.log('success'); }); event.preventDefault(); }; $scope.submit2 = function () { var data = { email: $scope.email, password: $scope.password }; $http.post('/auth/local', data).success(function () { console.log('success'); }); }; }]);

signin html

<div class="container" data-ng-controller="publicHomeCtrl"> <form method="post" role="form" ng-submit="submit($event)"> <input type="email" data-ng-model="email" placeholder="[email protected]" class="form-control"> <input type="password" data-ng-model="password" placeholder="password" class="form-control"> <button type="submit" class="btn btn-success">sign in 1</button> </form> <button ng-click="submit2()">sign in 2</button> </div>

I'm suspecting because my http.post on the client side has a callback it cancels out the redirect in the response header from actually updating the view?

Is this a form post in the browser page? If so, are you doing the submission via Javascript? If so, are you preventing the default form submission? If you aren't preventing the default, then your ajax submits the form, then the browser submits the form and the ajax response is lost. I don't know if this applies to you exactly (it depends upon client-side code that we can't see), but this is a very common mistake (not preventing the default form submission which just causes a page reload). — jfriend00
– jfriend00, Commented Sep 23, 2015 at 0:07
It does indeed look like you are probably getting a default form submission which is reloading the page before your Ajax response gets processed. See my answer below for a couple solutions. — jfriend00
– jfriend00, Commented Sep 23, 2015 at 0:14
@jfriend00 Updated the code with one way to get rid of preventDefault, doesn't seem to work :/ — basickarl
– basickarl, Commented Sep 23, 2015 at 0:23
The way the code is now, it would need to be event$.preventDefault();, not event.preventDefault() if the event$ argument is the right event. Are you entirely sure you're passing the event object the proper way for angular? I see something different here: stackoverflow.com/questions/21101492/… — jfriend00
– jfriend00, Commented Sep 23, 2015 at 0:34

jfriend00 · Accepted Answer · 2015-09-23 14:49:57Z

Can't believe we missed this.

When a 302 is returned from an ajax call, the browser does NOT change the current page to a new location. Instead, it fetches the contents of the new location and returns that to the Ajax call which is not what you want.

If you want the browser page to redirect after an ajax call, then you have to code that yourself in the ajax response handler in the client. I'd suggest not using a 302. Just return a normal 200 and return some JSON that tells the client what to do next. If the client gets instructions to do a redirect, then it can set window.location itself to the new URL returned in the JSON.

@KarlMorrison - I completely changed my answer. See what you think of this new one.
I figured this out just a few minutes ago haha! Talk about timing!

Collectives™ on Stack Overflow

Weird redirect bug (POST redirect to same page does not update)

1 Answer 1

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Linked

Related