RecyclerView adapter notifyDataSetChanges() not refreshing recyclerview

Question

I have set up a RecyclerView like this

@Override public void setTenData(List<Data> dataList) { Timber.d("set ten drugs size %s",dataList.size()); this.dataList = dataList; dataListAdapter = new DataListingAdapter(getActivity(), this.dataList); mRecyclerView.setAdapter(dataListAdapter); }

And in another method I get new data and when I try to refresh the RecyclerView like this

@Override public void setNewsData(List<Data> dataList) { this.dataList = dataList; Timber.d("size of news data %s",this.dataList.size()); dataListAdapter.notifyDataSetChanged(); }

The RecyclerView doesn't get updated. What might be the problem?

it works that way, but shouldn't it be also working correctly the way I've done. — theanilpaudel
– theanilpaudel, Commented Dec 29, 2016 at 15:04
@theanilpaudel no, your way changes the reference in your view from the old list to the new list. Your adapter's reference still points to the old list. — Elias N
– Elias N, Commented Dec 29, 2016 at 15:19

Elias N · Accepted Answer · 2016-12-29 14:29:04Z

2

You need to set your new data in your adapter, not just in your view

answered Dec 29, 2016 at 14:29

Elias N

1,45011 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Neonamu Over a year ago

You answer is totally correct, and with you permission I will add to be sure that notifiDataSetChanged was done on MainThread :)

theanilpaudel Over a year ago

this.dataList is set in the adapter.

Elias N Over a year ago

Add a function in your adapter: public void setDataList(List<Data> dataList) and in it set the new data to the adapter's list. And as @Neonamu said, make sure that notifyDataSetChanged is called from the main thread.

santosh kumar · Accepted Answer · 2016-12-29 14:30:22Z

@Override public void setTenData(List<Data> dataList) { Timber.d("set ten drugs size %s",dataList.size()); this.dataList = dataList; dataListAdapter = new DataListingAdapter(getActivity(), this.dataList); mRecyclerView.setAdapter(dataListAdapter); dataListAdapter.notifyDataSetChanged(); }

savepopulation · Accepted Answer · 2016-12-29 14:35:33Z

You can simply clear your list and add new data to it and than notify adapter. Here i modified your code:

@Override public void setNewsData(List<Data> dataList) { this.dataList.clear(); this.dataList.addAll(dataList); dataListAdapter.notifyDataSetChanged(); }

Data class there extends RealmObject so we can't clear and then addAll in this list.

klcmin · Accepted Answer · 2016-12-29 15:59:52Z

 public void setNewsData(List<Data> dataList) { this.dataList.addAll(dataList); // if datalist has only new data //this.dataList = dataList;// if datalist has all data Timber.d("size of news data %s",this.dataList.size()); }

And then call the main thread;

dataListAdapter = (RecyclerViewAdapter) recyclerView.getAdapter(); dataListAdapter.setNewsData(dataList); dataListAdapter.notifyDataSetChanged();

Collectives™ on Stack Overflow

RecyclerView adapter notifyDataSetChanges() not refreshing recyclerview

4 Answers 4

3 Comments

Comments

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

3 Comments

Comments

1 Comment

Comments

Related