6

In WiX DirectorySearch can be used to determine if a specific directory exists on the target computer. But I don't understand if there's a consistent way to determine that a directory does not exist.

For example:

<Property Id="INSTALLDIR" Secure="yes"> <RegistrySearch Id='InstallDir' Type='directory' Root='HKLM' Key='Software\Company\Product\Install' Name='InstallPath'/> </Property> <Property Id='IS_INSTALLED' Secure='yes'> <DirectorySearch Id='IsInstalled' Path='[INSTALLDIR]' /> </Property>

When both the registry key and the directory exist, the IS_INSTALLED property is set to the path returned by DirectorySearch.

When the directory does not exist, IS_INSTALLED appears to be set to "C:\".

Is a condition like:

<Condition>NOT (IS_INSTALLED = "C:\")</Condition>

a reliable way to detect that the directory was found? Is there a better way?

Answer: Here is WiX code based on mrnxs answer that I accepted

<Property Id="PRODUCT_IS_INSTALLED" Secure="yes"> <RegistrySearch Id='RegistrySearch1' Type='directory' Root='HKLM' Key='Software\Company\Product\Version\Install' Name='Path'> <DirectorySearch Id='DirectorySearch1' Path='[PRODUCT_IS_INSTALLED]'/> </RegistrySearch> </Property> <CustomAction Id='SET_INSTALLDIR' Property='INSTALLDIR' Value='[PRODUCT_IS_INSTALLED]'/> <InstallExecuteSequence> <Custom Action='SET_INSTALLDIR' After='AppSearch'></Custom> </InstallExecuteSequence>
Improve this question

3 Answers 3

Reset to default
4

Usually this happens when the property is used as a property-based folder. In this case the CostFinalize action automatically sets the property to a valid path (for example "C:\") so the folder can be used by Windows Installer.

Since this path is generated automatically, you cannot be sure that it will be "C:\" on all your client machines, so you shouldn't use this value in your condition. Instead, you can try this:

  • use a custom property for your folder
  • use a type 51 custom action (property set with formatted text) to set this property to a valid default path (for example "[ProgramFilesFolder]MyCompany\MyProduct")
  • use another property for the search
  • use another type 51 custom action to set the folder property to your search property

For example, if your search is IS_INSTALLED your folder can use IS_INSTALLED_PATH. IS_INSTALLED_PATH can be set to a default path and after AppSearch action you can set it to IS_INSTALLED if the search found something.

This way you can use for conditioning:

IS_INSTALLED

or

NOT IS_INSTALLED
Improve this answer
Sign up to request clarification or add additional context in comments.

2 Comments

Hi Cosmin, Thanks for the details. The problem I'm having is that one of your steps essentially leaves me with my initial question. You say "... you can set it to IS_INSTALLED if the search found something". AppSearch seems to always find "something" even if it's the root of the OS drive.
The search property is set to the root drive only if that property is associated with a folder in your MSI. If you remove that association (for example by using another property for the folder), the search property should be empty when it doesn't find anything. Basically, your search property should be used only by the search to make sure that it's set the way you want.
0

Understaing AppSearch's RegLocator and DrLocator patterns can be a little tricky. I reccomend ignoring the condition for a moment and logging the install to verify that AppSearch is properly setting the properties you want. Fix the problems you find on that end first. When it works the property will be set to the value of the registry or the path to the directory.

Then you should be able to use:

<Condition>IS_INSTALLED/> <!-- it's not important what the value is, just that it exists --> <Condition>Not IS_INSTALLED/>

Btw, I would avoid using the property INSTALLDIR. In my installers ( InstallShield ) that has special meaning as the main focal point of the installation.

Improve this answer

Comments

0

Another approach could be this, in this you can continue the Install Sequence if you want to set the InstallDir to anywhere else, if the SystemDir and RegisteryDir is not same

<Property Id="RegisteryDir" Secure="yes"> <RegistrySearch Id='InstallDir' Type='directory' Root='HKLM' Key='Software\Company\Product\Install' Name='InstallPath'/> </Property> <Property Id='SystemDir' Secure='yes'> <DirectorySearch Id='IsInstalled' Path='[RegisteryDir]' /> </Property> <CustomAction Id="SET_INSTALL_DIR" Property="INSTALLDIR" Value="[SystemDir] /> <InstallExecuteSequence> <Custom Action='SET_INSTALLDIR' After='AppSearch'> SystemDir AND SystemDir=RegisteryDir </Custom> </InstallExecuteSequence>
Improve this answer

Comments

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.