Preg match fails on some urls - not emails

Question

I have the code below in the submitted form section of a php file. It is meant to catch any emails that contain a url and reject them.

 if (preg_match("/(\b(((https?|ftp|file|):\/\/)|www[.])[-A-Z0-9+&@#\/%?=~_|!:,.;]*[-A-Z0-9+&@#\/%=~_|])/i", $msg)) { return false; } return true;

But I received an email with dozens of lines like this:

[url=http://example.рф]шкафы купе[/url]

I tried sending a message with one of the lines in the original email and the code blocked it. Why didn't it stop this spammer?

Because рф aren't included in the character class [-A-Z0-9+&@#\/%=~_|] — Toto
– Toto, Commented Dec 26, 2018 at 14:43
Use PHP filers. Why would you even bother writing your own custom validator? PHP Validate filters — Dharman
– Dharman ♦, Commented Dec 26, 2018 at 14:44
Have you tested your regex? It does not seem to match any urls... — jeroen
– jeroen, Commented Dec 26, 2018 at 14:45
Possible duplicate of How to check if a string contains a email? — Dharman
– Dharman ♦, Commented Dec 26, 2018 at 14:47

user3052443 · Accepted Answer · 2018-12-26 15:44:50Z

Based on the replies, which I deeply appreciate, I changed the code to the following. All I really want is to block url's. It doesn't matter what the path and parameters are so I think this catches all possibilities. This is used instead of php filters because the filters page says it can't catch URN's.

 if (preg_match("/(\b(((https?|ftp|file|[-A-Z0-9]|):\/\/)|www[.]))/i", $msg)) {

Collectives™ on Stack Overflow

Preg match fails on some urls - not emails

1 Answer 1

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Linked

Related