C# Application.Run - Close Open File

Question

I have created a program to run on all of my users computers. When the application is launched from my server (\\fs3\netlogon\app.exe) it stays open throughout the lifetime of the program. I identify this by seeing it as an "open file" in Computer Management. I can force the "open file" to close from Computer Management and the program still runs fine.

public partial class Primary : Form { *my code* } Process[] procList = Process.GetProcessesByName(programName); if (Process.GetProcessesByName(programName).Length == 1) { Application.EnableVisualStyles(); Application.SetCompatibleTextRenderingDefault(false); Application.Run(new Primary()); } else { foreach (Process p in Process.GetProcessesByName(programName)) { if (Process.GetCurrentProcess().Id != p.Id) { p.CloseMainWindow(); p.Close(); p.Kill(); p.Dispose(); } } Main();

Example of many instances of the file loaded

Before I go ahead and spend the time to develop an entirely new method I wanted to ask to see if I make my current format work.

My goal is to launch the app, close the "open file" and the app continues to run no problem.

This is likely a misunderstanding on my part.

Are you explicitly opening the filestream in code?...or is this a side effect of running your app? — Idle_Mind
– Idle_Mind, Commented Jun 5, 2019 at 13:46
It is a misunderstanding, it is not a FileStream. You are seeing the side-effect of the memory-mapped view the CLR uses to load an assembly. Forcing the file to close is liable to crash the app when the just-in-time compiler needs to generate more code. ClickOnce deployment is the other way to do it, keeps the view open on a local copy of the assembly. — Hans Passant
– Hans Passant, Commented Jun 5, 2019 at 14:04

Steve Todd · Accepted Answer · 2019-06-05 14:58:13Z

1

You're not explicitly closing the current instance if you find an existing one.

 if (Process.GetProcessesByName(programName).Length == 1) { Application.EnableVisualStyles(); Application.SetCompatibleTextRenderingDefault(false); Application.Run(new Primary()); } else { Application.Shutdown(); }

Edited: fixed reasoning and solution

edited Jun 5, 2019 at 14:58

answered Jun 5, 2019 at 13:58

Steve Todd

1,2708 silver badges13 bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

Dortimer Over a year ago

Wouldn't you want to check that GetProssesesBYName returns anything before wrapping it in a using statement? Or at least check for null before the length?

Steve Todd Over a year ago

GetProssesesBYName returns an array of zero or more objects. The using statement will never fail.

Dortimer Over a year ago

Alright. I wasn't sure if it did or not. A good note to have I suppose.

Steve Todd Over a year ago

Mea culpa, read the wrong section in the docs, try the above.

CeaganP Over a year ago

I uploaded the code I use to handle if a process is already found to be running. This solution doesn't resolve my problem.

|

Collectives™ on Stack Overflow

C# Application.Run - Close Open File

1 Answer 1

7 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

7 Comments

Related