operator == overload not called for implied 'true'?

Question

I'm subclassing std::optional and need to delete the operator==(bool) and implement my custom operator==(enum).

To delete the operator, this worked:

constexpr bool operator == ( bool ) noexcept = delete;

Works great for the code below, throwing a "deleted function" compile error

OptionalSubclass<int> ReturnEvens( int i ) { if ( i % 2 == 0 ) return i; return {}; } : : auto result = ReturnEvens(42); if ( result == true ) std::cout << *result << " is even" << std::endl;

However, the below code, with an implied 'true', compiles and executes

auto result = ReturnEvens(42); if ( result ) std::cout << *result << " is even" << std::endl;

Is there a different operator I should be deleting?

Your function returns std::optional<int> rather than your new derived class. Is that deliberate? — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Jul 26, 2019 at 16:16
Please edit your question to contain minimal reproducible example — Slava
– Slava, Commented Jul 26, 2019 at 17:11
@LightnessRacesinOrbit, thanks for catching my mistake. Fixed my OP. — buttonsrtoys
– buttonsrtoys, Commented Jul 26, 2019 at 19:03

NathanOliver · Accepted Answer · 2019-07-26 16:14:19Z

6

std::optional has an operator bool() that allows it to be converted to a bool for evaluation in a condition. You need to delete that operator as well so it cannot be implicitly converted.

answered Jul 26, 2019 at 16:14

NathanOliver

183k29 gold badges323 silver badges439 bronze badges

Sign up to request clarification or add additional context in comments.

8 Comments

Slava Over a year ago

OP seems to use std::optional instead of his subclass. If that is the case then your answer is wrong.

Rakete1111 Over a year ago

@Slava OP made a mistake, but it's clear that the return object is supposed to be the derived object, not optional<int>.

Slava Over a year ago

@Rakete1111 it is not clear to me. And why do we have rules if we ignore them?

NathanOliver Over a year ago

@Slava They also say the the optional code in the first block is giving an error because the deleted the operator. So they are either modifying optional directly or just didn't want to show the derived class.

Slava Over a year ago

@NathanOliver they can say whatever. No minimal reproducible example - never happened. This suppose not only help OP but others who will come on relevant seacrh. And what do they see? You can disable std::optional operator

|

Collectives™ on Stack Overflow

operator == overload not called for implied 'true'?

1 Answer 1

8 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

8 Comments

Related