Why doesn't my action filter get called?

Question

The code:

public class TheFilter : ActionFilterAttribute { public override void OnActionExecuted(ActionExecutedContext filterContext) { var controllerName = filterContext.ActionDescriptor.ControllerDescriptor.ControllerName; } } public class NotesController : BaseController { [TheFilter] [HttpPost] public ActionResult Edit(EditViewModel viewModel) { viewModel.Note.Modified = DateTime.Now; viewModel.Note.ModifiedBy = User.Identity.Name; var noteTable = StorageHelper.GetTable<Note>(viewModel.PageMeta.DataSourceID); noteTable.AddOrUpdate(viewModel.Note); return Home(); } }

When I debug on return Home() and step through then I bypass the action filter and go straight to the Home() method.

Am I declaring the action filter correctly?

I've recreated the scenario exactly as you have it above and my action filter is hit. I realize this information does nothing to solve your problem, but I thought you should know that your code is correct. Some other form of configuration may be causing the issue you're experiencing. — Nathan Taylor
– Nathan Taylor, Commented Nov 10, 2011 at 14:32
Thanks Nathan. Should I declare the class with the name TheFilterAttribute or with the name TheFilter? I thought this may be a problem and tried that. However same result. It does not step into the OnActionExecuted — Samantha J T Star
– Samantha J T Star, Commented Nov 10, 2011 at 14:39
Just tried it without the 'Attribute' on the end of my action filter; it doesn't seem to matter. — Nathan Taylor
– Nathan Taylor, Commented Nov 10, 2011 at 14:40
I did try that but no difference. Still trying to find a solution. I step line by line from the line before return Home() and it completely avoids the filter. — Samantha J T Star
– Samantha J T Star, Commented Nov 10, 2011 at 14:46
Can you try adding an override of OnActionExecuting and put a breakpoint in it? I'm curious if it gets hit. — Nathan Taylor
– Nathan Taylor, Commented Nov 10, 2011 at 14:46

Josh Noe · Accepted Answer · 2013-09-30 23:26:14Z

Make sure you're implementing

System.Web.Mvc.ActionFilterAttribute

and not

System.Web.Http.Filters.ActionFilterAttribute

They both have OnActionExecuting and OnActionExecuted Methods, so it can be a little deceiving.

gdoron · Accepted Answer · 2011-11-10 15:10:55Z

2

Maybe you don't reach the method directly but call Edit action from other action?
put the filter on the controller and see what happens.

answered Nov 10, 2011 at 15:10

gdoron

151k59 gold badges302 silver badges376 bronze badges

1 Comment

Mohit Shah Over a year ago

I am trying to apply a custom action filter on an action but it is not getting fired but when putting it above the controller it is can u help me out here?

Ashish Shukla · Accepted Answer · 2018-10-26 10:51:11Z

I was also facing the same issue I was just missing the override keyword before the OnExecuting method. It started working after adding override keyword.

Ryand.Johnson · Accepted Answer · 2011-11-10 15:05:11Z

Use the Onexecuting not onExecuted

 public override void OnActionExecuting(ActionExecutingContext filterContext)

Collectives™ on Stack Overflow

Why doesn't my action filter get called?

4 Answers 4

Comments

1 Comment

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

1 Comment

Comments

Comments

Related