-
- Notifications
You must be signed in to change notification settings - Fork 3.6k
chore(deps): update all non-major dependencies #9881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughRepository-wide dependency and CI/tooling version bumps across many example, integration, package, and root manifests; several exported TypeScript public type signatures were adjusted in core and framework adapter packages. No runtime logic or implementation behavior changes. Changes
Sequence Diagram(s)(omitted — changes are type and manifest updates, not new multi-component runtime flows) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected --targets=test:sherif,test:knip,tes... | ❌ Failed | 3m 59s | View ↗ |
nx run-many --target=build --exclude=examples/*... | ❌ Failed | 1m 27s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-27 11:55:32 UTC
| Sizes for commit 74ea04a:
|
5fe90fc to 3e59dc2 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-test-utils/package.json
🚧 Files skipped from review as they are similar to previous changes (62)
- packages/react-query-persist-client/package.json
- examples/vue/persister/package.json
- examples/react/algolia/package.json
- examples/angular/basic/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/2.7-basic/package.json
- .github/workflows/pr.yml
- examples/svelte/simple/package.json
- examples/solid/default-query-function/package.json
- examples/react/react-native/package.json
- examples/vue/simple/package.json
- examples/react/basic/package.json
- packages/solid-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- packages/query-persist-client-core/package.json
- examples/react/star-wars/package.json
- packages/svelte-query-devtools/package.json
- packages/angular-query-experimental/package.json
- examples/angular/devtools-panel/package.json
- packages/angular-query-persist-client/package.json
- packages/solid-query-devtools/package.json
- packages/react-query/package.json
- packages/query-core/package.json
- examples/react/shadow-dom/package.json
- examples/react/suspense/package.json
- integrations/react-next-15/package.json
- packages/vue-query/package.json
- examples/react/playground/package.json
- examples/react/devtools-panel/package.json
- examples/solid/basic/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/basic/package.json
- examples/angular/auto-refetching/package.json
- packages/svelte-query/package.json
- examples/react/chat/package.json
- integrations/angular-cli-20/package.json
- package.json
- examples/vue/dependent-queries/package.json
- integrations/solid-vite/package.json
- examples/svelte/playground/package.json
- examples/react/basic-graphql-request/package.json
- examples/solid/simple/package.json
- packages/query-sync-storage-persister/package.json
- integrations/svelte-vite/package.json
- packages/eslint-plugin-query/package.json
- packages/query-async-storage-persister/package.json
- packages/solid-query/package.json
- integrations/react-webpack-4/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/nextjs-suspense-streaming/package.json
- packages/react-query-next-experimental/package.json
- integrations/vue-vite/package.json
- examples/react/default-query-function/package.json
- examples/react/rick-morty/package.json
- packages/svelte-query-persist-client/package.json
- examples/react/offline/package.json
- examples/svelte/star-wars/package.json
- examples/angular/pagination/package.json
- examples/react/simple/package.json
- integrations/react-vite/package.json
- examples/angular/simple/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
examples/react/eslint-legacy/package.jsonexamples/svelte/ssr/package.jsonexamples/angular/basic-persister/package.jsonexamples/vue/nuxt3/package.jsonexamples/svelte/optimistic-updates/package.jsonpackages/vue-query-devtools/package.jsonpackages/query-devtools/package.jsonexamples/angular/optimistic-updates/package.jsonexamples/angular/router/package.jsonexamples/solid/solid-start-streaming/package.jsonpackages/react-query-devtools/package.jsonexamples/solid/astro/package.jsonexamples/svelte/auto-refetching/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
packages/query-devtools/package.jsonpackages/react-query-devtools/package.jsonexamples/solid/astro/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (19)
examples/vue/basic/package.json (1)
16-16: LGTM!The patch-level bump from
^5.2.1to^5.2.4is safe and non-breaking. Caret versioning correctly constrains updates to patch versions only. This aligns with the PR objective of updating non-major dependencies..github/workflows/release.yml (1)
28-28: GitHub Actions checkout action patch update approved.The patch version bump (v5.0.0 → v5.0.1) for
actions/checkoutis a safe update and introduces no breaking changes to the workflow logic..github/workflows/autofix.yml (1)
21-21: GitHub Actions checkout action patch update approved.The patch version bump (v5.0.0 → v5.0.1) for
actions/checkoutis consistent with other workflow updates and safe.examples/svelte/ssr/package.json (1)
15-19: Svelte dependencies updated consistently.All devDependency updates are patch or minor versions, maintaining semver backward compatibility. Versions are consistent with parallel Svelte examples in this PR.
examples/svelte/optimistic-updates/package.json (1)
15-19: Svelte dependencies updated consistently with sibling examples.All updates are patch or minor versions. Consistency across Svelte examples is maintained.
packages/vue-query-devtools/package.json (1)
58-58: ESLint plugin devDependency patch update approved.The patch version bump (^10.5.0 → ^10.5.1) for
eslint-plugin-vueis a safe, non-breaking update for tooling.examples/solid/astro/package.json (1)
13-22: Astro Solid example dependencies updated safely.All updates are patch or minor versions (non-major). Minor versions for Astro integrations should maintain backward compatibility. No API surface changes detected.
examples/svelte/auto-refetching/package.json (1)
15-19: Svelte dependencies updated consistently across examples.Patch and minor version updates maintain consistency with other Svelte examples (ssr, optimistic-updates).
examples/react/eslint-legacy/package.json (1)
23-23: No issues identified.@vitejs/plugin-react v4.7.0 is published after the v4.x series added Vite 6 to its peerDependencies and includes React Compiler handling with explicit support for React 19, so the update is compatible with your current setup.
examples/vue/nuxt3/package.json (2)
10-10: LGTM — minor patch update to @tanstack/vue-query.The bump from ^5.90.2 to ^5.91.2 is a patch-level update within the existing semver range and should be safe.
13-13: No compatibility issues identified with Nuxt 3.12.4 → 3.20.1 update.The example codebase is minimal and does not use any features affected by the breaking changes between these versions. The nuxt.config.ts is empty (uses defaults), and the example only uses standard Nuxt 3 APIs (defineNuxtPlugin, useState) and the standard dehydrate/hydrate SSR pattern with @tanstack/vue-query. None of the 8 breaking change categories (schema strictness, page metadata, transitions, handlers, useHead, test utilities, deprecations, or security fixes) are triggered by this example code.
packages/query-devtools/package.json (1)
67-80: All dependency updates verified—no issues found.The version changes are all within non-major ranges (patch/minor updates only), no security vulnerabilities were detected, and npm-run-all2's patch upgrade (5.0.0 → 5.0.2) maintains CLI compatibility. All changes are confined to devDependencies with no impact to production code or the workspace dependency on
@tanstack/query-core.packages/react-query-devtools/package.json (1)
86-89: All three dependency updates are routine minor/patch versions with no breaking changes.@testing-library/react v16.0.1+ includes support for React 19, making the v16.3.0 update safe and compatible with React ^19.0.0. @vitejs/plugin-react v4.x has no breaking changes impacting the plugin, so any combination of React plugin and Vite core version will work. The npm-run-all2 patch update (^5.0.0 → ^5.0.2) is a standard maintenance release with no compatibility concerns.
examples/angular/router/package.json (1)
12-16: Angular dependencies consistently updated across framework packages.The version updates are consistent with the infinite-query-with-max-pages example and appropriate for non-major dependency maintenance. The addition of @angular/router (20.3.12) is appropriate for this routing example.
Also applies to: 20-20, 23-25
examples/angular/rxjs/package.json (1)
12-16: Angular dependencies consistently updated; forms package addition is appropriate.The updates follow the same pattern as other Angular examples. The inclusion of @angular/forms (20.3.12) is appropriate for an RxJS integration example that may involve form handling.
Also applies to: 20-20, 23-25
examples/angular/basic-persister/package.json (1)
12-15: Angular and persistence dependencies updated; TanStack Query versions remain stable.The Angular dependency updates (20.0.0 → 20.3.12) and zone.js patch (0.15.1) are consistent with other examples. TanStack Query packages (@tanstack/angular-query-persist-client and @tanstack/query-async-storage-persister) remain unchanged, which is appropriate for this non-major dependency update cycle.
Also applies to: 21-21, 24-26
examples/angular/optimistic-updates/package.json (1)
12-16: Angular dependencies consistently updated; forms package appropriate for use case.The version updates are consistent with the entire review set. The @angular/forms package (20.3.12) is appropriately included for an optimistic updates example.
Also applies to: 20-20, 23-25
integrations/react-webpack-5/package.json (1)
14-18: No compatibility issues found—Babel 7.28.5 and React 19 are fully compatible.Babel 7.28.5 has no known breaking incompatibilities with React 19. The integration uses default Babel configuration (no explicit .babelrc or babel.config.js), which applies the classic JSX runtime. React 19 supports the automatic JSX runtime, but Babel 7.28.5 defaults to the classic runtime and requires explicit runtime: "automatic" configuration to enable automatic transforms. Since React 19 supports the classic runtime, the current setup is fully compatible. The devDependency updates (Babel 7.26.0 → 7.28.5) are safe to merge.
examples/react/react-router/package.json (1)
17-19: Update@types/reactto version ^19.x.x for React 19 compatibility.The runtime dependencies (
react-router6.30.2,react-router-dom6.30.2,rooks8.4.0,@vitejs/plugin-react4.7.0) are all compatible with React 19. However, there is a critical type definition mismatch:@types/reactis pinned to ^18.2.79 while the project uses React ^19.0.0. This causes TypeScript to lack proper type definitions for React 19 APIs and features, resulting in type checking errors and incomplete IDE support.Update line 26 in
package.json:"@types/react": "^19.0.0"(or appropriate React 19 version).Additionally, the example currently fails to build due to an unrelated module resolution error with
@tanstack/react-query; this should be investigated separately.⛔ Skipped due to learnings
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach.
| "@testing-library/react": "^16.3.0", | ||
| "@types/react": "^19.0.1", | ||
| "@vitejs/plugin-react": "^4.3.4", | ||
| "npm-run-all2": "^5.0.0", | ||
| "@vitejs/plugin-react": "^4.7.0", | ||
| "npm-run-all2": "^5.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Verify @testing-library/dom peer dependency requirement for React Testing Library 16.
In React Testing Library v16, @testing-library/dom was moved to a peer dependency and needs to be explicitly installed, reducing the chance of conflicting versions. Line 86 updates to @testing-library/react ^16.3.0, but the package.json doesn't list @testing-library/dom as a dependency or peer dependency. Confirm whether this package directly uses @testing-library/dom or if it's only needed as a transitive dependency via the workspace dependency chain.
Run the following command to check if @testing-library/dom is required:
🏁 Script executed:
#!/bin/bash # Description: Check if the react-query-devtools package uses @testing-library/dom directly # Search for direct imports of @testing-library/dom in the package source rg -n "@testing-library/dom" packages/react-query-devtools/src/ # Also check the package.json in packages/react-query-devtools to see current state echo "=== Current devDependencies ===" jq '.devDependencies' packages/react-query-devtools/package.jsonLength of output: 230
Need to verify the actual dependency declaration in @testing-library/react v16.3.0 to determine if @testing-library/dom is included or only declared as peer dependency.
[/web_search]
Add @testing-library/dom as devDependency.
@testing-library/dom was moved to a peer dependency and needs to be explicitly installed. This reduces the chance of having conflicting versions of @testing-library/dom installed that frequently caused bugs when used with @testing-library/user-event. The package.json update at line 86 upgrades to @testing-library/react ^16.3.0, but does not include @testing-library/dom.
Add "@testing-library/dom": "^17.0.0" (or appropriate compatible version) to devDependencies.
🌐 Web query:
@testing-library/react 16.3.0 @testing-library/dom dependency 💡 Result:
Short answer: Starting with v16 (including 16.3.0) @testing-library/react no longer bundles @testing-library/dom — it requires @testing-library/dom to be installed as a peer dependency. Install @testing-library/dom alongside @testing-library/react (16.x expects @testing-library/dom v10+; 16.3.0 lists ^10.0.0). [1][2][3]
Sources:
- Testing Library docs (installation note about installing @testing-library/dom). [1]
- GitHub release / changelog for v16 (moved @testing-library/dom to peerDependencies). [2]
- Package metadata listing for @testing-library/react@16.3.0 showing @testing-library/dom ^10.0.0. [3]
Add @testing-library/dom as devDependency.
@testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as a peer dependency. The package.json is missing this required dependency. Add "@testing-library/dom": "^10.0.0" to devDependencies.
🤖 Prompt for AI Agents
In packages/react-query-devtools/package.json around lines 86 to 89, the package is missing the peer dependency required by @testing-library/react; add "@testing-library/dom": "^10.0.0" to devDependencies in package.json so that @testing-library/react v16.3.0 has its required peer available; update package.json devDependencies accordingly and run npm/yarn install to update lockfile. 9b740ec to 7977da1 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (5)
packages/react-query-devtools/package.json (1)
86-89: Missing peer dependency: add @testing-library/dom to devDependencies.This issue was flagged in the previous review and remains unresolved. @testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as an explicit peer dependency. Without it, test runs will experience version conflicts.
Apply this diff to add the required peer dependency:
"devDependencies": { "@tanstack/react-query": "workspace:*", "@testing-library/react": "^16.3.0", + "@testing-library/dom": "^10.0.0", "@types/react": "^19.0.1",packages/react-query/package.json (1)
73-79: Missing peer dependency: add @testing-library/dom to devDependencies.This issue was flagged in the previous review and remains unresolved. @testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as an explicit peer dependency. Without it, test runs will experience version conflicts.
Apply this diff to add the required peer dependency:
"devDependencies": { "@tanstack/query-persist-client-core": "workspace:*", "@tanstack/query-test-utils": "workspace:*", "@testing-library/react": "^16.3.0", + "@testing-library/dom": "^10.0.0", "@testing-library/react-render-stream": "^2.0.2",examples/angular/basic-persister/package.json (1)
21-21: Revert zone.js to 0.15.0 — already flagged as incompatible with Angular 20.3.13.A previous review conclusively determined that zone.js 0.16.0 is incompatible with Angular 20.3.13 and will break change detection. This is a duplicate concern across multiple Angular examples in this PR. Revert to 0.15.0.
- "zone.js": "0.16.0" + "zone.js": "0.15.0"examples/angular/router/package.json (1)
20-20: Revert zone.js to 0.15.0 — verified incompatible with Angular 20.3.13 via web search.A previous review verified via web search that Angular 20.3.13 requires zone.js 0.15.x and does not support 0.16.0. This same incompatibility appears across multiple Angular examples in the PR. Revert to 0.15.0.
- "zone.js": "0.16.0" + "zone.js": "0.15.0"examples/react/react-router/package.json (1)
23-24: Update @types/react and @types/react-dom to align with React 19.The package declares
reactandreact-domat^19.0.0, but the type definitions remain at^18.2.x. Current latest versions of @types/react and @types/react-dom for React 19 are 19.1.6 and 19.2.2 respectively.Update lines 23–24 in
examples/react/react-router/package.json:"@types/react": "^19.1.6", "@types/react-dom": "^19.2.2",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-test-utils/package.json
🚧 Files skipped from review as they are similar to previous changes (62)
- packages/vue-query/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/algolia/package.json
- packages/query-core/package.json
- examples/react/default-query-function/package.json
- examples/angular/basic/package.json
- examples/svelte/simple/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/2.7-basic/package.json
- examples/react/simple/package.json
- examples/vue/nuxt3/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/simple/package.json
- packages/vue-query-devtools/package.json
- examples/vue/simple/package.json
- examples/svelte/ssr/package.json
- integrations/react-vite/package.json
- packages/angular-query-experimental/package.json
- examples/solid/default-query-function/package.json
- packages/svelte-query/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/optimistic-updates/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/star-wars/package.json
- examples/vue/basic/package.json
- packages/react-query-persist-client/package.json
- packages/angular-query-persist-client/package.json
- packages/query-sync-storage-persister/package.json
- examples/react/eslint-legacy/package.json
- integrations/react-webpack-5/package.json
- examples/react/chat/package.json
- .github/workflows/release.yml
- examples/angular/infinite-query-with-max-pages/package.json
- examples/svelte/basic/package.json
- examples/react/nextjs-suspense-streaming/package.json
- examples/react/rick-morty/package.json
- integrations/vue-vite/package.json
- examples/react/playground/package.json
- examples/react/react-native/package.json
- integrations/svelte-vite/package.json
- packages/solid-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/suspense/package.json
- .github/workflows/pr.yml
- examples/svelte/load-more-infinite-scroll/package.json
- examples/react/basic/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/persister/package.json
- examples/angular/rxjs/package.json
- packages/svelte-query-persist-client/package.json
- examples/svelte/playground/package.json
- integrations/angular-cli-20/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/vue/dependent-queries/package.json
- examples/angular/optimistic-updates/package.json
- package.json
- integrations/react-webpack-4/package.json
- examples/svelte/auto-refetching/package.json
- integrations/react-next-15/package.json
- packages/query-devtools/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
packages/react-query/package.jsonpackages/react-query-devtools/package.jsonintegrations/solid-vite/package.jsonpackages/solid-query-devtools/package.jsonexamples/solid/basic/package.jsonexamples/vue/2.6-basic/package.jsonexamples/angular/basic-persister/package.jsonpackages/solid-query/package.jsonpackages/eslint-plugin-query/package.jsonexamples/solid/simple/package.jsonexamples/svelte/star-wars/package.jsonexamples/solid/astro/package.jsonexamples/react/offline/package.jsonpackages/react-query-next-experimental/package.jsonexamples/angular/router/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
packages/react-query-devtools/package.jsonintegrations/solid-vite/package.jsonpackages/solid-query-devtools/package.jsonexamples/solid/basic/package.jsonpackages/solid-query/package.jsonexamples/solid/simple/package.jsonexamples/solid/astro/package.jsonexamples/react/react-router/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (16)
examples/vue/2.6-basic/package.json (1)
11-11: Routine dependency update looks good.The
@tanstack/vue-querybump from^5.90.2to^5.91.2is a minor-patch version increase that respects the semver constraint and is consistent with the non-major update objectives of this Renovate PR.packages/eslint-plugin-query/package.json (1)
62-62: Routine dependency updates look good.All five updates are non-major patch bumps to TypeScript ESLint tooling and npm-run-all2. The semver ranges are compatible, and the updated eslint version (^9.39.1) continues to satisfy the peer dependency constraint (^8.57.0 || ^9.0.0). The @typescript-eslint/* packages are consistently bumped across dependencies and devDependencies.
Also applies to: 65-69
packages/react-query-next-experimental/package.json (1)
61-63: Routine devDependency updates look good.The version bumps to @vitejs/plugin-react, next, and npm-run-all2 are straightforward minor/patch updates with no compatibility concerns for this package's runtime or public API.
packages/solid-query-devtools/package.json (1)
71-74: Consistent patch updates for SolidJS tooling.DevDependencies are updated to the latest patch versions within their specified ranges. These align with parallel updates in
packages/solid-query/package.jsonand other SolidJS-related packages, ensuring a cohesive ecosystem upgrade across the monorepo..github/workflows/autofix.yml (1)
21-21: GitHub Actions patch update.The
actions/checkoutupdate to v5.0.1 is a patch-level improvement aligned with parallel updates in other workflow files (pr.yml,release.yml). Low-risk maintenance bump.integrations/solid-vite/package.json (1)
11-11: Consistent SolidJS ecosystem patches.The
solid-jsandvite-plugin-solidversions align with updates across other SolidJS packages in the PR. Patch-level updates carry minimal risk and maintain consistency.Also applies to: 13-13
examples/solid/astro/package.json (1)
13-13: Astro ecosystem and SolidJS framework updates.All updates are within their semantic versioning ranges (patch or minor). The
@astrojs/solid-js(5.0.7 → 5.1.3) and@astrojs/vercel(8.1.3 → 8.2.11) minor-version bumps align with the PR's non-major dependency update scope and should remain backward compatible.Also applies to: 15-15, 17-17, 21-21, 22-22
examples/solid/basic/package.json (1)
13-13: Consistent SolidJS patches in example.Both dependencies are updated to the same versions as other SolidJS packages in the PR, ensuring uniform tooling versions across examples.
Also applies to: 18-18
packages/solid-query/package.json (1)
74-77: Consistent devDependency patches for core SolidJS package.Updates mirror those in
packages/solid-query-devtools/package.json, maintaining uniformity across the SolidJS package ecosystem. All patch-level changes.examples/solid/simple/package.json (1)
13-13: Coordinated SolidJS patches in example.Dependency versions align perfectly with updates across other SolidJS examples and packages, reflecting a well-coordinated monorepo-wide patch cycle.
Also applies to: 19-19
examples/svelte/star-wars/package.json (1)
15-21: Let me search for the actual location of this package.json file:Based on the investigation, I found that the referenced file is part of the TanStack Query repository's examples directory. While the file couldn't be directly accessed in the sandbox environment, the example exists in the actual repository structure. Let me verify the compatibility of the specific dependency versions mentioned:
The devDependency updates are compatible and safe to merge.
SvelteKit 2.49.0 was published 3 days ago, and SvelteKit's latest version adds support for Svelte 5. Svelte 5 works with SvelteKit today, and no known critical issues exist for the specific versions listed (Svelte 5.43.15, SvelteKit 2.49.0, Tailwind 4.1.17, and the related adapter packages). All version changes are minor or patch updates—no breaking changes are expected. The example's devDependencies remain compatible and functional.
examples/react/react-router/package.json (1)
17-19: Dependency updates look compatible.The minor and patch version bumps for react-router, react-router-dom, rooks, and @vitejs/plugin-react are all within their respective caret ranges and should introduce no breaking changes.
Also applies to: 26-26
examples/react/devtools-panel/package.json (1)
17-17: LGTM. Minor version bump to @vitejs/plugin-react is consistent with the PR-wide update across React examples and falls within the caret specification.examples/react/shadow-dom/package.json (1)
19-19: LGTM. Consistent minor version bump to @vitejs/plugin-react aligned with the broader repository update.examples/react/offline/package.json (2)
22-22: LGTM. @vitejs/plugin-react update is consistent with the coordinated bump across React examples.
16-16: msw and react-hot-toast updates are compatible—no breaking changes or configuration adjustments required.msw v2.12.3 is a patch release with no breaking changes, and the jump from ^2.6.6 poses no compatibility risk. react-hot-toast v2.6.0 is compatible with React 19, which the offline example already uses (^19.0.0). The msw workerDirectory configuration is already correctly set up as an array in package.json and requires no adjustments.
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert zone.js to 0.15.0 — incompatible with Angular 20.3.13 (same issue across all Angular examples).
Zone.js 0.16.0 is incompatible with Angular 20.3.13 and will break change detection. This same critical issue appears in other Angular examples in this PR (basic-persister, router). Revert to 0.15.0.
- "zone.js": "0.16.0" + "zone.js": "0.15.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "zone.js": "0.16.0" | |
| "zone.js": "0.15.0" |
🤖 Prompt for AI Agents
In examples/angular/pagination/package.json around line 19, the dependency "zone.js" is set to "0.16.0" which is incompatible with Angular 20.3.13; change the version string to "0.15.0" to restore compatibility across Angular examples (also check and align other Angular example package.json files such as basic-persister and router to the same "0.15.0" value). 7977da1 to 40fb104 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
♻️ Duplicate comments (2)
packages/react-query-persist-client/package.json (1)
67-67: Add missing peer dependency for @testing-library/react v16.@testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as a peer dependency (moved from bundled in v16). Without explicit declaration, version conflicts during install and test execution are likely. This issue was flagged in the previous review and remains unresolved.
Add
"@testing-library/dom": "^10.0.0"to devDependencies:"devDependencies": { "@tanstack/query-test-utils": "workspace:*", "@tanstack/react-query": "workspace:*", + "@testing-library/dom": "^10.0.0", "@testing-library/react": "^16.3.0", "@types/react": "^19.0.1", "@vitejs/plugin-react": "^4.7.0", "npm-run-all2": "^5.0.2", "react": "^19.0.0" },packages/react-query/package.json (1)
73-74: Add missing peer dependency: @testing-library/dom is required for @testing-library/react v16.3.0.@testing-library/react v16.0.0+ moved @testing-library/dom and @types/react-dom to peer dependencies and requires them to be explicitly installed. This package is missing "@testing-library/dom" in devDependencies, which will cause unmet peer dependency errors during test runs.
This issue was previously flagged and remains unresolved.
Apply this diff to add the missing peer dependency:
"devDependencies": { "@tanstack/query-persist-client-core": "workspace:*", "@tanstack/query-test-utils": "workspace:*", + "@testing-library/dom": "^10.0.0", "@testing-library/react": "^16.3.0", "@testing-library/react-render-stream": "^2.0.2",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (3)
- examples/react/default-query-function/package.json
- packages/query-test-utils/package.json
- examples/react/nextjs-suspense-streaming/package.json
🚧 Files skipped from review as they are similar to previous changes (54)
- examples/vue/simple/package.json
- examples/vue/persister/package.json
- packages/react-query-next-experimental/package.json
- integrations/react-vite/package.json
- examples/angular/basic/package.json
- examples/react/offline/package.json
- examples/vue/nuxt3/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/simple/package.json
- examples/angular/devtools-panel/package.json
- integrations/svelte-vite/package.json
- packages/query-async-storage-persister/package.json
- examples/react/suspense/package.json
- examples/solid/simple/package.json
- examples/react/simple/package.json
- .github/workflows/pr.yml
- .github/workflows/autofix.yml
- packages/query-broadcast-client-experimental/package.json
- examples/angular/auto-refetching/package.json
- integrations/react-next-15/package.json
- examples/svelte/auto-refetching/package.json
- examples/svelte/simple/package.json
- examples/angular/rxjs/package.json
- examples/svelte/star-wars/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/vue-query/package.json
- examples/svelte/optimistic-updates/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/react/chat/package.json
- packages/angular-query-persist-client/package.json
- packages/query-core/package.json
- examples/vue/basic/package.json
- packages/svelte-query-devtools/package.json
- examples/angular/basic-persister/package.json
- packages/react-query-devtools/package.json
- examples/solid/default-query-function/package.json
- packages/svelte-query/package.json
- packages/query-devtools/package.json
- packages/solid-query-persist-client/package.json
- packages/query-persist-client-core/package.json
- examples/angular/pagination/package.json
- examples/react/react-router/package.json
- examples/solid/basic/package.json
- packages/vue-query-devtools/package.json
- integrations/react-webpack-5/package.json
- examples/react/shadow-dom/package.json
- integrations/solid-vite/package.json
- examples/react/devtools-panel/package.json
- examples/react/star-wars/package.json
- integrations/react-webpack-4/package.json
- .github/workflows/release.yml
- examples/angular/optimistic-updates/package.json
- examples/solid/basic-graphql-request/package.json
- examples/solid/solid-start-streaming/package.json
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
examples/vue/2.6-basic/package.jsonexamples/react/algolia/package.jsonexamples/svelte/ssr/package.jsonpackages/solid-query/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/react/basic-graphql-request/package.jsonexamples/svelte/load-more-infinite-scroll/package.jsonpackages/query-sync-storage-persister/package.jsonexamples/svelte/playground/package.jsonpackages/react-query/package.jsonexamples/react/basic/package.jsonexamples/angular/router/package.jsonpackages/angular-query-experimental/package.jsonpackages/react-query-persist-client/package.jsonexamples/vue/2.7-basic/package.jsonpackages/solid-query-devtools/package.jsonexamples/solid/astro/package.jsonpackage.jsonexamples/svelte/basic/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
packages/solid-query/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/solid-query-devtools/package.jsonexamples/solid/astro/package.json
📚 Learning: 2025-11-22T09:06:05.219Z
Learnt from: sukvvon Repo: TanStack/query PR: 9892 File: packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx:331-335 Timestamp: 2025-11-22T09:06:05.219Z Learning: In TanStack/query test files, when a queryFn contains side effects (e.g., setting flags for test verification), prefer async/await syntax for clarity; when there are no side effects, prefer the .then() pattern for conciseness. Applied to files:
packages/query-sync-storage-persister/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (26)
examples/react/basic/package.json (1)
23-23: Non-breaking devDependency update.The @vitejs/plugin-react minor version bump is safe and aligns with the caret constraint. No concerns with this update.
packages/query-sync-storage-persister/package.json (1)
67-67: Safe patch update.The npm-run-all2 patch bump is non-breaking and safe.
examples/vue/2.7-basic/package.json (1)
11-11: Non-breaking minor update.The @tanstack/vue-query minor version bump is safe and aligns with the caret constraint.
examples/react/basic-graphql-request/package.json (1)
13-14: Non-breaking minor updates.The graphql, graphql-request, and @vitejs/plugin-react minor version bumps are all safe and within caret constraints.
Also applies to: 19-19
examples/svelte/ssr/package.json (1)
15-16: Safe Svelte ecosystem updates.The @sveltejs/adapter-auto, @sveltejs/kit, svelte, and svelte-check updates are all patch or minor bumps and are safe within their respective caret constraints.
Also applies to: 18-19
examples/react/algolia/package.json (1)
11-11: Non-breaking updates.The @algolia/client-search update remains within major version 5, and the @vitejs/plugin-react minor bump is safe.
Also applies to: 21-21
packages/react-query-persist-client/package.json (1)
69-70: Safe tooling updates.The @vitejs/plugin-react and npm-run-all2 updates are safe minor and patch bumps.
packages/solid-query-devtools/package.json (1)
71-72: Safe Solid ecosystem updates.The npm-run-all2, solid-js, and vite-plugin-solid updates are all patch or minor bumps and are safe within their respective caret constraints.
Also applies to: 74-74
examples/svelte/basic/package.json (1)
17-21: Dependency updates look good.Routine minor/patch version bumps for Svelte tooling across examples. No concerns with version compatibility or range specifications.
examples/svelte/playground/package.json (1)
15-19: Consistent dependency updates across Svelte examples.Same pattern as other Svelte examples in this PR. All updates are non-breaking minor/patch versions.
examples/solid/astro/package.json (1)
13-22: Dependency updates are compatible.Routine minor/patch version bumps across Astro and related integrations. Version ranges remain compatible.
examples/react/playground/package.json (1)
17-17: Vite React plugin update is compatible.Minor version bump within the same major version. Consistent with updates across other React examples in the PR.
examples/vue/2.6-basic/package.json (1)
11-11: Internal package version update is appropriate.Minor version bump for @tanstack/vue-query. No breaking changes expected.
integrations/vue-vite/package.json (1)
13-13: Patch version update is safe.Minor patch bump for @vitejs/plugin-vue. No breaking changes expected.
examples/svelte/load-more-infinite-scroll/package.json (1)
15-19: Consistent Svelte tooling updates.Same dependency updates as other Svelte examples. All changes are non-breaking minor/patch versions.
packages/react-query/package.json (1)
77-79: Other dependency updates are appropriate.@vitejs/plugin-react and npm-run-all2 updates are routine non-breaking minor/patch bumps.
packages/angular-query-experimental/package.json (1)
92-102: Routine dependency updates — LGTM.DevDependency patches and Angular minor version bumps are standard maintenance. All updates are non-major and align with the PR's coordinated dependency refresh across the monorepo.
examples/react/rick-morty/package.json (1)
15-21: Routine React ecosystem updates — LGTM.Routing and UI toolchain dependencies updated with standard minor/patch bumps. All changes are non-breaking and align with the broader dependency refresh.
examples/vue/dependent-queries/package.json (1)
15-15: Minor plugin patch — LGTM.@vitejs/plugin-vue patched to ^5.2.4, a routine update with no breaking changes.
Also applies to: 15-15
packages/solid-query/package.json (1)
74-77: Solid.js ecosystem patches — LGTM.DevDependency updates to npm-run-all2, solid-js, and vite-plugin-solid are routine patch/minor bumps with no breaking changes.
packages/eslint-plugin-query/package.json (1)
62-62: ESLint and TypeScript tooling patches — LGTM.@typescript-eslint/* utilities and ESLint core updated with routine minor/patch bumps. Peer dependency constraints remain compatible and permissive.
Also applies to: 69-69
packages/svelte-query-persist-client/package.json (1)
55-55: Svelte ecosystem updates — LGTM.Svelte framework, testing, linting, and tooling dependencies updated with routine minor/patch bumps. All changes are non-breaking.
Also applies to: 63-63
examples/react/react-native/package.json (1)
19-29: React Native ecosystem update is substantial—recommend verification before merge.The dependency updates span a significant version range for the React Native ecosystem (react-native 0.76.3 → 0.82.1), and while all updates are within non-major ranges per the PR objectives, this represents meaningful changes across multiple ecosystem packages (gesture-handler, reanimated, screens, web, etc.). Renovate should have validated basic compatibility, but testing this version combination in CI would be prudent.
package.json (3)
8-8: pnpm packageManager update looks good.The pnpm patch update (10.17.0 → 10.23.0) is a reasonable maintenance bump within the 10.x series.
43-81: All devDependency updates are within non-major ranges and align with PR objectives.The updates across eslint, TypeScript tooling, testing libraries, and build infrastructure are consistent with the broader dependency refresh. The new TypeScript version aliases (typescript50–57) enable multi-version compatibility testing, which is appropriate for a monorepo library.
80-81: Verify vite and vitest versions are tested as a pair.The introduction of vite (^6.3.6) and vitest (3.2.4) suggests new build/test tooling infrastructure. Note that vitest is pinned to an exact version to maintain alignment with @vitest/coverage-istanbul (also 3.2.4). Ensure this version pair has been validated in CI before merge, as tooling interdependencies can be sensitive.
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: zone.js 0.16.0 incompatibility with Angular 20.3.13 (flagged in previous review).
This file was previously reviewed and flagged for incompatibility between zone.js 0.16.0 and Angular 20.3.13. The issue remains unresolved. Angular 20.3.13 requires zone.js 0.15.x; upgrading to 0.16.0 will break Angular's change detection and cause runtime/test failures. Revert to zone.js 0.15.x.
- "zone.js": "0.16.0" + "zone.js": "~0.15.0"Also applies to: 20-20
🤖 Prompt for AI Agents
In examples/angular/router/package.json around line 20, zone.js is pinned to 0.16.0 which is incompatible with Angular 20.3.13; revert the dependency to a 0.15.x release (e.g., "zone.js": "0.15.x") to restore compatibility, update package-lock/yarn lock by reinstalling dependencies, and run the test/build to verify no runtime/change-detection regressions. | "zone.js": "~0.15.0" | ||
| "rxjs": "~7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "~0.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CRITICAL: zone.js 0.16.0 is incompatible with Angular 20.3.13.
Zone.js updated from ~0.15.0 to ~0.16.0, but Angular 20.3.13 requires zone.js 0.15.x. This version mismatch will break Angular's change detection and cause runtime and test failures. Revert zone.js to the 0.15.x range.
- "zone.js": "~0.16.0" + "zone.js": "~0.15.0"Also applies to: 20-20
🤖 Prompt for AI Agents
In integrations/angular-cli-20/package.json around line 20, zone.js was bumped to "~0.16.0" which is incompatible with Angular 20.3.13; change the zone.js dependency back to the 0.15.x range (for example "~0.15.0") in this package.json (and any other affected variant branches such as 20-20) so Angular's required zone.js version is satisfied, then run npm install / yarn install and run tests to verify no runtime or test regressions. 6684346 to d096dba Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (4)
packages/react-query-persist-client/package.json (1)
67-67: Missing peer dependency: @testing-library/dom required by @testing-library/react v16.@testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as a peer dependency (moved from bundled dependency in v16), but it is not listed in devDependencies. This will cause version conflicts during testing.
Add the missing peer dependency:
"devDependencies": { "@tanstack/query-test-utils": "workspace:*", "@tanstack/react-query": "workspace:*", + "@testing-library/dom": "^10.0.0", "@testing-library/react": "^16.3.0", "@types/react": "^19.0.1",packages/react-query-devtools/package.json (1)
86-86: Missing peer dependency: @testing-library/dom required by @testing-library/react v16.@testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as a peer dependency (moved from bundled dependency in v16), but it is not listed in devDependencies. This will cause version conflicts and test failures.
Add the missing peer dependency:
"devDependencies": { "@tanstack/react-query": "workspace:*", + "@testing-library/dom": "^10.0.0", "@testing-library/react": "^16.3.0", "@types/react": "^19.0.1",packages/vue-query/package.json (1)
73-73: Critical: eslint-plugin-vue version constraint ^10.6.0 does not exist.A previous review flagged this issue: the latest available version of eslint-plugin-vue is v10.5.1 (released October 15, 2025). The PR specifies ^10.6.0, which will cause
npm installto fail and block the build.Update the version constraint to ^10.5.1 to match the latest available release:
- "eslint-plugin-vue": "^10.6.0", + "eslint-plugin-vue": "^10.5.1",examples/angular/basic/package.json (1)
19-19: Zone.js 0.16.0 incompatibility persists (flagged in previous review).This issue was already identified in past review comments and marked as addressed. However, line 19 still contains
"zone.js": "0.16.0", which is incompatible with Angular 20.3.13. Angular 20.3.x requires zone.js ~0.15.0 as a peer dependency. Please verify whether the fix from commit 1d27578 should be re-applied or if this PR should revert to the compatible version.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-sync-storage-persister/package.json
🚧 Files skipped from review as they are similar to previous changes (64)
- examples/solid/simple/package.json
- integrations/solid-vite/package.json
- integrations/svelte-vite/package.json
- .github/workflows/release.yml
- examples/react/simple/package.json
- examples/angular/optimistic-updates/package.json
- packages/query-test-utils/package.json
- examples/svelte/simple/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/optimistic-updates/package.json
- examples/vue/basic/package.json
- examples/angular/rxjs/package.json
- examples/react/chat/package.json
- packages/solid-query-devtools/package.json
- examples/react/shadow-dom/package.json
- examples/solid/basic-graphql-request/package.json
- examples/angular/auto-refetching/package.json
- packages/vue-query-devtools/package.json
- examples/react/star-wars/package.json
- integrations/react-next-15/package.json
- examples/solid/basic/package.json
- integrations/react-webpack-5/package.json
- examples/svelte/auto-refetching/package.json
- examples/solid/astro/package.json
- examples/react/react-native/package.json
- packages/solid-query/package.json
- examples/svelte/playground/package.json
- examples/react/suspense/package.json
- packages/react-query/package.json
- packages/eslint-plugin-query/package.json
- examples/react/react-router/package.json
- examples/angular/basic-persister/package.json
- examples/vue/nuxt3/package.json
- integrations/react-webpack-4/package.json
- packages/svelte-query/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- packages/query-persist-client-core/package.json
- packages/react-query-next-experimental/package.json
- examples/react/playground/package.json
- examples/react/algolia/package.json
- integrations/react-vite/package.json
- packages/query-core/package.json
- examples/react/eslint-legacy/package.json
- .github/workflows/pr.yml
- examples/react/rick-morty/package.json
- .github/workflows/autofix.yml
- examples/angular/pagination/package.json
- examples/react/default-query-function/package.json
- integrations/angular-cli-20/package.json
- packages/solid-query-persist-client/package.json
- packages/query-async-storage-persister/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/angular/router/package.json
- examples/react/offline/package.json
- examples/svelte/star-wars/package.json
- examples/svelte/basic/package.json
- examples/react/basic/package.json
- packages/angular-query-experimental/package.json
- examples/svelte/ssr/package.json
- examples/vue/persister/package.json
- packages/query-devtools/package.json
- examples/angular/devtools-panel/package.json
- examples/vue/2.7-basic/package.json
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
examples/solid/default-query-function/package.jsonpackages/react-query-persist-client/package.jsonpackages/svelte-query-devtools/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/react-query-devtools/package.json
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
examples/solid/default-query-function/package.jsonexamples/react/nextjs-suspense-streaming/package.jsonexamples/angular/simple/package.jsonpackages/react-query-persist-client/package.jsonexamples/vue/2.6-basic/package.jsonpackages/svelte-query-devtools/package.jsonpackages/vue-query/package.jsonexamples/react/basic-graphql-request/package.jsonexamples/angular/basic/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/solid/solid-start-streaming/package.jsonpackages/angular-query-persist-client/package.jsonpackages/react-query-devtools/package.jsonpackage.json
🔇 Additional comments (18)
examples/react/devtools-panel/package.json (1)
17-17: LGTM!The @vitejs/plugin-react update from ^4.3.4 to ^4.7.0 is a minor version bump within the specified constraint range. No issues identified.
examples/solid/default-query-function/package.json (1)
13-13: LGTM!Patch version bumps for solid-js and vite-plugin-solid are within the caret constraints. No issues identified.
Also applies to: 18-18
examples/vue/simple/package.json (1)
16-16: LGTM!@vitejs/plugin-vue patch update (^5.2.1 → ^5.2.4) is within constraint range. No concerns.
examples/react/nextjs-suspense-streaming/package.json (1)
14-14: LGTM!Next.js patch update (^16.0.1 → ^16.0.4) is within the constraint range. No issues.
examples/react/basic-graphql-request/package.json (1)
13-14: LGTM!All dependency updates (graphql, graphql-request, @vitejs/plugin-react) are patch/minor bumps within their caret constraints. No issues identified.
Also applies to: 19-19
examples/vue/dependent-queries/package.json (1)
15-15: Patch update to Vite Vue plugin is safe.The minor version constraint bump (^5.2.1 → ^5.2.4) for @vitejs/plugin-vue is a standard patch update with no API impact.
integrations/vue-vite/package.json (1)
13-13: Patch update to Vite Vue plugin is safe.The minor version constraint bump (^5.2.1 → ^5.2.4) for @vitejs/plugin-vue is a standard patch update with no API impact.
packages/vue-query/package.json (1)
66-66: Patch update to Vue devtools API is safe.The version constraint bump (^6.6.3 → ^6.6.4) for @vue/devtools-api is a standard patch update.
examples/vue/2.6-basic/package.json (1)
11-11: Patch update to @tanstack/vue-query is safe.The version constraint bump (^5.90.2 → ^5.91.2) is a standard patch update with no API impact. This aligns with other Vue examples in the PR.
examples/angular/simple/package.json (2)
12-15: Angular framework and zone.js updates are compatible.The updates from Angular ^20.0.0 to ^20.3.13 and zone.js 0.15.0 to 0.16.0 are standard non-major version bumps. All remain on Angular v20.x and are compatible with the codebase.
Also applies to: 19-19
22-24: Angular devDependency updates are safe.The updates from ^20.0.0 to ^20.3.12-13 for build and compiler tooling are standard non-major version bumps aligned with the framework updates above.
packages/svelte-query-persist-client/package.json (1)
55-55: Svelte ecosystem devDependency updates are safe.The updates to @sveltejs/package (^2.4.0 → ^2.5.6), @testing-library/svelte (^5.2.8 → ^5.2.9), @typescript-eslint/parser (^8.44.1 → ^8.48.0), eslint-plugin-svelte (^3.11.0 → ^3.13.0), svelte (^5.39.3 → ^5.44.0), and svelte-check (^4.3.1 → ^4.3.4) are all non-major version bumps. The peerDependency requirement (svelte ^5.25.0) remains satisfied.
Also applies to: 59-63
packages/svelte-query-devtools/package.json (1)
50-50: Svelte ecosystem dependency updates are safe.The updates to esm-env (^1.2.1 → ^1.2.2), @sveltejs/package (^2.4.0 → ^2.5.6), @typescript-eslint/parser (^8.44.1 → ^8.48.0), eslint-plugin-svelte (^3.11.0 → ^3.13.0), svelte (^5.39.3 → ^5.44.0), and svelte-check (^4.3.1 → ^4.3.4) are all non-major version bumps. The peerDependency requirement (svelte ^5.25.0) remains satisfied.
Also applies to: 53-53, 56-59
packages/angular-query-persist-client/package.json (2)
60-64: Angular framework devDependency updates are safe.The updates from ^20.0.0 to ^20.3.13 for Angular framework packages are standard non-major version bumps. The peerDependency requirements (>= 16.0.0) remain satisfied.
67-70: Testing and tooling devDependency updates are safe.The updates to @testing-library/angular (^18.0.0 → ^18.1.1), @testing-library/dom (^10.4.0 → ^10.4.1), eslint-plugin-jsdoc (^50.5.0 → ^50.8.0), and npm-run-all2 (^5.0.0 → ^5.0.2) are all non-major version bumps with no breaking changes expected.
package.json (3)
8-8: pnpm packageManager update looks good.Minor version bump from 10.17.0 to 10.23.0 is routine maintenance and safe.
43-68: DevDependency updates are appropriately scoped to non-major versions.All updates use caret ranges or patch bumps, which aligns with the PR objective. Changes support tooling improvements (linting, testing, build tools) without introducing breaking changes.
72-81: TypeScript multi-version testing aliases are a sound pattern.Adding typescript50-57 entries alongside the main typescript 5.8.3 enables testing against multiple TypeScript patch/minor versions. This is a best practice for library publishing and shouldn't create maintenance burden if integrated into CI properly. The addition of vite and vitest align with modern test tooling trends.
Please verify that these new entries are wired into CI/test scripts (e.g.,
test:typesscripts referenced at line 22) so the multi-version TypeScript testing is actually exercised.
dae21bb to cf31b4a Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (4)
packages/react-query/package.json (1)
73-74: Add missing peer dependency @testing-library/dom.@testing-library/react 16.3.0 requires @testing-library/dom ^10.0.0 as an explicit peer dependency. This is currently missing from devDependencies and will cause peer dependency warnings/installation failures. A previous review flagged this issue, and it remains unresolved.
Add
@testing-library/domto the devDependencies:"devDependencies": { "@tanstack/query-persist-client-core": "workspace:*", "@tanstack/query-test-utils": "workspace:*", + "@testing-library/dom": "^10.0.0", "@testing-library/react": "^16.3.0",examples/angular/infinite-query-with-max-pages/package.json (1)
12-19: zone.js 0.16.0 is incompatible with Angular 20.3.14 — violates peer dependency requirement.The npm registry shows Angular 20.3.14 explicitly requires
zone.js ~0.15.0(which allows ≥0.15.0 and <0.16.0). The package.json specifieszone.js 0.16.0, which falls outside this range and will trigger peer dependency warnings/errors.Additionally, zone.js 0.16.0 introduces breaking changes including removal of deep/legacy imports (
zone.js/dist/zone, etc.) and bundle layout changes. Update tozone.js ^0.15.0or handle the migration to 0.16.0 if intentional, ensuring all import statements and polyfills are updated accordingly.examples/angular/basic-persister/package.json (1)
21-21: Revert zone.js to 0.15.0 — incompatible with Angular 20.3.14.Line 21 updates zone.js from 0.15.0 to 0.16.0, but earlier reviews of this PR identified that Angular 20.3.x (including 20.3.14) requires zone.js ~0.15.x. Zone.js 0.16.0 is not officially supported and causes build/installation failures. The past review included evidence: build failures during pnpm install and web search results confirming Angular's zone.js peer dependency is ^0.15.0.
Apply this fix:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"examples/angular/devtools-panel/package.json (1)
20-20: Revert zone.js to 0.15.0 — incompatible with Angular 20.3.14.Line 20 updates zone.js from 0.15.0 to 0.16.0, but earlier reviews of this PR established that Angular 20.3.x (including 20.3.14) requires zone.js ~0.15.x. Zone.js 0.16.0 is not officially supported by Angular 20 and causes installation/build failures. This is the same issue flagged for examples/angular/basic-persister in this PR.
Apply this fix:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- .github/workflows/autofix.yml
- examples/react/playground/package.json
🚧 Files skipped from review as they are similar to previous changes (60)
- examples/react/basic/package.json
- examples/react/devtools-panel/package.json
- examples/react/eslint-legacy/package.json
- examples/react/rick-morty/package.json
- integrations/svelte-vite/package.json
- examples/solid/default-query-function/package.json
- packages/query-async-storage-persister/package.json
- examples/vue/dependent-queries/package.json
- examples/solid/astro/package.json
- packages/svelte-query-devtools/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/react-native/package.json
- integrations/react-webpack-5/package.json
- packages/react-query-persist-client/package.json
- packages/solid-query-persist-client/package.json
- packages/react-query-devtools/package.json
- examples/angular/auto-refetching/package.json
- packages/vue-query-devtools/package.json
- packages/eslint-plugin-query/package.json
- examples/react/suspense/package.json
- examples/svelte/star-wars/package.json
- examples/react/chat/package.json
- examples/react/algolia/package.json
- examples/svelte/auto-refetching/package.json
- examples/solid/simple/package.json
- .github/workflows/pr.yml
- examples/vue/simple/package.json
- packages/query-devtools/package.json
- examples/react/nextjs-suspense-streaming/package.json
- examples/angular/rxjs/package.json
- examples/react/offline/package.json
- examples/react/react-router/package.json
- packages/solid-query/package.json
- examples/solid/basic/package.json
- examples/vue/persister/package.json
- integrations/vue-vite/package.json
- integrations/react-vite/package.json
- examples/angular/router/package.json
- examples/angular/pagination/package.json
- packages/svelte-query/package.json
- examples/react/default-query-function/package.json
- examples/angular/basic/package.json
- packages/react-query-next-experimental/package.json
- packages/query-test-utils/package.json
- examples/react/shadow-dom/package.json
- examples/svelte/basic/package.json
- examples/vue/nuxt3/package.json
- examples/angular/query-options-from-a-service/package.json
- packages/query-core/package.json
- packages/query-broadcast-client-experimental/package.json
- integrations/angular-cli-20/package.json
- packages/query-sync-storage-persister/package.json
- packages/vue-query/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/solid-query-devtools/package.json
- examples/react/simple/package.json
- packages/angular-query-experimental/package.json
- examples/react/star-wars/package.json
- examples/svelte/simple/package.json
- examples/solid/solid-start-streaming/package.json
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
examples/angular/simple/package.jsonpackages/svelte-query-persist-client/package.jsonexamples/svelte/playground/package.jsonexamples/svelte/ssr/package.jsonintegrations/solid-vite/package.jsonexamples/vue/2.7-basic/package.jsonpackages/angular-query-persist-client/package.jsonexamples/svelte/optimistic-updates/package.jsonpackages/query-persist-client-core/package.jsonintegrations/react-next-15/package.jsonpackages/react-query/package.jsonexamples/vue/2.6-basic/package.jsonexamples/angular/devtools-panel/package.jsonexamples/angular/optimistic-updates/package.jsonexamples/angular/basic-persister/package.jsonpackage.jsonexamples/solid/basic-graphql-request/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
integrations/solid-vite/package.jsonexamples/solid/basic-graphql-request/package.json
📚 Learning: 2025-11-22T09:06:05.219Z
Learnt from: sukvvon Repo: TanStack/query PR: 9892 File: packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx:331-335 Timestamp: 2025-11-22T09:06:05.219Z Learning: In TanStack/query test files, when a queryFn contains side effects (e.g., setting flags for test verification), prefer async/await syntax for clarity; when there are no side effects, prefer the .then() pattern for conciseness. Applied to files:
packages/query-persist-client-core/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Preview
- GitHub Check: Test
🔇 Additional comments (17)
examples/vue/basic/package.json (1)
16-16: Approve: Patch version bump for @vitejs/plugin-vue.The update from ^5.2.1 to ^5.2.4 is within the caret range and represents a patch version bump. This is a safe, non-breaking update.
examples/vue/2.6-basic/package.json (1)
11-11: Approve: Minor version bump for @tanstack/vue-query.The update from ^5.90.2 to ^5.91.4 is a minor version bump within the caret range. This is a dependency on a package from the same monorepo and should be tested/coordinated within the workspace.
packages/query-persist-client-core/package.json (1)
66-66: Approve: Patch version bump for npm-run-all2.The update from ^5.0.0 to ^5.0.2 is a patch version bump within the caret range. This is a dev dependency used in test scripts and does not affect the distributed package.
examples/svelte/ssr/package.json (1)
15-19: Approve: Non-major version bumps for Svelte ecosystem packages.All updates—@sveltejs/adapter-auto (patch), @sveltejs/kit (minor), svelte (minor), and svelte-check (patch)—are within their caret ranges and non-major. These are consistent with similar updates across other Svelte examples in the PR.
integrations/solid-vite/package.json (1)
11-11: Approve: Patch version bumps for Solid.js ecosystem.The updates to solid-js (^1.9.7 → ^1.9.10) and vite-plugin-solid (^2.11.6 → ^2.11.10) are patch version bumps within caret ranges. These are non-breaking updates consistent with other Solid examples in the PR.
Also applies to: 13-13
examples/vue/2.7-basic/package.json (1)
11-11: Approve: Minor version bump for @tanstack/vue-query.The update from ^5.90.2 to ^5.91.4 is a minor version bump within the caret range, consistent with other Vue examples in this PR.
examples/svelte/playground/package.json (1)
15-19: Approve: Non-major version bumps for Svelte ecosystem packages.All updates (patch for adapter-auto and svelte-check; minor for kit and svelte) are within caret ranges. These match the updates in other Svelte examples in this PR.
.github/workflows/release.yml (1)
28-28: Approve: actions/checkout v5.0.1 is a stable patch release.v5.0.1 is an official release (Nov 17, 2025) that ports v6 cleanup to v5, confirming this is a maintenance-focused patch with no breaking changes. The update is safe to merge.
examples/solid/basic-graphql-request/package.json (1)
13-20: Dependency updates look solid.The minor/patch version bumps for GraphQL, graphql-request, Solid, and Vite plugin are compatible updates that align with the PR objectives. No apparent breaking changes or compatibility issues.
packages/svelte-query-persist-client/package.json (1)
55-63: Svelte ecosystem devDependency updates are compatible.Minor/patch version bumps across Svelte tooling (@sveltejs/package, svelte, svelte-check) and related packages (@testing-library/svelte, ESLint plugins). These fall within the peerDependency constraint (
svelte: ^5.25.0) and present no compatibility concerns.integrations/react-webpack-4/package.json (1)
14-21: Babel and webpack tooling updates are compatible.The coordinated Babel package updates (core, presets to 7.28.5) and babel-loader (8.4.1) maintain compatibility with webpack 4.44.2. The webpack-cli addition (4.10.0) is appropriate for webpack 4.x environments. No conflicts detected.
examples/svelte/optimistic-updates/package.json (1)
15-19: Svelte example dependencies properly updated.Minor/patch version bumps across SvelteKit (@sveltejs/kit, adapter-auto) and Svelte ecosystem (svelte, svelte-check) are backward-compatible. These updates maintain example consistency with the broader Svelte ecosystem version changes in the PR.
packages/react-query/package.json (1)
77-77: Minor version updates for build and testing tools are compatible.The @vitejs/plugin-react and npm-run-all2 updates are minor/patch versions that maintain backward compatibility with the existing build and test setup.
Also applies to: 79-79
examples/angular/simple/package.json (1)
12-19: I'll help you verify the zone.js 0.16.0 compatibility with Angular 20.3.14. Let me gather the necessary information.
<function_calls>
#!/bin/bashQuery NPM registry for Angular 20.3.14 peer dependencies and zone.js version
echo "=== Angular Core 20.3.14 Peer Dependencies ==="
curl -s https://registry.npmjs.org/@angular/core/20.3.14 | jq '.peerDependencies // "No peer dependencies found"'echo ""
echo "=== Zone.js 0.16.0 Package Info ==="
curl -s https://registry.npmjs.org/zone.js/0.16.0 | jq '{version: .version, published: .time, description: .description}'echo ""
echo "=== Zone.js 0.16.0 Peer Dependencies ==="
curl -s https://registry.npmjs.org/zone.js/0.16.0 | jq '.peerDependencies // "No peer dependencies"'
</function_calls>Now let me search for any compatibility issues or release notes about zone.js 0.16.0:
<function_calls>
zone.js 0.16.0 Angular 20.3 compatibility release notes
</function_calls>integrations/react-next-15/package.json (1)
9-9: @js-temporal/polyfill 0.5.1 is compatible with current usage patterns — no migration needed.The update from 0.4.4 to 0.5.1 does introduce breaking changes (0.5.0 removed user-defined Calendar/TimeZone classes and stopped coercing primitives to strings). However, the react-next-15 codebase uses only string-based
Temporal.PlainDate.from('YYYY-MM-DD')calls, which remain fully supported. No code changes are required.packages/angular-query-persist-client/package.json (1)
60-70: DevDependency updates align with Angular 20.3.14 and testing library improvements.All updates are patch/minor versions within existing semver ranges. The workspace:* dependencies for angular-query-experimental and query-test-utils are already in place (lines 65-66), supporting proper internal workspace resolution. No breaking changes expected.
package.json (1)
8-8: Root package.json updates are safe and well-scoped.The packageManager bump from pnpm 10.17.0 to 10.23.0 (line 8) is a minor version within the 10.x series and introduces no breaking changes. All devDependency updates (lines 43–81) are patch or minor bumps within existing caret ranges: @arethetypeswrong/cli, @changesets/cli, @cspell/eslint-plugin, @eslint-react/eslint-plugin, @tanstack/config, @testing-library/jest-dom, @vitest/eslint-plugin, eslint, jsdom, knip, markdown-link-extractor, nx, publint, and sherif. The TypeScript version mappings (typescript50–typescript57) support multi-version compatibility testing, and vite/vitest pinned versions align with project requirements.
Also applies to: 43-81
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert zone.js to 0.15.0 — incompatible with Angular 20.3.14.
Line 20 updates zone.js from 0.15.0 to 0.16.0, but earlier reviews of this PR established that Angular 20.3.x (including 20.3.14) requires zone.js ~0.15.x. Zone.js 0.16.0 is not officially supported by Angular 20 and causes installation/build failures. This is the same critical issue flagged for examples/angular/basic-persister and examples/angular/devtools-panel in this PR — it appears to be a systematic problem across all Angular examples receiving this dependency update.
Apply this fix:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "zone.js": "0.16.0" | |
| "zone.js": "0.15.0" |
🤖 Prompt for AI Agents
In examples/angular/optimistic-updates/package.json around line 20, the zone.js version was bumped to 0.16.0 which is incompatible with Angular 20.3.x; change the dependency back to the supported 0.15.x range (e.g. "zone.js": "0.15.0" or "zone.js": "~0.15.0") so the example matches Angular 20.3.14's required zone.js and avoids install/build failures. bae1cc8 to 670c627 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
♻️ Duplicate comments (5)
examples/angular/router/package.json (1)
12-25: CRITICAL: zone.js 0.16.0 incompatibility—previously flagged, remains unresolved.This file was previously reviewed and flagged for incompatibility between zone.js 0.16.0 and Angular 20.3.13. The issue persists in this updated version targeting Angular 20.3.14. zone.js 0.16.0 is a major version bump from 0.15.0, and Angular's strict compatibility requirements with zone.js mean this change will cause change detection failures and test breakage.
Revert zone.js to 0.15.x:
- "zone.js": "0.16.0" + "zone.js": "~0.15.0"examples/react/react-router/package.json (1)
23-24: @types/react and @types/react-dom must match React 19.x.The package declares React
^19.0.0but type definitions remain at^18.2.x. This mismatch causes type incompatibility and dev-time errors.Apply this diff to align type definitions with React 19:
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",integrations/angular-cli-20/package.json (1)
20-20: Revert zone.js to 0.15.x — incompatible with Angular 20.3.14.Zone.js 0.16.0 is incompatible with Angular 20.3.14 and will break Angular's change detection, causing runtime and test failures. Zone.js 0.15.x is required.
Apply this diff to restore compatibility:
- "zone.js": "~0.16.0" + "zone.js": "~0.15.0"examples/angular/pagination/package.json (1)
19-19: Revert zone.js to 0.15.0 — incompatible with Angular 20.3.14.Zone.js 0.16.0 is incompatible with Angular 20.3.14 and will break change detection. Zone.js 0.15.x is required for Angular 20.3.x.
Apply this diff:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"examples/angular/basic-persister/package.json (1)
21-21: Revert zone.js to 0.15.0 — breaks build with Angular 20.3.14.Zone.js 0.16.0 is incompatible with Angular 20.3.14 (which requires 0.15.x), causing
pnpm installto fail with version conflicts. Revert to 0.15.0.Apply this diff:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (56)
- packages/svelte-query-persist-client/package.json
- packages/eslint-plugin-query/package.json
- packages/react-query-persist-client/package.json
- examples/angular/devtools-panel/package.json
- packages/solid-query-persist-client/package.json
- examples/svelte/optimistic-updates/package.json
- examples/solid/astro/package.json
- examples/vue/dependent-queries/package.json
- examples/svelte/ssr/package.json
- examples/angular/basic/package.json
- examples/react/default-query-function/package.json
- packages/react-query-devtools/package.json
- packages/query-broadcast-client-experimental/package.json
- .github/workflows/release.yml
- examples/react/shadow-dom/package.json
- packages/react-query/package.json
- examples/react/chat/package.json
- examples/react/basic/package.json
- .github/workflows/pr.yml
- packages/query-test-utils/package.json
- examples/vue/nuxt3/package.json
- integrations/solid-vite/package.json
- examples/angular/optimistic-updates/package.json
- examples/react/eslint-legacy/package.json
- examples/angular/rxjs/package.json
- integrations/svelte-vite/package.json
- examples/solid/basic-graphql-request/package.json
- examples/svelte/simple/package.json
- examples/angular/auto-refetching/package.json
- packages/solid-query/package.json
- packages/svelte-query-devtools/package.json
- examples/vue/2.7-basic/package.json
- examples/vue/2.6-basic/package.json
- examples/react/basic-graphql-request/package.json
- integrations/react-vite/package.json
- examples/react/offline/package.json
- examples/solid/basic/package.json
- examples/react/playground/package.json
- examples/react/rick-morty/package.json
- packages/query-async-storage-persister/package.json
- packages/query-devtools/package.json
- examples/react/star-wars/package.json
- examples/svelte/playground/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/angular-query-persist-client/package.json
- examples/angular/simple/package.json
- packages/solid-query-devtools/package.json
- examples/vue/basic/package.json
- examples/react/devtools-panel/package.json
- examples/solid/simple/package.json
- examples/vue/persister/package.json
- examples/react/simple/package.json
- examples/react/algolia/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/svelte/basic/package.json
- packages/react-query-next-experimental/package.json
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
packages/vue-query-devtools/package.jsonpackages/query-core/package.jsonpackages/query-persist-client-core/package.jsonexamples/angular/router/package.jsonexamples/solid/solid-start-streaming/package.jsonexamples/svelte/auto-refetching/package.jsonexamples/solid/default-query-function/package.jsonexamples/angular/query-options-from-a-service/package.jsonpackages/vue-query/package.jsonpackages/svelte-query/package.jsonexamples/svelte/star-wars/package.jsonintegrations/react-next-15/package.jsonexamples/angular/basic-persister/package.jsonpackages/angular-query-experimental/package.jsonexamples/react/nextjs-suspense-streaming/package.jsonpackages/query-sync-storage-persister/package.jsonpackage.json
📚 Learning: 2025-11-22T09:06:05.219Z
Learnt from: sukvvon Repo: TanStack/query PR: 9892 File: packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx:331-335 Timestamp: 2025-11-22T09:06:05.219Z Learning: In TanStack/query test files, when a queryFn contains side effects (e.g., setting flags for test verification), prefer async/await syntax for clarity; when there are no side effects, prefer the .then() pattern for conciseness. Applied to files:
packages/query-core/package.jsonpackages/query-persist-client-core/package.jsonpackages/query-sync-storage-persister/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
examples/solid/solid-start-streaming/package.jsonexamples/solid/default-query-function/package.jsonexamples/react/react-router/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (21)
examples/vue/simple/package.json (1)
16-16: LGTM!Patch version bump for @vitejs/plugin-vue is safe and consistent with updates in other Vue example projects.
.github/workflows/autofix.yml (1)
21-21: LGTM!Patch version update to actions/checkout is safe and expected as part of routine CI/tooling maintenance.
integrations/vue-vite/package.json (1)
13-13: LGTM!Patch version bump for @vitejs/plugin-vue aligns with consistent updates across Vue-related integrations.
examples/svelte/auto-refetching/package.json (1)
15-19: LGTM!All Svelte ecosystem dependencies are updated within their major version lines (minor/patch bumps only). Updates are consistent and non-breaking.
examples/react/nextjs-suspense-streaming/package.json (1)
14-14: LGTM!Patch version update for Next.js is safe and non-breaking.
packages/vue-query/package.json (1)
66-66: LGTM!Patch version update for @vue/devtools-api is safe.
integrations/react-next-15/package.json (1)
9-9: Routine polyfill version bump.The @js-temporal/polyfill update (^0.4.4 → ^0.5.1) is a straightforward minor/patch bump for a compatibility polyfill. No concerns identified.
examples/react/suspense/package.json (1)
19-19: Routine Vite plugin minor version bump.The @vitejs/plugin-react update (^4.3.4 → ^4.7.0) is a standard minor version bump within the v4 release line. Compatible with React 19 and Vite 6.3.6.
examples/svelte/star-wars/package.json (1)
15-23: Routine Svelte ecosystem minor/patch version bumps.All devDependency updates are within the same major version lines (Svelte 5.x, SvelteKit 2.x, Tailwind 4.x). The updates represent standard maintenance without breaking changes. No compatibility concerns identified.
integrations/react-webpack-4/package.json (1)
14-17: Routine Babel toolchain patch/minor version updates.The Babel package updates (core, presets, babel-loader) are all minor or patch bumps within the v7/v8 release lines. Compatible with Webpack 4 in this integration. No breaking changes expected.
packages/svelte-query/package.json (1)
55-62: Routine dev tooling updates for Svelte package.All devDependency updates are minor/patch bumps within the same major versions. Svelte 5.44.1, eslint tooling, and testing utilities remain compatible. No impact on distributed package or public API.
examples/react/react-native/package.json (1)
19-33: Routine React Native ecosystem and Expo updates.The React Native and Expo package updates (expo 52.x, react-native 0.82.1, navigation/gesture/screen packages) are routine minor/patch bumps. Babel toolchain aligns with other integrations (^7.28.5). React 19.0.0 compatibility should be confirmed, but these versions generally align well together.
Please verify React 19.0.0 is compatible with react-native 0.82.1 and the Expo 52.x ecosystem. If runtime issues occur, check the React Native release notes for explicit React 19 support statements.
examples/angular/query-options-from-a-service/package.json (1)
12-20: CRITICAL: zone.js 0.16.0 incompatibility with Angular 20.3.14 confirmed.zone.js 0.16.0 (released November 2025) violates Angular 20.3.14's peerDependency constraint of
~0.15.0. Angular's official package.json specifies zone.js 0.15.x only; upgrading to 0.16.0 introduces a major version mismatch that will cause runtime failures and test breakage. zone.js 0.16.0 includes breaking changes (legacy browser support removal) and is not compatible with Angular 20.3.14.Revert zone.js to 0.15.x range and ensure Renovate respects peerDependency constraints for this package.
⛔ Skipped due to learnings
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json.package.json (2)
72-79: ✅ TypeScript version aliases enable multi-version testing.The new TypeScript 5.0–5.7 version aliases allow comprehensive type compatibility testing across the supported range. This is a solid pattern for monorepo tooling.
83-110: ✅ pnpm.overrides configuration for workspace dependencies.The new
pnpm.overridessection appropriately pins all internal @TanStack packages toworkspace:*, ensuring all dependent examples and integrations use the local versions. The@types/reactand@types/react-domoverrides at^19.0.1and^19.0.2align with React 19 across the workspace.packages/query-core/package.json (1)
63-63: ✅ Patch version bump for npm-run-all2.The npm-run-all2 patch update from ^5.0.0 to ^5.0.2 is safe and non-breaking. No script changes required.
packages/query-persist-client-core/package.json (1)
66-66: ✅ Patch version bump for npm-run-all2.The npm-run-all2 patch update from ^5.0.0 to ^5.0.2 is non-breaking and safe.
examples/solid/default-query-function/package.json (1)
13-13: ✅ Minor version bumps for Solid ecosystem.The solid-js and vite-plugin-solid patch updates (1.9.7→1.9.10 and 2.11.6→2.11.10 respectively) are non-breaking and align with other Solid examples in the PR.
Also applies to: 18-18
packages/query-sync-storage-persister/package.json (1)
67-67: Patch version bump is safe. npm-run-all2 ^5.0.2 is a non-breaking patch update; no runtime or build-time logic is affected.packages/angular-query-experimental/package.json (1)
92-101: DevDependency updates are backward compatible. All updates (Angular ^20.3.14, @testing-library/angular ^18.1.1, vite plugins, npm-run-all2) remain within their semver ranges and are devDependencies only. No runtime impact or breaking changes.examples/solid/solid-start-streaming/package.json (1)
13-18: Based on my investigation, I found a critical discrepancy in the review comment:Key Finding: The past review cited commits c01b150–fd2fe73 as addressing the Vite 6 SSR issue through adding a "solid" export condition. However:
- Commit c01b150 exists but is unrelated—it's about preventing infinite render loops in
useSuspenseQueries(#9886), not about solid-query exports.- Commit fd2fe73 does not appear in the recent history.
- No "solid" export condition exists in
packages/solid-query/package.json. The exports only contain@tanstack/custom-condition,development,import, andrequire.- The actual mitigation is different:
packages/solid-query/vite.config.tsuses'@tanstack/custom-condition'in its Vite resolve conditions (with a reference to vitest issue #6992), not a "solid" export condition.The cited fix is inaccurate. While there is a workaround in place (the custom-condition approach), it was not applied via the commits mentioned, and it doesn't match the past review's description. Since I cannot run build commands in the sandbox, I cannot verify whether the current dependency versions actually build successfully.
Verify the solid-query SSR export condition is present and build succeeds with updated Solid ecosystem versions.
A past review flagged a critical Vite 6 SSR entry resolution failure with vinxi ^0.5.8 and @tanstack/solid-query, claiming it was fixed by adding a "solid" export condition via commits c01b150–fd2fe73. However, those commits do not address solid-query exports, and no "solid" export condition exists in
packages/solid-query/package.json.Instead, the vite.config.ts uses a
@tanstack/custom-conditionworkaround. Confirm:
- The build completes without SSR entry resolution errors with these dependency versions.
- Whether the custom-condition approach in vite.config.ts is the intended fix or if a proper "solid" export condition should be added to package.json.
If this is a Solid Start-specific integration issue, verify the fix applies to
examples/solid/solid-start-streaming/as well.
| "@babel/core": "^7.28.5", | ||
| "@babel/preset-env": "^7.28.5", | ||
| "@babel/preset-react": "^7.28.5", | ||
| "babel-loader": "^9.2.1", | ||
| "html-webpack-plugin": "^5.6.3", | ||
| "html-webpack-plugin": "^5.6.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Major version bump for babel-loader violates PR constraints.
The latest version of eslint-plugin-vue is 10.6.0, last published: 4 days ago. Line 17 specifies babel-loader version ^9.2.1, but this represents a jump from ^8.3.0—a major version change from 8.x to 9.x. The PR objectives explicitly state "All changes are non-major (minor or patch)." This babel-loader update should be either reverted to a patch or minor version constraint within the 8.x series, or the PR scope should be clarified if major version updates are intentional.
Apply this diff to correct the babel-loader constraint to remain within the 8.x major version:
- "babel-loader": "^9.2.1", + "babel-loader": "^8.4.1",Alternatively, if babel-loader 9.x is intentional, update the PR description and objectives to reflect major version updates.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "@babel/core": "^7.28.5", | |
| "@babel/preset-env": "^7.28.5", | |
| "@babel/preset-react": "^7.28.5", | |
| "babel-loader": "^9.2.1", | |
| "html-webpack-plugin": "^5.6.3", | |
| "html-webpack-plugin": "^5.6.5", | |
| "@babel/core": "^7.28.5", | |
| "@babel/preset-env": "^7.28.5", | |
| "@babel/preset-react": "^7.28.5", | |
| "babel-loader": "^8.4.1", | |
| "html-webpack-plugin": "^5.6.5", |
| "@tanstack/vue-query": "workspace:*", | ||
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "eslint-plugin-vue": "^10.5.0", | ||
| "eslint-plugin-vue": "^10.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Critical: eslint-plugin-vue version constraint specifies non-existent version.
The latest version of eslint-plugin-vue is 10.6.0, last published 4 days ago. This PR specifies "^10.6.1" which does not exist. npm install will fail with a version resolution error. Correct the constraint to "^10.6.0" to match the actual latest available release (same fix needed in packages/vue-query/package.json line 73).
Apply this diff to fix the version constraint:
- "eslint-plugin-vue": "^10.6.1", + "eslint-plugin-vue": "^10.6.0",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "eslint-plugin-vue": "^10.6.1", | |
| "eslint-plugin-vue": "^10.6.0", |
🤖 Prompt for AI Agents
In packages/vue-query-devtools/package.json around line 58, the eslint-plugin-vue dependency is pinned to a non-existent version "^10.6.1" causing installs to fail; change the version constraint to "^10.6.0". Also apply the same fix in packages/vue-query/package.json at line 73 so both packages reference the actual latest release "^10.6.0". 10c3ef7 to 17a79ad Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (6)
packages/react-query-devtools/package.json (1)
86-86: Add @testing-library/dom as devDependency for @testing-library/react v16 compatibility.@testing-library/react v16.3.0 moved @testing-library/dom to a peer dependency, requiring explicit installation. This dependency is currently missing from devDependencies and will cause installation or runtime errors.
Add
@testing-library/domto devDependencies:"devDependencies": { "@tanstack/react-query": "workspace:*", "@testing-library/react": "^16.3.0", + "@testing-library/dom": "^10.0.0", "@types/react": "^19.0.1", "@vitejs/plugin-react": "^4.7.0", "npm-run-all2": "^5.0.2", "react": "^19.0.0"examples/react/react-router/package.json (1)
23-24: Type definitions misaligned with React 19 runtime.Lines 23-24 specify
@types/react@^18.2.79and@types/react-dom@^18.2.25, but the project uses React^19.0.0at lines 15-16. This mismatch will cause TypeScript errors.Apply this diff to align type definitions with React 19:
- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.0.1", + "@types/react-dom": "^19.0.2",After applying the diff, run
npm installto update the lockfile.integrations/react-vite/package.json (1)
11-11: Based on my verification, I can now provide the rewritten review comment:
Move @vitejs/plugin-react and vite to devDependencies.
Line 11 incorrectly lists
@vitejs/plugin-react@^4.7.0independencies, andvite@^6.3.6(line not shown but in dependencies section) is also incorrectly placed. Both Vite and Vite plugins are build-time only tools and must never be shipped to production. Compare withsvelte-viteandvue-viteintegrations in the same repo, which correctly place both indevDependencies.Apply this diff:
"dependencies": { "@tanstack/react-query": "workspace:*", "@tanstack/react-query-devtools": "workspace:*", - "@vitejs/plugin-react": "^4.7.0", "react": "^19.0.0", "react-dom": "^19.0.0", - "vite": "^6.3.6" + }, + "devDependencies": { + "@vitejs/plugin-react": "^4.7.0", + "vite": "^6.3.6" }examples/angular/router/package.json (1)
20-20: CRITICAL: zone.js 0.16.0 is incompatible with Angular 20.3.14.Line 20 updates zone.js from 0.15.0 to 0.16.0. Angular 20.3.14 requires zone.js 0.15.x; upgrading to 0.16.0 will break Angular's change detection and cause runtime/test failures. This issue was flagged in previous reviews for this PR and remains unresolved.
Apply this fix:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"examples/angular/optimistic-updates/package.json (1)
20-20: CRITICAL: zone.js 0.16.0 incompatibility with Angular 20.3.14 (systematic issue).Line 20 updates zone.js from 0.15.0 to 0.16.0, but Angular 20.3.14 requires zone.js ~0.15.x. This is the same critical incompatibility flagged multiple times in previous reviews of this PR across all Angular example packages. Zone.js 0.16.0 will break Angular's change detection.
Apply this fix:
- "zone.js": "0.16.0" + "zone.js": "0.15.0"integrations/angular-cli-20/package.json (1)
20-20: CRITICAL: zone.js ~0.16.0 is incompatible with Angular 20.3.14.Line 20 updates zone.js from ~0.15.0 to ~0.16.0. Angular 20.3.14 requires zone.js 0.15.x. This is the same critical incompatibility flagged in previous reviews across all Angular packages in this PR. Zone.js 0.16.0 will break Angular's change detection and cause runtime/test failures.
Apply this fix:
- "zone.js": "~0.16.0" + "zone.js": "~0.15.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (83)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (57)
- packages/vue-query-devtools/package.json
- integrations/solid-vite/package.json
- examples/svelte/playground/package.json
- examples/react/playground/package.json
- examples/vue/nuxt3/package.json
- examples/vue/2.7-basic/package.json
- examples/react/devtools-panel/package.json
- examples/react/basic/package.json
- packages/solid-query-persist-client/package.json
- examples/svelte/auto-refetching/package.json
- examples/react/algolia/package.json
- packages/angular-query-persist-client/package.json
- examples/vue/2.6-basic/package.json
- examples/svelte/ssr/package.json
- examples/vue/persister/package.json
- examples/vue/simple/package.json
- examples/angular/simple/package.json
- examples/angular/auto-refetching/package.json
- examples/angular/rxjs/package.json
- packages/solid-query-devtools/package.json
- examples/angular/pagination/package.json
- examples/react/offline/package.json
- packages/svelte-query/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/solid/astro/package.json
- examples/angular/basic-persister/package.json
- examples/react/rick-morty/package.json
- examples/react/nextjs-suspense-streaming/package.json
- examples/solid/solid-start-streaming/package.json
- packages/query-devtools/package.json
- examples/solid/basic/package.json
- examples/solid/default-query-function/package.json
- examples/react/suspense/package.json
- .github/workflows/release.yml
- integrations/react-webpack-5/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/simple/package.json
- examples/react/shadow-dom/package.json
- examples/react/eslint-legacy/package.json
- examples/svelte/basic/package.json
- examples/react/default-query-function/package.json
- examples/angular/devtools-panel/package.json
- examples/angular/basic/package.json
- examples/solid/basic-graphql-request/package.json
- examples/react/basic-graphql-request/package.json
- examples/react/chat/package.json
- packages/react-query/package.json
- packages/angular-query-experimental/package.json
- examples/svelte/optimistic-updates/package.json
- examples/solid/simple/package.json
- examples/svelte/simple/package.json
- packages/solid-query/package.json
- packages/svelte-query-devtools/package.json
- integrations/react-webpack-4/package.json
- examples/react/star-wars/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/load-more-infinite-scroll/package.json
🧰 Additional context used
🧠 Learnings (3)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
packages/query-async-storage-persister/package.jsonpackages/react-query-devtools/package.jsonpackages/react-query-next-experimental/package.jsonintegrations/react-next-15/package.jsonexamples/angular/router/package.jsonpackages/svelte-query-persist-client/package.jsonpackages/query-core/package.jsonpackages/query-persist-client-core/package.jsonintegrations/react-vite/package.jsonintegrations/angular-cli-20/package.jsonpackages/vue-query/package.jsonexamples/angular/optimistic-updates/package.jsonpackages/react-query-persist-client/package.jsonpackage.jsonexamples/svelte/star-wars/package.jsonintegrations/svelte-vite/package.jsonpackages/query-sync-storage-persister/package.json
📚 Learning: 2025-11-22T09:06:05.219Z
Learnt from: sukvvon Repo: TanStack/query PR: 9892 File: packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx:331-335 Timestamp: 2025-11-22T09:06:05.219Z Learning: In TanStack/query test files, when a queryFn contains side effects (e.g., setting flags for test verification), prefer async/await syntax for clarity; when there are no side effects, prefer the .then() pattern for conciseness. Applied to files:
packages/query-async-storage-persister/package.jsonpackages/query-core/package.jsonpackages/query-persist-client-core/package.jsonpackages/query-sync-storage-persister/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
packages/react-query-devtools/package.jsonexamples/react/react-router/package.jsonpackages/svelte-query-persist-client/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (22)
examples/vue/basic/package.json (1)
16-16: LGTM!Routine patch update for the Vue plugin. No compatibility concerns with patch-level version bumps in the Vite ecosystem.
examples/vue/dependent-queries/package.json (1)
15-15: LGTM!Consistent patch update across Vue examples for the Vite plugin.
packages/query-test-utils/package.json (1)
38-38: LGTM!Patch update to dev-only script runner. No impact on package functionality or exports.
packages/react-query-persist-client/package.json (2)
69-70: LGTM!@vitejs/plugin-react and npm-run-all2 patch updates are routine and low-risk.
67-67: I'll verify the review comment about the missing @testing-library/dom peer dependency. Let me start by examining the package.json file and checking the actual peer dependency requirements.
<function_calls>
check_package_json
#!/bin/bashRead the package.json file for react-query-persist-client
cat -n packages/react-query-persist-client/package.json
</function_calls>
<function_calls>
testing_library_react_v16_peer_deps
@testing-library/react v16.3.0 peer dependencies @testing-library/dom
</function_calls>
<function_calls>
search_testing_library_dom
#!/bin/bashSearch for any existing references to @testing-library/dom in the project
rg "@testing-library/dom" --type json
</function_calls>packages/query-persist-client-core/package.json (1)
66-66: LGTM!Patch update to dev-only script runner. No impact on this core library or its consumers.
packages/query-sync-storage-persister/package.json (1)
67-67: LGTM!Patch update to dev-only script runner with no consumer impact.
packages/query-async-storage-persister/package.json (1)
67-67: LGTM!Patch update to dev-only script runner with no consumer impact.
packages/query-core/package.json (1)
63-63: LGTM!Patch update to dev-only script runner. No impact on the core library or framework-specific packages that depend on it.
integrations/react-next-15/package.json (1)
9-9: LGTM!Straightforward polyfill update. No compatibility concerns with Next.js 15.3.1 and React 19 stack, and type definitions are correctly aligned.
integrations/vue-vite/package.json (1)
13-13: LGTM!Straightforward patch bump for the Vite Vue plugin. No compatibility concerns.
integrations/svelte-vite/package.json (1)
12-12: LGTM!Minor version bump within Svelte v5. No breaking changes expected for this version progression.
examples/svelte/star-wars/package.json (1)
18-18: Example code is fully compatible with Tailwind CSS v4—no migration steps needed.While Tailwind CSS v4 does introduce breaking changes (config format, CSS imports, utility renames), this example does not use any deprecated patterns. All Tailwind classes in the code (
text-*,flex,gap-6,hover:*, etc.) are v4-compatible. The example uses the modern@tailwindcss/viteplugin and relies on v4 defaults (no custom config file), so it will work without modification.packages/react-query-next-experimental/package.json (1)
61-63: ✓ Routine dev dependency updates for Next.js experimental package.These are safe version bumps within supported ranges. @vitejs/plugin-react 4.7.0, Next.js 16.0.5, and npm-run-all2 5.0.2 are all compatible with the declared peer dependencies.
packages/eslint-plugin-query/package.json (1)
62-62: ✓ ESLint and TypeScript tooling updates are consistent and safe.All @typescript-eslint/* packages bumped to 8.48.0, and ESLint updated to 9.39.1. These versions maintain backward compatibility and are within the declared peer dependency ranges.
Also applies to: 65-66, 68-69
packages/svelte-query-persist-client/package.json (1)
55-55: ✓ Svelte ecosystem dev dependency updates are routine and compatible.All Svelte-related packages (@sveltejs/package, svelte, svelte-check, eslint-plugin-svelte) and testing libraries are updated within their respective ranges. Updates align with Svelte 5.x and maintain compatibility with the declared peer dependencies.
Also applies to: 59-63
examples/react/react-native/package.json (1)
19-33: ✓ React Native and Expo ecosystem updates are routine and compatible.React Native 0.82.1 is a standard minor version bump from 0.76.3, supported by Expo 52.0.47. Related packages (react-native-reanimated, react-native-paper, gesture-handler, screens, web, safe-area-context) are all updated to compatible versions. Babel updates are routine maintenance within the ^7 range.
integrations/angular-cli-20/package.json (1)
18-19: ✓ RxJS and tslib updates are safe.Patch and minor version updates are routine and compatible with Angular 20.3.14.
package.json (1)
8-8: ✓ Root package.json tooling and dependency updates are routine and well-structured.pnpm updated to 10.23.0 (patch bump). DevDependencies consistently updated to compatible minor/patch versions across ESLint (9.39.1), Vitest ecosystem, testing libraries, and build tools. The new
pnpm.overridessection (lines 83–109) is a best practice for monorepo stability, ensuring workspace packages resolve toworkspace:*versions. Vite 6.3.6 and Vitest 3.2.4 are compatible with the declared dev setup.Also applies to: 43-68, 80-81, 83-109
.github/workflows/autofix.yml (1)
21-21: Routine checkout action patch update.The bump from
actions/checkout@v5.0.0tov5.0.1is a patch-level update and should contain only bug fixes or security patches with no breaking changes..github/workflows/pr.yml (2)
23-23: Consistent checkout action patch updates across all jobs.All three instances of
actions/checkoutare uniformly bumped fromv5.0.0tov5.0.1across the Test, Preview, and Provenance jobs. Patch-level updates should contain only bug fixes or security patches with no breaking changes.Also applies to: 52-52, 80-80
31-31: Routine nx-set-shas action minor update.The bump from
nrwl/nx-set-shas@v4.3.3tov4.4.0is a minor-level update. Minor updates should maintain backward compatibility with the existing step configuration.
| "@vitejs/plugin-vue": "^5.2.4", | ||
| "@vue/composition-api": "1.7.2", | ||
| "eslint-plugin-vue": "^10.5.0", | ||
| "eslint-plugin-vue": "^10.6.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
eslint-plugin-vue 10.6.1 npm registry
<web_search_result>
I couldn't find eslint-plugin-vue@10.6.1 on the npm registry or GitHub releases. The latest published release appears to be v10.5.1 (GitHub releases). [1][2]
Sources:
- GitHub releases (vuejs/eslint-plugin-vue) — latest tag v10.5.1. [1]
- npm package page for eslint-plugin-vue. [2]
</web_search_result>
eslint-plugin-vue@10.6.1 does not exist; latest version is 10.5.1.
Line 73 specifies eslint-plugin-vue@^10.6.1, but this version does not exist on npm. The latest published version is v10.5.1. This will cause installation failures. Update to a valid version, such as ^10.5.1.
🤖 Prompt for AI Agents
In packages/vue-query/package.json around line 73 the dependency "eslint-plugin-vue": "^10.6.1" references a non-existent npm version; change it to a valid published version such as "^10.5.1" (or the exact latest available), update package.json accordingly, then run a fresh install (npm/yarn/pnpm) and verify lockfile changes are committed. 17a79ad to 1da8c59 Compare There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (7)
examples/react/react-router/package.json (1)
23-24: Update @types/react and @types/react-dom to match React 19.The project uses React
^19.0.0(dependencies, line 15) but@types/reactand@types/react-domremain at^18.2.x(devDependencies, lines 23-24). This mismatch will cause type errors. React 19 requires corresponding type definitions at version 19.x.- "@types/react": "^18.2.79", - "@types/react-dom": "^18.2.25", + "@types/react": "^19.2.3", + "@types/react-dom": "^19.2.3",packages/react-query-devtools/package.json (1)
86-86: Critical: Missing @testing-library/dom peer dependency for @testing-library/react v16.x.@testing-library/react v16.3.0 requires @testing-library/dom ^10.0.0 as an explicit peer dependency (moved from bundled in v15). Without this, tests may fail with version conflicts or missing dependencies.
Add
"@testing-library/dom": "^10.0.0"to devDependencies:"devDependencies": { "@tanstack/react-query": "workspace:*", "@testing-library/react": "^16.3.0", + "@testing-library/dom": "^10.0.0", "@types/react": "^19.0.1", "@vitejs/plugin-react": "^4.7.0", "npm-run-all2": "^5.0.2", "react": "^19.0.0" }Then run
pnpm installto update the lockfile.examples/angular/rxjs/package.json (1)
20-20: Align zone.js version specifier to allow patch updates.zone.js is pinned to exact version
"0.16.0", but should use tilde range"~0.16.0"to allow patch-level updates for bug fixes and security improvements. This aligns with Angular's peer dependency conventions and the pattern used in other Angular integrations likeintegrations/angular-cli-20/package.json.Apply this diff:
- "zone.js": "0.16.0" + "zone.js": "~0.16.0"examples/angular/optimistic-updates/package.json (1)
20-20: CRITICAL: zone.js 0.16.0 incompatible with Angular 20.3.14 — revert to 0.15.x.zone.js 0.16.0 is incompatible with Angular 20.3.14. This is the same critical issue flagged in the previous review of this file. Revert to zone.js 0.15.0 to maintain compatibility with Angular's change detection.
- "zone.js": "0.16.0" + "zone.js": "0.15.0"examples/angular/basic-persister/package.json (1)
21-21: CRITICAL: zone.js 0.16.0 incompatible with Angular 20.3.14 — revert to 0.15.x.This is the same zone.js incompatibility issue flagged in the previous review of this file and across other Angular examples in this PR. zone.js 0.16.0 is not compatible with Angular 20.3.14. Revert to zone.js 0.15.0.
- "zone.js": "0.16.0" + "zone.js": "0.15.0"integrations/react-webpack-5/package.json (1)
17-17: Major version bump violates PR constraints — babel-loader must remain in 8.x series.The PR objectives state "All changes are non-major (minor or patch)." Line 17 specifies
babel-loader ^9.2.1, which permits versions in the 9.x series—a major version change from the previous 8.x series. This violates the stated PR scope. The Babel core packages are properly constrained to ^7.28.5 (within 7.x), but babel-loader must similarly stay within a compatible major version range.- "babel-loader": "^9.2.1", + "babel-loader": "^8.4.1",examples/angular/router/package.json (1)
20-20: CRITICAL: zone.js 0.16.0 incompatible with Angular 20.3.14 — revert to 0.15.x.Angular 20.3.1 (which is equivalent to the 20.3.14 in this file) uses zone.js 0.15.1, not 0.16.0. The zone.js upgrade to 0.16.0 breaks Angular's change detection pipeline and causes runtime failures. Revert to zone.js 0.15.0 to match the Angular 20.3.14 compatibility requirement.
- "zone.js": "0.16.0" + "zone.js": "0.15.0"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (89)
.github/workflows/autofix.yml(1 hunks).github/workflows/pr.yml(3 hunks).github/workflows/release.yml(1 hunks)examples/angular/auto-refetching/package.json(1 hunks)examples/angular/basic-persister/package.json(1 hunks)examples/angular/basic/package.json(1 hunks)examples/angular/devtools-panel/package.json(1 hunks)examples/angular/infinite-query-with-max-pages/package.json(1 hunks)examples/angular/optimistic-updates/package.json(1 hunks)examples/angular/pagination/package.json(1 hunks)examples/angular/query-options-from-a-service/package.json(1 hunks)examples/angular/router/package.json(1 hunks)examples/angular/rxjs/package.json(1 hunks)examples/angular/simple/package.json(1 hunks)examples/react/algolia/package.json(2 hunks)examples/react/basic-graphql-request/package.json(1 hunks)examples/react/basic/package.json(1 hunks)examples/react/chat/package.json(1 hunks)examples/react/default-query-function/package.json(1 hunks)examples/react/devtools-panel/package.json(1 hunks)examples/react/eslint-legacy/package.json(1 hunks)examples/react/nextjs-suspense-streaming/package.json(1 hunks)examples/react/offline/package.json(1 hunks)examples/react/playground/package.json(1 hunks)examples/react/react-native/package.json(1 hunks)examples/react/react-router/package.json(1 hunks)examples/react/rick-morty/package.json(1 hunks)examples/react/shadow-dom/package.json(1 hunks)examples/react/simple/package.json(1 hunks)examples/react/star-wars/package.json(1 hunks)examples/react/suspense/package.json(1 hunks)examples/solid/astro/package.json(1 hunks)examples/solid/basic-graphql-request/package.json(1 hunks)examples/solid/basic/package.json(1 hunks)examples/solid/default-query-function/package.json(1 hunks)examples/solid/simple/package.json(1 hunks)examples/solid/solid-start-streaming/package.json(1 hunks)examples/svelte/auto-refetching/package.json(1 hunks)examples/svelte/basic/package.json(1 hunks)examples/svelte/load-more-infinite-scroll/package.json(1 hunks)examples/svelte/optimistic-updates/package.json(1 hunks)examples/svelte/playground/package.json(1 hunks)examples/svelte/simple/package.json(1 hunks)examples/svelte/ssr/package.json(1 hunks)examples/svelte/star-wars/package.json(1 hunks)examples/vue/2.6-basic/package.json(1 hunks)examples/vue/2.7-basic/package.json(1 hunks)examples/vue/basic/package.json(1 hunks)examples/vue/dependent-queries/package.json(1 hunks)examples/vue/nuxt3/package.json(1 hunks)examples/vue/persister/package.json(1 hunks)examples/vue/simple/package.json(1 hunks)integrations/angular-cli-20/package.json(1 hunks)integrations/react-next-15/package.json(1 hunks)integrations/react-vite/package.json(1 hunks)integrations/react-webpack-4/package.json(1 hunks)integrations/react-webpack-5/package.json(1 hunks)integrations/solid-vite/package.json(1 hunks)integrations/svelte-vite/package.json(1 hunks)integrations/vue-vite/package.json(1 hunks)package.json(2 hunks)packages/angular-query-experimental/package.json(1 hunks)packages/angular-query-experimental/src/types.ts(3 hunks)packages/angular-query-persist-client/package.json(1 hunks)packages/eslint-plugin-query/package.json(1 hunks)packages/query-async-storage-persister/package.json(1 hunks)packages/query-broadcast-client-experimental/package.json(1 hunks)packages/query-core/package.json(1 hunks)packages/query-core/src/types.ts(9 hunks)packages/query-devtools/package.json(1 hunks)packages/query-persist-client-core/package.json(1 hunks)packages/query-persist-client-core/src/persist.ts(2 hunks)packages/query-sync-storage-persister/package.json(1 hunks)packages/query-test-utils/package.json(1 hunks)packages/react-query-devtools/package.json(1 hunks)packages/react-query-next-experimental/package.json(1 hunks)packages/react-query-persist-client/package.json(1 hunks)packages/react-query/package.json(1 hunks)packages/react-query/src/types.ts(7 hunks)packages/solid-query-devtools/package.json(1 hunks)packages/solid-query-persist-client/package.json(1 hunks)packages/solid-query/package.json(1 hunks)packages/solid-query/src/QueryClient.ts(3 hunks)packages/solid-query/src/types.ts(4 hunks)packages/svelte-query-devtools/package.json(1 hunks)packages/svelte-query-persist-client/package.json(1 hunks)packages/svelte-query/package.json(1 hunks)packages/vue-query-devtools/package.json(1 hunks)packages/vue-query/package.json(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- packages/query-persist-client-core/src/persist.ts
🚧 Files skipped from review as they are similar to previous changes (58)
- integrations/vue-vite/package.json
- .github/workflows/release.yml
- examples/vue/2.6-basic/package.json
- examples/react/devtools-panel/package.json
- examples/react/basic/package.json
- packages/react-query/package.json
- examples/svelte/load-more-infinite-scroll/package.json
- packages/query-broadcast-client-experimental/package.json
- examples/react/playground/package.json
- examples/angular/query-options-from-a-service/package.json
- examples/svelte/simple/package.json
- packages/vue-query-devtools/package.json
- packages/svelte-query-persist-client/package.json
- examples/angular/auto-refetching/package.json
- examples/vue/2.7-basic/package.json
- packages/solid-query/package.json
- integrations/react-vite/package.json
- packages/eslint-plugin-query/package.json
- packages/react-query-persist-client/package.json
- examples/react/default-query-function/package.json
- examples/angular/pagination/package.json
- examples/react/star-wars/package.json
- examples/react/shadow-dom/package.json
- integrations/angular-cli-20/package.json
- examples/angular/basic/package.json
- integrations/svelte-vite/package.json
- examples/svelte/basic/package.json
- packages/angular-query-experimental/package.json
- examples/svelte/playground/package.json
- packages/react-query-next-experimental/package.json
- examples/solid/solid-start-streaming/package.json
- examples/react/offline/package.json
- examples/vue/nuxt3/package.json
- examples/react/simple/package.json
- examples/solid/basic/package.json
- examples/vue/dependent-queries/package.json
- integrations/react-next-15/package.json
- examples/react/basic-graphql-request/package.json
- packages/angular-query-persist-client/package.json
- packages/vue-query/package.json
- packages/svelte-query-devtools/package.json
- packages/query-sync-storage-persister/package.json
- examples/vue/persister/package.json
- examples/react/eslint-legacy/package.json
- integrations/solid-vite/package.json
- packages/solid-query-devtools/package.json
- .github/workflows/autofix.yml
- examples/vue/simple/package.json
- examples/react/suspense/package.json
- examples/angular/devtools-panel/package.json
- examples/react/react-native/package.json
- examples/solid/simple/package.json
- examples/vue/basic/package.json
- packages/svelte-query/package.json
- packages/query-async-storage-persister/package.json
- examples/angular/infinite-query-with-max-pages/package.json
- examples/react/rick-morty/package.json
- packages/query-devtools/package.json
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-09-02T17:57:33.184Z
Learnt from: TkDodo Repo: TanStack/query PR: 9612 File: packages/query-async-storage-persister/src/asyncThrottle.ts:0-0 Timestamp: 2025-09-02T17:57:33.184Z Learning: When importing from tanstack/query-core in other TanStack Query packages like query-async-storage-persister, a workspace dependency "tanstack/query-core": "workspace:*" needs to be added to the package.json. Applied to files:
examples/svelte/auto-refetching/package.jsonexamples/angular/simple/package.jsonexamples/svelte/ssr/package.jsonpackages/query-core/package.jsonpackages/solid-query-persist-client/package.jsonexamples/svelte/star-wars/package.jsonpackages/query-persist-client-core/package.jsonpackages/react-query-devtools/package.jsonexamples/solid/default-query-function/package.jsonexamples/angular/optimistic-updates/package.jsonexamples/angular/router/package.jsonexamples/solid/astro/package.jsonexamples/solid/basic-graphql-request/package.jsonexamples/react/nextjs-suspense-streaming/package.jsonexamples/angular/rxjs/package.jsonexamples/angular/basic-persister/package.jsonexamples/svelte/optimistic-updates/package.jsonexamples/react/algolia/package.jsonpackage.jsonpackages/query-core/src/types.ts
📚 Learning: 2025-11-22T09:06:05.219Z
Learnt from: sukvvon Repo: TanStack/query PR: 9892 File: packages/solid-query-persist-client/src/__tests__/PersistQueryClientProvider.test.tsx:331-335 Timestamp: 2025-11-22T09:06:05.219Z Learning: In TanStack/query test files, when a queryFn contains side effects (e.g., setting flags for test verification), prefer async/await syntax for clarity; when there are no side effects, prefer the .then() pattern for conciseness. Applied to files:
packages/query-core/package.jsonpackages/query-persist-client-core/package.json
📚 Learning: 2025-08-19T03:18:18.303Z
Learnt from: oscartbeaumont Repo: TanStack/query PR: 9564 File: packages/solid-query-devtools/src/production.tsx:2-3 Timestamp: 2025-08-19T03:18:18.303Z Learning: In the solid-query-devtools package, the codebase uses a pattern of type-only default imports combined with typeof for component type annotations (e.g., `import type SolidQueryDevtoolsComp from './devtools'` followed by `typeof SolidQueryDevtoolsComp`). This pattern is consistently used across index.tsx and production.tsx files, and the maintainers prefer consistency over changing this approach. Applied to files:
packages/solid-query-persist-client/package.jsonexamples/react/react-router/package.jsonpackages/react-query-devtools/package.jsonexamples/solid/default-query-function/package.jsonexamples/solid/astro/package.jsonexamples/solid/basic-graphql-request/package.jsonpackages/solid-query/src/QueryClient.tspackages/react-query/src/types.tspackages/angular-query-experimental/src/types.tspackages/solid-query/src/types.tspackages/query-core/src/types.ts
📚 Learning: 2025-11-02T22:52:33.071Z
Learnt from: DogPawHat Repo: TanStack/query PR: 9835 File: packages/query-core/src/__tests__/queryClient.test-d.tsx:242-256 Timestamp: 2025-11-02T22:52:33.071Z Learning: In the TanStack Query codebase, the new `query` and `infiniteQuery` methods support the `select` option for data transformation, while the legacy `fetchQuery` and `fetchInfiniteQuery` methods do not support `select` and should reject it at the type level. Applied to files:
packages/solid-query/src/QueryClient.tspackages/react-query/src/types.tspackages/angular-query-experimental/src/types.tspackages/solid-query/src/types.tspackages/query-core/src/types.ts
🧬 Code graph analysis (1)
packages/angular-query-experimental/src/types.ts (3)
packages/svelte-query/src/types.ts (2)
CreateQueryOptions(39-44)CreateBaseQueryOptions(24-30)packages/query-core/src/types.ts (5)
DefaultError(47-51)QueryKey(53-61)OmitKeyof(19-29)InfiniteQueryObserverOptions(458-474)MutationObserverOptions(1149-1156)packages/solid-query/src/QueryClient.ts (1)
InfiniteQueryObserverOptions(42-68)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Test
🔇 Additional comments (30)
.github/workflows/pr.yml (2)
23-23: Action versions verified as valid and current.Both updated action versions have been confirmed as official, non-prerelease releases:
actions/checkout@v5.0.1— Valid release (published 2025-11-17)nrwl/nx-set-shas@v4.4.0— Valid release (published 2025-11-13)The patch update to checkout and minor update to nx-set-shas are legitimate and align with the PR's non-major version bump policy. The updates are applied consistently across all three checkout references in the workflow.
31-31: Version upgrade is safe with no breaking changes or compatibility issues.The v4.4.0 release contains only non-breaking improvements:
- A fix for merge-group behaviour supporting additional merge queue configurations
- No changes to action parameters or API
The existing
main-branch-name: mainparameter remains fully compatible with v4.4.0.packages/react-query/src/types.ts (1)
36-41: LGTM - Formatting improvements to type definitions.These changes restructure the
extendsclauses across multiple lines for better readability while preserving identical type semantics. The base types and omitted keys remain unchanged.Also applies to: 54-57, 70-73, 86-89, 109-118, 134-137, 197-200
packages/query-core/src/types.ts (1)
319-322: LGTM - Multi-line formatting for type declarations.All modifications are whitespace/formatting changes to
extendsclauses across various option and result interfaces. The type semantics, inheritance relationships, and generic parameter bindings remain unchanged.Also applies to: 464-474, 499-502, 517-523, 584-592, 1265-1333
packages/solid-query/src/QueryClient.ts (1)
19-29: LGTM - Consistent formatting updates.The changes apply multi-line formatting to
extendsclauses and add a trailing comma to theDefaultOptionsinterface. The type relationships (omittingstructuralSharingfrom core observer options and addingreconcile) remain unchanged.Also applies to: 48-57, 70-72
packages/angular-query-experimental/src/types.ts (1)
27-33: LGTM - Formatting aligned with sibling packages.The multi-line formatting changes to
extendsclauses are consistent with the same patterns applied inpackages/react-query/src/types.tsandpackages/solid-query/src/types.ts. Type semantics are preserved.Also applies to: 40-43, 81-90, 131-134
packages/solid-query/src/types.ts (1)
28-31: LGTM - Formatting consistency across the monorepo.The multi-line formatting changes to
extendsclauses follow the same pattern applied throughout this PR. The Solid-specific options (deferStream, deprecatedsuspense) and their documentation remain intact.Also applies to: 52-58, 96-105, 148-151
integrations/react-webpack-4/package.json (1)
14-17: Dependency versions look good.Babel toolchain updated to ^7.28.5 and babel-loader to ^8.4.1. These are safe minor/patch updates for the webpack 4 integration.
examples/react/nextjs-suspense-streaming/package.json (1)
14-14: Next.js patch version update is safe.Patch bump from ^16.0.1 to ^16.0.5 introduces fixes without breaking changes.
packages/query-test-utils/package.json (1)
38-38: npm-run-all2 patch bump is safe.Updated from ^5.0.0 to ^5.0.2, consistent with other packages in this PR.
examples/svelte/auto-refetching/package.json (1)
15-19: Svelte ecosystem updates are appropriate.Minor and patch updates across @sveltejs/kit, svelte, and related tooling. All non-breaking changes aligned with the PR's theme of non-major dependency updates.
examples/react/react-router/package.json (1)
17-19: Dependency updates look good.react-router, react-router-dom, rooks, and @vitejs/plugin-react bumps are safe minor/patch updates. Address the type definitions issue separately (see adjacent comment).
Also applies to: 26-26
examples/solid/default-query-function/package.json (1)
13-13: Solid.js ecosystem patches are safe.solid-js and vite-plugin-solid bumped to latest patch versions (^1.9.10 and ^2.11.10 respectively). Standard maintenance updates with no breaking changes.
Also applies to: 18-18
packages/query-core/package.json (1)
63-63: npm-run-all2 patch bump is safe.Updated to ^5.0.2, consistent with other packages in the PR.
packages/query-persist-client-core/package.json (1)
66-66: npm-run-all2 patch bump is safe.Updated to ^5.0.2, aligned with other packages in this PR.
packages/solid-query-persist-client/package.json (1)
73-76: Routine dependency maintenance.Solid.js ecosystem devDependencies receive standard minor/patch updates. Changes are non-breaking and align with the broader repository update pattern.
examples/react/chat/package.json (1)
17-19: Build tooling updates for React example.Tailwind CSS and Vite plugin updates are standard maintenance. Versions remain aligned with React 19 in the dependency set.
packages/react-query-devtools/package.json (1)
88-89: Standard tooling version updates.@vitejs/plugin-react and npm-run-all2 updates are compatible minor/patch versions with no breaking changes.
examples/solid/basic-graphql-request/package.json (1)
13-15: Solid.js GraphQL example dependency updates.GraphQL library and Solid.js ecosystem updates are standard minor/patch version bumps with no API-breaking changes expected.
Also applies to: 20-20
examples/svelte/star-wars/package.json (1)
15-21: Svelte ecosystem updates.Consistent minor/patch version bumps across SvelteKit framework and build tooling. @tailwindcss/vite and tailwindcss remain aligned.
examples/angular/rxjs/package.json (1)
13-16: Angular framework and tooling updates.Minor version bumps to Angular 20.3.x are within the safe update range. Ensure these versions work with your application's existing code patterns (template syntax, decorators, etc.).
Also applies to: 23-25
examples/angular/simple/package.json (1)
13-15: Angular framework and tooling updates.Minor version bumps to Angular 20.3.x are within the safe update range. Ensure these versions work with your application's existing code patterns.
Also applies to: 22-24
examples/svelte/optimistic-updates/package.json (1)
15-16: Svelte example dependency updates.SvelteKit framework and Svelte runtime receive standard minor/patch version bumps. No API-breaking changes expected within these ranges.
Also applies to: 18-19
examples/react/algolia/package.json (1)
11-11: Dependency updates align with PR constraints.The updates to
@algolia/client-search(5.2.1 → 5.45.0) and@vitejs/plugin-react(^4.3.4 → ^4.7.0) are both minor/patch changes within their major version ranges and comply with the PR's non-major update scope.Also applies to: 21-21
examples/svelte/ssr/package.json (1)
15-19: Svelte ecosystem updates are properly scoped to minor/patch changes.All Svelte-related dependency updates remain within their major version constraints (@sveltejs/*, svelte, svelte-check), complying with the PR's non-major update policy.
examples/solid/astro/package.json (1)
13-22: Solid/Astro ecosystem updates comply with PR constraints.All dependency updates in this file are properly constrained to minor and patch changes within their respective major versions, adhering to the PR's non-major update policy.
package.json (4)
8-8: pnpm packageManager update is appropriately scoped to patch level.The packageManager update from pnpm@10.17.0 to pnpm@10.23.0 is a patch-level change within the 10.x series, complying with the PR's non-major update policy.
43-68: DevDependency updates are properly constrained to minor/patch changes.All updated devDependencies in this range remain within their major version constraints (e.g., @arethetypeswrong/cli ^0.18.2, eslint ^9.39.1, knip ^5.70.2), adhering to the PR's non-major update scope.
72-81: TypeScript version aliases and new tool entries are appropriate configuration additions.The addition of
typescript50throughtypescript57aliases (mapping to npm:typescript@5.x) and new entries forviteandvitestare configuration enhancements for multi-version testing compatibility, not breaking changes.
83-110: pnpm overrides configuration correctly specifies workspace dependencies.The new
pnpm.overridessection appropriately pins all@tanstack/*packages toworkspace:*across the repository, ensuring consistent internal package versions. This is a standard monorepo pattern and poses no compatibility issues.
| "rxjs": "^7.8.2", | ||
| "tslib": "^2.8.1", | ||
| "zone.js": "0.15.0" | ||
| "zone.js": "0.16.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align zone.js version specifier to allow patch updates.
zone.js is pinned to exact version "0.16.0", but should use tilde range "~0.16.0" to allow patch-level updates for bug fixes and security improvements. This aligns with Angular's peer dependency conventions.
Apply this diff:
- "zone.js": "0.16.0" + "zone.js": "~0.16.0"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "zone.js": "0.16.0" | |
| "zone.js": "~0.16.0" |
🤖 Prompt for AI Agents
In examples/angular/simple/package.json around line 19, zone.js is pinned to an exact version "0.16.0"; change the version specifier to a tilde range "~0.16.0" so patch-level updates are allowed. Edit the dependency entry to replace the exact version with the tilde-prefixed range, save the file, and run npm install (or update lockfile) to ensure the dependency range is reflected in package-lock.json/yarn.lock. Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |

This PR contains the following updates:
5.2.1->5.45.0^20.0.0->^20.3.14^20.0.0->^20.3.12^20.0.0->^20.3.12^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^20.0.0->^20.3.14^0.15.3->^0.18.2^0.9.4->^0.9.6^5.0.7->^5.1.3^8.1.3->^8.2.11^7.26.0->^7.28.5^7.24.9->^7.28.5^7.26.0->^7.28.5^7.25.9->^7.28.5^2.29.5->^2.29.7^9.2.1->^9.3.2^2.0.1->^2.3.9^10.0.5->^10.0.11^0.4.4->^0.5.1^0.13.4->^0.13.11^1.2.2->^1.5.2^2.0.26->^2.1.3^0.15.3->^0.15.4^1.1.3->^1.2.0^6.1.0->^6.1.1^2.42.2->^2.49.0^2.4.0->^2.5.7^4.1.13->^4.1.17^4.0.14->^4.1.17^0.20.2->^0.22.1^5.90.2->^5.92.0^18.0.0->^18.1.1^10.4.0->^10.4.1^6.8.0->^6.9.1^16.1.0->^16.3.0^2.0.0->^2.0.2^5.2.8->^5.2.9^5.0.4->^5.0.6^8.44.1->^8.48.0^8.44.1->^8.48.0^8.44.1->^8.48.0^4.3.4->^4.7.0^4.3.4->^4.7.0^5.2.1->^5.2.4^1.1.36->^1.5.0^6.6.3->^6.6.4v5.0.0->v5.0.1^8.3.0->^8.4.1^7.0.0->^7.2.0^9.36.0->^9.39.1^50.5.0->^50.8.0^3.11.0->^3.13.0^10.5.0->^10.6.1^1.2.1->^1.2.2^52.0.11->^52.0.47^17.0.3->^17.1.7^2.0.0->^2.2.3^2.1.16->^2.1.18^16.9.0->^16.12.0^7.1.2->^7.3.5^5.6.3->^5.6.5^6.2.1->^6.2.2^27.0.0->^27.2.0^5.63.1->^5.70.2^4.0.2->^4.0.3^2.6.6->^2.12.3^16.0.1->^16.0.5^16.0.1->^16.0.5^5.0.0->^5.0.2v4.3.3->v4.4.0^3.12.4->^3.20.121.5.3->21.6.910.17.0->10.23.0^3.6.2->^3.7.1^0.3.13->^0.3.15^2.5.2->^2.6.0^0.76.3->^0.82.1^2.20.2->^2.29.1^5.12.5->^5.14.5^3.16.2->^3.19.4^4.12.0->^4.14.1^4.1.0->^4.18.0^0.19.13->^0.21.2^6.25.1->^6.30.2^6.25.1->^6.30.2^8.0.0->^8.4.0~7.8.0->~7.8.2^1.6.1->^1.9.0^1.9.7->^1.9.10^1.9.7->^1.9.10^0.2.3->^0.3.0^2.2.2->^2.2.5^5.39.3->^5.45.2^4.3.1->^4.3.4^4.1.13->^4.1.17^3.4.7->^3.4.18^4.0.14->^4.1.17^2.3.0->^2.8.1Summary by CodeRabbit
Chores
✏️ Tip: You can customize this high-level summary in your review settings.