fix: Flaky testPositionalQueryParameters #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: xs 
stephaniewang526 approved these changes May 24, 2022
stephaniewang526 added the owlbot:run 
gcf-owl-bot bot removed the owlbot:run stephaniewang526 added automerge gcf-owl-bot bot removed the owlbot:run 
gcf-merge-on-green bot removed the automerge 
gcf-merge-on-green bot pushed a commit that referenced this pull request May 25, 2022
🤖 I have created a release *beep* *boop* --- ## [2.12.0](v2.11.2...v2.12.0) (2022-05-25) ### Features * add build scripts for native image testing in Java 17 ([#1440](#1440)) ([#2057](#2057)) ([065ae78](065ae78)) ### Bug Fixes * add more native image configurations for Arrow tests and enable native image tests ([#2053](#2053)) ([7f0bfd4](7f0bfd4)) * Flaky testPositionalQueryParameters ([#2059](#2059)) ([3764b59](3764b59)) ### Dependencies * update dependency com.google.cloud:google-cloud-bigtable to v2.7.0 ([#2061](#2061)) ([1c7a0ab](1c7a0ab)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.11.0 ([#2055](#2055)) ([9667663](9667663)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.12.0 ([#2063](#2063)) ([6d3f4be](6d3f4be)) * update dependency com.google.cloud:google-cloud-storage to v2.7.0 ([#2064](#2064)) ([fd47710](fd47710)) * update dependency com.google.cloud:google-cloud-storage to v2.7.1 ([#2066](#2066)) ([89962a5](89962a5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
String comparison of values, eg
1.40845209522E9vs1408452095.22seems to be failing, so comparing the values as epoc (Long) insteadFixes #2056 ☕️