- Notifications
You must be signed in to change notification settings - Fork 68
deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 #1698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| You may have to update the C++ option. https://github.com/googleapis/sdk-platform-java/pull/1369/files#r1164950006 |
| ci / showcase is failing. => https://github.com/googleapis/sdk-platform-java/tree/main/showcase#update-the-golden-showcase-files @mpeddada1 Can you update the golden file? |
gax-java/dependencies.properties Outdated
| version.com_google_protobuf=3.21.12 | ||
| version.com_google_protobuf=3.23.1 | ||
| version.google_java_format=1.15.0 | ||
| version.io_grpc=1.54.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This version should be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Done.
| [gapic-generator-java-root] SonarCloud Quality Gate failed. |
| [java_showcase_integration_tests] SonarCloud Quality Gate failed. |
| [java_showcase_unit_tests] SonarCloud Quality Gate failed. |
| Sonar is complaining https://github.com/googleapis/sdk-platform-java/pull/1698/checks?check_run_id=13697463444
But we're not adding new code. It's fine. |








TODO: Close #1369 after this PR is merged.