api: use <scheme,provider> map in nameResoverRegistry #8323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ejona86 reviewed Jul 15, 2021
ejona86 approved these changes Jul 16, 2021
Member
ejona86 left a comment
ejona86 left a comment There was a problem hiding this comment.
I've audited the internal NameResolverProviders and all have a SCHEME.equals(uri.getScheme()) check, so I don't think this will break anything internally.
This was referenced Sep 21, 2021
Upgrade GRPC version due to new feature introduced in 1.40.0 version. grpc-ecosystem/grpc-spring#583
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Part of #7133.
It makes scheme matching more explicit in name resolver API. It slightly changed the existing behaviour because in this PR we pick effective providers early/when refreshing.
But it should not change effectiveness of e.g.
SecretGrpclbNameResolverProvider.