Add note about draft PRs to CONTRIBUTING.md #6247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #6247 +/- ## ========================================= Coverage 91.01% 91.01% Complexity 5685 5685 ========================================= Files 621 621 Lines 16642 16642 Branches 1703 1703 ========================================= Hits 15147 15147 Misses 1005 1005 Partials 490 490 ☔ View full report in Codecov by Sentry. |
jkwatson approved these changes Feb 24, 2024
jack-berg approved these changes Feb 28, 2024
Member
| Thanks @breedx-splk! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In the SIG meeting yesterday we decided to add a section to CONTRIBUTING.md that explains why we may close draft PRs, and we said we'd try and close old drafts after 6 generous months. Hopefully this captures what we discussed.